Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-MooseX-Log-Log4perl - A Logging Role for Moose based on Log::Log4perl
https://bugzilla.redhat.com/show_bug.cgi?id=469748
Summary: Review Request: perl-MooseX-Log-Log4perl - A Logging Role for Moose based on Log::Log4perl Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/MooseX-Log-Log4perl OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: cweyl@alumni.drew.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-Log-Log4perl.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-MooseX-Log-Log4perl-0.31-1.fc9.sr...
Description: A logging role building a very lightweight wrapper to Log::Log4perl for use with your the Moose classes. The initialization of the Log4perl instance must be performed prior to logging the first log message. Otherwise the default initialization will happen, probably not doing the things you expect.
For compatibility the 'logger' attribute can be accessed to use a common interface for application logging.
For simple logging needs use MooseX::Log::Log4perl::Easy to directly add log_<level> methods to your class instance.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=916576
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469748
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@gmail.com AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com 2008-11-04 05:37:59 EDT --- Review: + package builds in mock (rawhide). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=916902 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 302a2413b6faeff398cdb0a9f267e8d6 MooseX-Log-Log4perl-0.31.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=22, 1 wallclock secs ( 0.01 usr 0.01 sys + 0.98 cusr 0.06 csys = 1.06 CPU) + Package perl-MooseX-Log-Log4perl-0.31-1.fc10 => Provides: perl(MooseX::Log::Log4perl) = 0.31 perl(MooseX::Log::Log4perl::Easy) = 0.31 Requires: perl(Log::Log4perl) perl(Moose::Role)
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469748
--- Comment #2 from Chris Weyl cweyl@alumni.drew.edu 2008-11-04 11:31:42 EDT --- New Package CVS Request ======================= Package Name: perl-MooseX-Log-Log4perl Short Description: A Logging Role for Moose based on Log::Log4perl Owners: cweyl Branches: F-8 F-9 devel InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469748
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469748
--- Comment #3 from Chris Weyl cweyl@alumni.drew.edu 2008-11-04 17:03:32 EDT --- New Package CVS Request ======================= Package Name: perl-MooseX-Log-Log4perl Short Description: A Logging Role for Moose based on Log::Log4perl Owners: cweyl Branches: F-8 F-9 F-10 devel InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469748
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #4 from Kevin Fenzi kevin@tummy.com 2008-11-05 17:47:22 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=469748
Chris Weyl cweyl@alumni.drew.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
package-review@lists.fedoraproject.org