[Bug 1785977] New: Review Request: python-helpdev - HelpDev - Extracts information about the Python environment easily
https://bugzilla.redhat.com/show_bug.cgi?id=1785977
Bug ID: 1785977 Summary: Review Request: python-helpdev - HelpDev - Extracts information about the Python environment easily Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: nonamedotc@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/help... SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/help...
Description: Helping users and developers to get information about the environment to report bugs or even test your system without spending a day on it. It can get information about hardware, OS, paths, Python distribution and packages, including Qt-things.
Fedora Account System Username: nonamedotc
koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39893171
https://bugzilla.redhat.com/show_bug.cgi?id=1785977
Mukundan Ragavan nonamedotc@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1785982
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1785982 [Bug 1785982] Review Request: python-qdarkstyle - A dark stylesheet for Python and Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1785977
Mukundan Ragavan nonamedotc@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@in.waw.pl Blocks|1785982 | Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1785982 [Bug 1785982] Review Request: python-qdarkstyle - A dark stylesheet for Python and Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1785977
Mukundan Ragavan nonamedotc@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1785982
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1785982 [Bug 1785982] Review Request: python-qdarkstyle - A dark stylesheet for Python and Qt applications
https://bugzilla.redhat.com/show_bug.cgi?id=1785977
--- Comment #1 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- The package name is repeated in summary unnecessarily in summary.
%description is repeated. I'd suggest the standard trick with %expand:
%global _description %{expand: Helping users and developers to get information about the environment to report bugs or even test your system without spending a day on it. It can get information about hardware, OS, paths, Python distribution and packages, including Qt-things.}
%description %_description
%description -n python3-%{pypi_name} %_description
# install license file mkdir -p %{buildroot}/%{_datadir}/licenses/python3-%{pypi_name}/ cp -pr %{SOURCE1} %{buildroot}/%{_datadir}/licenses/python3-%{pypi_name}
It should suffice to do
%prep cp ${SOURCE1} .
But looking at the upstream repo, it already includes a license. Why not use that file? If it is not included in the pypi tarball, then provide a full URL to it: Source1: https://gitlab.com/dpizetta/helpdev/raw/master/LICENSE.rst
Anyway, package looks good. + name is OK + license is acceptable (MIT) + license is specified correctly (upstream talks about CC-BY-4.0 for images, but there are no images in the binary package, so this doesn't apply). + builds OK + P/BR look OK
Unfortunately the package does not install: - nothing provides python3dist(importlib-metadata) needed by python3-helpdev-0.6.10-1.fc32.noarch - nothing provides python3.8dist(importlib-metadata) needed by python3-helpdev-0.6.10-1.fc32.noarch
https://bugzilla.redhat.com/show_bug.cgi?id=1785977
--- Comment #2 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Ah, the package is retired with https://src.fedoraproject.org/rpms/python-importlib-metadata/blob/master/f/d...: Use the standard library importlib.metadata module instead.
https://gitlab.com/dpizetta/helpdev/merge_requests/1
https://bugzilla.redhat.com/show_bug.cgi?id=1785977
--- Comment #3 from Mukundan Ragavan nonamedotc@gmail.com --- I have made the changes pointed out. I have implemented the patch from the upstream PR using sed.
Modified SPEC: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/help... Modified SRPM: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/help...
https://bugzilla.redhat.com/show_bug.cgi?id=1785977
Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@fedoraproject.org |zbyszek@in.waw.pl Flags| |fedora-review+
--- Comment #4 from Zbigniew Jędrzejewski-Szmek zbyszek@in.waw.pl --- Remove: Requires: python3dist(importlib-metadata) and add in %prep sed -i "s|'importlib_metadata', ||" setup.py
(or maybe make it conditional for F<=31 if you want to build for older releases too...)
More formal review in comment #1. Package is APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1785977
--- Comment #5 from Mukundan Ragavan nonamedotc@gmail.com --- Thanks for the review. I will make the changes in c#4 when I import.
https://bugzilla.redhat.com/show_bug.cgi?id=1785977
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-helpdev
https://bugzilla.redhat.com/show_bug.cgi?id=1785977
Mukundan Ragavan nonamedotc@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2020-01-07 23:09:03
--- Comment #7 from Mukundan Ragavan nonamedotc@gmail.com --- Built on rawhide.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com