Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library) Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: rvinyard@cs.nmsu.edu QAContact: fedora-package-review@redhat.com
Spec URL: http://miskatonic.cs.nmsu.edu/pub/bitgtkmm.spec
SRPM URL: http://miskatonic.cs.nmsu.edu/pub/fedora/5/srpms/bitgtkmm-0.2.1-1.src.rpm
Description: The bitgtkmm library contains gtkmm widgets to display and manipulate the buffers, records, fields and elements of the bit library, as well as displaying data streams parsed by bit library specifications.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |183953
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
------- Additional Comments From rvinyard@cs.nmsu.edu 2006-06-23 00:54 EST ------- Spec URL: http://miskatonic.cs.nmsu.edu/pub/bitgtkmm.spec
SRPM URL: http://miskatonic.cs.nmsu.edu/pub/fedora/5/srpms/bitgtkmm-0.2.1-2.src.rpm
Changes: - Added AUTHORS and COPYING to bitgkmm main package - Changed prdownloads.sf.net to download.sf.net
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
------- Additional Comments From rvinyard@cs.nmsu.edu 2006-07-06 17:54 EST ------- Spec URL: http://miskatonic.cs.nmsu.edu/pub/bitgtkmm.spec
SRPM URL: http://miskatonic.cs.nmsu.edu/pub/fedora/5/srpms/bitgtkmm-0.2.2-1.src.rpm
Changes: - New upstream release - Removed *.md5, *.map and *.dot in upstream package - Changed mv of docs to cp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library)
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
Bug 192052 depends on bug 183953, which changed state.
Bug 183953 Summary: Review Request: bit (A bit-oriented data stream parser and gtkmm widget set) https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=183953
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library) Alias: bitgtkmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
rvinyard@cs.nmsu.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |bitgtkmm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library) Alias: bitgtkmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
paul@all-the-johnsons.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bugzilla-sink@leemhuis.info |paul@all-the-johnsons.co.uk OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-07-29 18:15 EST ------- %build %configure --enable-static=no %{__make} %{?_smp_mflags}
%install %{__rm} -rf %{buildroot}
make DESTDIR=%{buildroot} install
You need to be consistant with using macros. Either constantly use %{__make} or just plain make
I'll look some more later
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library) Alias: bitgtkmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
------- Additional Comments From rvinyard@cs.nmsu.edu 2006-07-29 18:56 EST ------- Ahh, good catch. %{__make} is probably better. I'll change it in papyrus too.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library) Alias: bitgtkmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-07-29 19:42 EST ------- Builds fine in mock. However.
Blocker : For the devel, you need to add bitgtkmm to the Requires list Blocker : run rpm -qa --requires on the installed bitgtkmm. Quite a lot of the output are for standard libs, but you cannot rely on people having gtkmm installed (or a few of the others)
Fix these and we should be good to go (more or less!)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library) Alias: bitgtkmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
------- Additional Comments From rvinyard@cs.nmsu.edu 2006-07-29 19:57 EST -------
Blocker : For the devel, you need to add bitgtkmm to the Requires list
It's there. It's in the standard devel line, right above the specific requires that I add for bitgtkmm: Requires: %{name} = %{version}-%{release} Puts a specific dependency on the main package and the specific version and release that the headers belong to.
How about if I change it to: Requires: bitgtkmm = %{version}-%{release}
Blocker : run rpm -qa --requires on the installed bitgtkmm. Quite a lot of the output are for standard libs, but you cannot rely on people having gtkmm installed (or a few of the others)
Those are all added by rpmbuild.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library) Alias: bitgtkmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-07-29 20:07 EST ------- 8--> It's there. It's in the standard devel line, right above the specific requires that I add for bitgtkmm: Requires: %{name} = %{version}-%{release} <--8
D'oh!
8-->
Blocker : run rpm -qa --requires on the installed bitgtkmm. Quite a lot of the output are for standard libs, but you cannot rely on people having gtkmm installed (or a few of the others)
Those are all added by rpmbuild. <--8
No. These are packages required to run. Say I didn't have atkmm on my machine (just as an example). Without the R atkmm being explictly states in the spec file, the package would know no better until it gets to a point that atkmm is needed and then it falls over dead.
I had a similar problem with Anjuta-1.2.4a a while back in that gtkmm was not in as an explicit R. However, when you came to try and create a gtkmm package, the software complained like crazy. Add the R line for gtkmm and everything was happy again.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library) Alias: bitgtkmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
------- Additional Comments From rvinyard@cs.nmsu.edu 2006-07-29 21:08 EST -------
No. These are packages required to run. Say I didn't have atkmm on my machine (just as an example). Without the R atkmm being explictly states in the spec file, the package would know no better until it gets to a point that atkmm is needed and then it falls over dead.
Check out: http://fedoraproject.org/wiki/Packaging/Guidelines#Requires
rpmbuild adds the requires, such as (continuing with the atkmm example): libatkmm-1.6.so.1()(64bit)
If you try and install bitgtkmm, rpm will complain that libatkmm-1.6.so.1 is required. If you're using yum, it will look up libatkmm-1.6.so.1 as a library in atkmm and add atkmm to the dependency installs.
The situation you ran into with Anjuta was a little different. The reason why you had to explicitly add it was that the Anjuta runtime didn't have a dependency on the gtkmm runtime libraries, so rpmbuild didn't add it to the rpm requires.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library) Alias: bitgtkmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-07-30 18:23 EST ------- Yep. You're right.
Okay - let's get on with this!
Good ----
Builds fine in mock (x86) Spec file checks out fine - no dupes, no problems with permissions, documentation included in subpackages, consistent use of macros, no BR problems Package installs fine, rpmlint shows nothing of importance on the packages (installed or as rpms)
Niggles -------
Unhappy with the *.so things in the %files and %files devel, but this is down to me and nothing that can be blocked.
I can't see any other problems with this.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library) Alias: bitgtkmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
paul@all-the-johnsons.co.uk changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED OtherBugsDependingO|163778 |163779 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library) Alias: bitgtkmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
------- Additional Comments From paul@city-fan.org 2006-07-31 07:25 EST ------- The -devel package includes a .pc file, which is useless without pkgconfig, ergo the -devel package should Require: pkgconfig
See also: http://fedoraproject.org/wiki/Packaging/IRCLog20060706
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library) Alias: bitgtkmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
------- Additional Comments From paul@all-the-johnsons.co.uk 2006-07-31 17:54 EST ------- Thanks - rpm -qa --provides though didn't show this. I'll remember this for future spec files.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library) Alias: bitgtkmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
------- Additional Comments From rvinyard@cs.nmsu.edu 2006-08-01 23:50 EST -------
Unhappy with the *.so things in the %files and %files devel
The -devel package includes a .pc file, which is useless without pkgconfig, ergo the -devel package should Require: pkgconfig
Fixed in the first build.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library) Alias: bitgtkmm
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192052
rvinyard@cs.nmsu.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: bitgtkmm (Gtkmm widgets for the bit library) Alias: bitgtkmm
https://bugzilla.redhat.com/show_bug.cgi?id=192052
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla