[Bug 1745834] New: Review Request: R-lifecycle - Manage the Life Cycle of your Package Functions

https://bugzilla.redhat.com/show_bug.cgi?id=1745834

Bug ID: 1745834
           Summary: Review Request: R-lifecycle - Manage the Life Cycle of
                    your Package Functions
           Product: Fedora
           Version: rawhide
            Status: NEW
         Component: Package Review
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://qulogic.fedorapeople.org//R-lifecycle.spec
SRPM URL: https://qulogic.fedorapeople.org//R-lifecycle-0.1.0-1.fc30.src.rpm

Description:
Manage the life cycle of your exported functions with shared conventions,
documentation badges, and non-invasive deprecation warnings. The 'lifecycle'
package defines four development stages (experimental, maturing, stable, and
questioning) and three deprecation stages (soft- deprecated, deprecated, and
defunct). It makes it easy to insert badges corresponding to these stages in
your documentation. Usage of deprecated functions are signalled with increasing
levels of non-invasive verbosity.

[Bug 1745834] Review Request: R-lifecycle - Manage the Life Cycle of your Package Functions

https://bugzilla.redhat.com/show_bug.cgi?id=1745834

--- Comment #1 from Elliott Sales de Andrade  ---
koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=37305905

[Bug 1745834] Review Request: R-lifecycle - Manage the Life Cycle of your Package Functions

https://bugzilla.redhat.com/show_bug.cgi?id=1745834

Robert-André Mauchin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #2 from Robert-André Mauchin  ---
Package approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Package have the default element marked as %%doc :doc, DESCRIPTION
- Package requires R-core.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 55 files have unknown license. Detailed
     output of licensecheck in
     /home/bob/packaging/review/R-lifecycle/review-R-
     lifecycle/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

R:
[x]: Package contains the mandatory BuildRequires.
[x]: The package has the standard %install section.

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

R:
[x]: The %check macro is present
[x]: Latest version is packaged.
     Note: Latest upstream version is 0.1.0, packaged version is 0.1.0

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: R-lifecycle-0.1.0-1.fc32.noarch.rpm
          R-lifecycle-0.1.0-1.fc32.src.rpm
R-lifecycle.noarch: W: spelling-error %description -l en_US signalled ->
signaled, signal led, signal-led
R-lifecycle.src: W: spelling-error %description -l en_US signalled -> signaled,
signal led, signal-led
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

[Bug 1745834] Review Request: R-lifecycle - Manage the Life Cycle of your Package Functions

https://bugzilla.redhat.com/show_bug.cgi?id=1745834

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |MODIFIED

--- Comment #3 from Fedora Update System  ---
FEDORA-2019-328ee49101 has been submitted as an update to Fedora 31.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-328ee49101

[Bug 1745834] Review Request: R-lifecycle - Manage the Life Cycle of your Package Functions

https://bugzilla.redhat.com/show_bug.cgi?id=1745834

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ON_QA

--- Comment #4 from Fedora Update System  ---
R-lifecycle-0.1.0-1.fc31 has been pushed to the Fedora 31 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-328ee49101

[Bug 1745834] Review Request: R-lifecycle - Manage the Life Cycle of your Package Functions

https://bugzilla.redhat.com/show_bug.cgi?id=1745834

Elliott Sales de Andrade  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Elliott Sales de Andrade  ---
Gwyn, I just noticed that you're main admin on the repo. Can you pass admin
along to me?

Also, it didn't post here.

[Bug 1745834] Review Request: R-lifecycle - Manage the Life Cycle of your Package Functions

https://bugzilla.redhat.com/show_bug.cgi?id=1745834

--- Comment #6 from Gwyn Ciesla  ---
Done.

[Bug 1745834] Review Request: R-lifecycle - Manage the Life Cycle of your Package Functions

https://bugzilla.redhat.com/show_bug.cgi?id=1745834

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
         Resolution|---                         |ERRATA
        Last Closed|                            |2019-09-14 00:07:11

--- Comment #7 from Fedora Update System  ---
R-lifecycle-0.1.0-1.fc31 has been pushed to the Fedora 31 stable repository. If
problems still persist, please make note of it in this bug report.

[Bug 1745834] Review Request: R-lifecycle - Manage the Life Cycle of your Package Functions

https://bugzilla.redhat.com/show_bug.cgi?id=1745834

--- Comment #8 from Elliott Sales de Andrade  ---
(In reply to Gwyn Ciesla from comment #6)
> Done.

Thanks. I've removed you now since that seemed to be a mistake.

[Bug 1745834] Review Request: R-lifecycle - Manage the Life Cycle of your Package Functions

https://bugzilla.redhat.com/show_bug.cgi?id=1745834

--- Comment #9 from Fedora Update System  ---
R-lifecycle-0.1.0-1.fc31 has been pushed to the Fedora 31 stable repository. If
problems still persist, please make note of it in this bug report.