[Bug 894666] New: Review Request: nodejs-difflet - Colorful diffs for JavaScript objects
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
Bug ID: 894666 Summary: Review Request: nodejs-difflet - Colorful diffs for JavaScript objects Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Reporter: tchollingsworth@gmail.com
Spec: http://patches.fedorapeople.org/npm/nodejs-difflet.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-difflet-0.2.3-1.fc17.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4863791 FAS username: patches
Creates colorful diffs for JavaScript objects,
This package is part of the tap stack used to test many Node.js modules.
Please use nodejs-0.6.5-9 or later when building or using this package.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
Michael Scherer misc@zarb.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |misc@zarb.org Depends On| |894664
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |894722
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |894724
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
Bug 894666 depends on bug 894664, which changed state.
Bug 894664 Summary: Review Request: nodejs-charm - ANSI control sequences for terminal cursor hopping and colors https://bugzilla.redhat.com/show_bug.cgi?id=894664
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |RAWHIDE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jamielinux@fedoraproject.or | |g
--- Comment #1 from Jamie Nguyen jamielinux@fedoraproject.org --- Tried building in mock (+ updates-testing + nodejs-traverse) but it requires npm(charm) as well:
DEBUG util.py:264: Error: Package: nodejs-difflet-0.2.3-1.fc18.noarch (/nodejs-difflet-0.2.3-1.fc18.noarch) DEBUG util.py:264: Requires: npm(charm) < 0.1 DEBUG util.py:264: Installing: nodejs-charm-0.1.0-1.fc18.noarch (updates-testing) DEBUG util.py:264: npm(charm) = 0.1.0
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
--- Comment #2 from T.C. Hollingsworth tchollingsworth@gmail.com --- Not sure what's going on here. nodejs-charm appears to be in F18 updates-testing here.
% yum provides 'npm(charm)' nodejs-charm-0.1.0-1.fc18.noarch : ANSI control sequences for terminal cursor hopping and colors Repo : updates-testing Matched from: Provides : npm(charm) = 0.1.0
% yum info nodejs-charm Available Packages Name : nodejs-charm Arch : noarch Version : 0.1.0 Release : 1.fc18 Size : 10 k Repo : updates-testing/18/x86_64 Summary : ANSI control sequences for terminal cursor hopping and colors URL : https://github.com/substack/node-charm License : MIT Description : Uses ANSI control sequences to write colors and cursor positions to terminals.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
--- Comment #3 from Jamie Nguyen jamielinux@fedoraproject.org --- It's the version dependency that's the problem. nodejs-difflet is asking for nodejs-charm 0.0.x whereas the version in updates-testing is 0.1.0 so you need to patch this out:
$ cat rpmbuild/SOURCES/nodejs-difflet-0.2.3-deps.patch diff -Naur a/package.json b/package.json --- a/package.json +++ b/package.json @@ -22,7 +22,7 @@ }, "dependencies" : { "traverse" : "0.6.x", - "charm" : "0.0.x", + "charm" : ">=0.0.0", "deep-equal" : "0.0.x" }, "devDependencies" : {
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |jamielinux@fedoraproject.or | |g Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
--- Comment #4 from T.C. Hollingsworth tchollingsworth@gmail.com --- Oh, sorry about that. Fixed now.
Spec: http://patches.fedorapeople.org/npm/nodejs-difflet.spec SRPM: http://patches.fedorapeople.org/npm/nodejs-difflet-0.2.3-2.fc18.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4954713
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
--- Comment #5 from Jamie Nguyen jamielinux@fedoraproject.org --- Package Review ==============
Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed
Issues: ======= [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShor...
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: Using prebuilt rpms. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [-]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [-]: Large documentation must go in a -doc subpackage. Note: Documentation size is 20480 bytes in 8 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [ ]: Buildroot is not present Note: Buildroot: present but not needed [ ]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (difflet-0.2.3.tgz) [x]: SourceX is a working URL. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
Rpmlint ------- Checking: nodejs-difflet-0.2.3-2.fc19.noarch.rpm nodejs-difflet-0.2.3-2.fc19.src.rpm nodejs-difflet.noarch: W: only-non-binary-in-usr-lib nodejs-difflet.noarch: W: dangling-symlink /usr/lib/node_modules/difflet/node_modules/traverse /usr/lib/node_modules/traverse nodejs-difflet.noarch: W: dangling-symlink /usr/lib/node_modules/difflet/node_modules/deep-equal /usr/lib/node_modules/deep-equal nodejs-difflet.noarch: W: dangling-symlink /usr/lib/node_modules/difflet/node_modules/charm /usr/lib/node_modules/charm 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint nodejs-difflet nodejs-difflet.noarch: W: only-non-binary-in-usr-lib nodejs-difflet.noarch: W: dangling-symlink /usr/lib/node_modules/difflet/node_modules/traverse /usr/lib/node_modules/traverse nodejs-difflet.noarch: W: dangling-symlink /usr/lib/node_modules/difflet/node_modules/deep-equal /usr/lib/node_modules/deep-equal nodejs-difflet.noarch: W: dangling-symlink /usr/lib/node_modules/difflet/node_modules/charm /usr/lib/node_modules/charm 1 packages and 0 specfiles checked; 0 errors, 4 warnings. # echo 'rpmlint-done:'
Requires -------- nodejs-difflet-0.2.3-2.fc19.noarch.rpm (rpmlib, GLIBC filtered):
nodejs(engine) >= 0.4.0 npm(charm) < 0.2 npm(charm) >= 0.1.0 npm(deep-equal) < 0.1 npm(deep-equal) >= 0.0 npm(traverse) < 0.7 npm(traverse) >= 0.6
Provides -------- nodejs-difflet-0.2.3-2.fc19.noarch.rpm:
nodejs-difflet = 0.2.3-2.fc19 npm(difflet) = 0.2.3
MD5-sum check ------------- http://registry.npmjs.org/difflet/-/difflet-0.2.3.tgz : CHECKSUM(SHA256) this package : 819c4797abcbbb3689bff0dbd0094936c5faff0c03016913dedfc82e32379460 CHECKSUM(SHA256) upstream package : 819c4797abcbbb3689bff0dbd0094936c5faff0c03016913dedfc82e32379460
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-18-x86_64 Command line :/bin/fedora-review --rpm-spec -n nodejs-difflet-0.2.3-2.fc19.src.rpm -p
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
Jamie Nguyen jamielinux@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #6 from Jamie Nguyen jamielinux@fedoraproject.org --- The comma in the description should be changed to a period, but otherwise review approved!
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #7 from T.C. Hollingsworth tchollingsworth@gmail.com --- New Package SCM Request ======================= Package Name: nodejs-difflet Short Description: Colorful diffs for JavaScript objects Owners: patches Branches: f18 el6 InitialCC:
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- nodejs-amdefine-0.0.4-1.fc18, nodejs-buffer-equal-0.0.0-1.fc18, nodejs-charm-0.1.0-1.fc18, nodejs-deep-equal-0.0.0-2.fc18, nodejs-optimist-0.3.5-1.fc18, nodejs-source-map-0.1.8-3.fc18, nodejs-traverse-0.6.3-2.fc18, nodejs-wordwrap-0.0.2-2.fc18, nodejs-yamlish-0.0.5-1.fc18, nodejs-difflet-0.2.3-2.fc18, uglify-js1-1.3.4-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/nodejs-amdefine-0.0.4-1.fc18,nodejs-...
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- nodejs-amdefine-0.0.4-1.fc18, nodejs-buffer-equal-0.0.0-1.fc18, nodejs-charm-0.1.0-1.fc18, nodejs-deep-equal-0.0.0-2.fc18, nodejs-optimist-0.3.5-1.fc18, nodejs-source-map-0.1.8-3.fc18, nodejs-traverse-0.6.3-2.fc18, nodejs-wordwrap-0.0.2-2.fc18, nodejs-yamlish-0.0.5-1.fc18, nodejs-difflet-0.2.3-2.fc18, uglify-js1-1.3.4-1.fc18 has been pushed to the Fedora 18 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
Bug 894666 depends on bug 894722, which changed state.
Bug 894722 Summary: Review Request: nodejs-traverse - Traverse and transform objects https://bugzilla.redhat.com/show_bug.cgi?id=894722
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |RAWHIDE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed| |2013-02-15 21:37:23
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |ERRATA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=894666
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- nodejs-amdefine-0.0.4-1.fc18, nodejs-buffer-equal-0.0.0-1.fc18, nodejs-charm-0.1.0-1.fc18, nodejs-deep-equal-0.0.0-2.fc18, nodejs-optimist-0.3.5-1.fc18, nodejs-source-map-0.1.8-3.fc18, nodejs-traverse-0.6.3-2.fc18, nodejs-wordwrap-0.0.2-2.fc18, nodejs-yamlish-0.0.5-1.fc18, nodejs-difflet-0.2.3-2.fc18, uglify-js1-1.3.4-1.fc18 has been pushed to the Fedora 18 stable repository.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla