Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: couchdb-glib - A glib api to access CouchDB servers
https://bugzilla.redhat.com/show_bug.cgi?id=527231
Summary: Review Request: couchdb-glib - A glib api to access CouchDB servers Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: pbrobinson@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
SPEC: http://pbrobinson.fedorapeople.org/couchdb-glib.spec SRPM: http://pbrobinson.fedorapeople.org/couchdb-glib-0.5.0-1.fc12.src.rpm
Description: CouchDB-GLib is a GLib-based API to access CouchDB servers (http://couchdb.apache.org), a replication/synchronization schema-free database of JSON documents, used in online services like Midgard.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=527231
--- Comment #1 from Peter Robinson pbrobinson@gmail.com 2009-10-05 09:53:36 EDT --- koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1727893
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=527231
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |527245
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=527231
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lemenkov@gmail.com AssignedTo|nobody@fedoraproject.org |lemenkov@gmail.com Flag| |fedora-review?
--- Comment #2 from Peter Lemenkov lemenkov@gmail.com 2009-10-05 12:21:01 EDT --- I'll review it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=527231
--- Comment #3 from Peter Lemenkov lemenkov@gmail.com 2009-10-07 06:09:04 EDT --- REVIEW:
+ rpmlint is silent
[petro@Sulaco SPECS]$ rpmlint ~/fuse/sshfs/work/Desktop/couchdb-glib-* couchdb-glib-devel.ppc: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings. [petro@Sulaco SPECS]$
+ The package is named according to the Package Naming Guidelines . + The spec file name matches the base package %{name}, in the format %{name}.spec . + The package meets the Packaging Guidelines . + The package is licensed with a Fedora approved license and meets the Licensing Guidelines . + The License field in the package spec file matches the actual license. + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package matches the upstream source, as provided in the spec URL.
ftp://ftp.gnome.org/pub/gnome/sources/couchdb-glib/0.5/couchdb-glib-0.5.0.sha256sum
0e04edd440706f031b952011b8a12f99d9a13b356f2a2abf778ada786e4540ae couchdb-glib-0.5.0.tar.bz2
+ The package successfully compiles and builds into binary rpms on at least one primary architecture (see koji logs above). + All build dependencies are listed in BuildRequires. + The package calls ldconfig in %post and %postun. + The package does NOT bundle copies of system libraries. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. + Everything, a package includes as %doc, does not affect the runtime of the application. + Header files are in a -devel package. + Since the package contains pkgconfig(.pc) files, it 'Requires: pkgconfig'. + A library files that ends in .so (without suffix) are in a -devel package. + The devel sub-package requires the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} + The package does NOT contain any .la libtool archives. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages must be valid UTF-8.
BTW ver. 0.5.1 is out, while you packaged 0.5.0.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=527231
--- Comment #4 from Peter Robinson pbrobinson@gmail.com 2009-10-07 06:49:11 EDT --- (In reply to comment #3)
BTW ver. 0.5.1 is out, while you packaged 0.5.0.
I was aware of 0.5.1 being out but the first time I tried to build it it looked there was a requirement of a new json. But it seems when I try now its not the case so I must have missed something. Updated:
SPEC: http://pbrobinson.fedorapeople.org/couchdb-glib.spec SRPM: http://pbrobinson.fedorapeople.org/couchdb-glib-0.5.1-1.fc12.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1732705
Is there anything else outstanding?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=527231
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #5 from Peter Lemenkov lemenkov@gmail.com 2009-10-07 07:09:30 EDT --- I just checked - it seems, that this package is only for F-12+
http://koji.fedoraproject.org/koji/taskinfo?taskID=1732761 http://koji.fedoraproject.org/koji/taskinfo?taskID=1732743
As for F-10 - it will be EOLed soon.
Anyway, keep this in mind when you'll request cvs branches.
From ftp://ftp.gnome.org/pub/gnome/sources/couchdb-glib/0.5/couchdb-glib-0.5.1.sha256sum :
8112eded52aa706963e139b771a3d336da64176d08dbf1cc45fe983459e784d6 couchdb-glib-0.5.1.tar.bz2
[petro@Sulaco SOURCES]$ sha256sum couchdb-glib-0.5.1.tar.bz2 8112eded52aa706963e139b771a3d336da64176d08dbf1cc45fe983459e784d6 couchdb-glib-0.5.1.tar.bz2 [petro@Sulaco SOURCES]$
sha256sums matches and no other changes, so this package is
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=527231
--- Comment #6 from Peter Robinson pbrobinson@gmail.com 2009-10-07 07:41:05 EDT --- Thanks. It actually does build on F-11 (I think possibly F-10 too but wasn't planning on doing so) but the libuuid dep requirement is actually contained in e2fsprogs-devel so that's a know issue but easily fixed :-)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=527231
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #7 from Peter Robinson pbrobinson@gmail.com 2009-10-07 07:42:09 EDT --- New Package CVS Request ======================= Package Name: couchdb-glib Short Description: A glib api to access CouchDB servers Owners: pbrobinson Branches: F-12 F-11 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=527231
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #8 from Kevin Fenzi kevin@tummy.com 2009-10-08 02:01:25 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=527231
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
--- Comment #9 from Peter Robinson pbrobinson@gmail.com 2009-10-08 02:27:09 EDT --- Imported and built in F-13 rawhide. F-12 on its way.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla