Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=431356
Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: jonathan.underwood@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://jgu.fedorapeople.org/dvipng.spec SRPM URL: http://jgu.fedorapeople.org/dvipng-1.9-1.fc9.src.rpm Description: This program makes PNG and/or GIF graphics from DVI files as obtained from TeX and its relatives.
It is intended to produce anti-aliased screen-resolution images as fast as is possible. The target audience is people who need to generate and regenerate many images again and again.
Commentary: Patrice Dumas recently made a call for packages to split out components of texlive for which texlive is not upstream. This is one such package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format
https://bugzilla.redhat.com/show_bug.cgi?id=431356
------- Additional Comments From jonathan.underwood@gmail.com 2008-02-03 09:34 EST ------- Spec URL: http://jgu.fedorapeople.org/dvipng.spec SRPM URL: http://jgu.fedorapeople.org/dvipng-1.9-2.fc9.src.rpm
* Sun Feb 3 2007 Jonathan G. Underwood jonathan.underwood@gmail.com - 1.9-2 - Install dvigif info file - Add Provides for dvigif
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format
https://bugzilla.redhat.com/show_bug.cgi?id=431356
------- Additional Comments From pertusus@free.fr 2008-02-03 15:02 EST ------- The release should be at least 16+1 since 16 is the current dvipng from texlive release.
there is no dvigif info manual.
I don't think the Provides for dvigif is useful.
The kpathsea requires is also certainly unneeded since it should be automatically detected.
I suggest using make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' to keep the man page timestamp.
To keep the changelogs timestamp, you can use iconv -f ISO-8859-1 -t UTF8 $i > $i.utf8 && touch -r $i $i.utf8 && mv $i.utf8 $i
I suggest removing the .gz from the file names in the install-info scriptlets, install-info does it automatically.
I also suggest using globs for man pages and info files, like %{_infodir}/dvipng.info* %{_mandir}/man1/dvigif.1* %{_mandir}/man1/dvipng.1*
The license of the doc seems to be the OFSFDL.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format
https://bugzilla.redhat.com/show_bug.cgi?id=431356
------- Additional Comments From jonathan.underwood@gmail.com 2008-02-03 16:54 EST ------- Spec URL: http://jgu.fedorapeople.org/dvipng.spec SRPM URL: http://jgu.fedorapeople.org/dvipng-1.9-50.fc9.src.rpm
* Sun Feb 3 2007 Jonathan G. Underwood jonathan.underwood@gmail.com - 1.9-50 - Remove kpathsea Requires - Add OFSFDL license tag - Make INSTALL use install -p - Preserve time stamp of ChangeLog and ChangeLog.0 files - Use globbing in filelist - Remove .gz from the end of filenames in install-info commands - Bump release to 50 to fix up upgrade path from current dvipng package from texlive
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format
https://bugzilla.redhat.com/show_bug.cgi?id=431356
pertusus@free.fr changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |pertusus@free.fr Status|NEW |ASSIGNED Flag| |fedora-review+
------- Additional Comments From pertusus@free.fr 2008-02-03 18:08 EST ------- * rpmlint is silent * follow packaging guidelines * free software * works as intended * match upstream: 9107065e4da9a18dfff2c1a76fbbf919 dvipng-1.9.tar.gz * %files section right
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format
https://bugzilla.redhat.com/show_bug.cgi?id=431356
------- Additional Comments From jonathan.underwood@gmail.com 2008-02-03 18:17 EST ------- Splendid, cheers Patrice. Can I put you as a co-maintainer?
Jindrich - same question to you - are you willing to be a co-maintainer?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format
https://bugzilla.redhat.com/show_bug.cgi?id=431356
------- Additional Comments From pertusus@free.fr 2008-02-03 18:30 EST ------- Yes, you can.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format
https://bugzilla.redhat.com/show_bug.cgi?id=431356
jonathan.underwood@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From jonathan.underwood@gmail.com 2008-02-03 20:42 EST ------- New Package CVS Request ======================= Package Name: dvipng Short Description: Converts DVI files to PNG/GIF format Owners: jgu,pertusus,jnovy Branches: InitialCC: Cvsextras Commits: Yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format
https://bugzilla.redhat.com/show_bug.cgi?id=431356
------- Additional Comments From jonathan.underwood@gmail.com 2008-02-03 20:43 EST ------- Jindrich - have added you as a co-maintainer, but if you'd rather not be, it's trivial to change it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format
https://bugzilla.redhat.com/show_bug.cgi?id=431356
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-02-04 14:41 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format
https://bugzilla.redhat.com/show_bug.cgi?id=431356
jonathan.underwood@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From jonathan.underwood@gmail.com 2008-02-04 20:27 EST ------- Thanks Kevin. Thanks Patrice.
Package imported and built.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format
https://bugzilla.redhat.com/show_bug.cgi?id=431356
------- Additional Comments From jnovy@redhat.com 2008-02-14 00:18 EST ------- Jonathan, thanks for adding me as comaintainer. I returned from vacations yesterday, so I couldn't take action sooner.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: dvipng - Converts DVI files to PNG/GIF format
https://bugzilla.redhat.com/show_bug.cgi?id=431356
------- Additional Comments From jonathan.underwood@gmail.com 2008-02-14 05:02 EST ------- Hi Jindrich - no problem. Hope you had a good vacation.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla