[Bug 438892] New: Review Request: pyPdf - PDF toolkit - package-review

List overview All Threads
Download

newer

[Bug 438892] New: Review Request: pyPdf - PDF toolkit

older

[Bug 435287] New: Review Request:...

[Bug 443195] New: Review Request:...

Red Hat Bugzilla

25 Mar 2008 25 Mar '08

9:15 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=438892

Summary: Review Request: pyPdf - PDF toolkit Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: felix.schwarz@oss.schwarz.eu QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com

Spec URL: http://www.felix-schwarz.name/files/misc/2008/pypdf/pypdf.spec SRPM URL: http://www.felix-schwarz.name/files/misc/2008/pypdf/pyPdf-1.10-1.fc8.src.rpm Description: A Pure-Python library built as a PDF toolkit. It is capable of: * extracting document information (title, author, ...), * splitting documents page by page, * merging documents page by page, * cropping pages, * merging multiple pages into a single page, * encrypting and decrypting PDF files.

As this is my first RPM which I submit to Fedora, I need a sponsor.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Show replies by date

Red Hat Bugzilla

25 Mar 25 Mar

9:16 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

felix.schwarz@oss.schwarz.eu changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

9:28 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

------- Additional Comments From ncorrare@redhat.com 2008-03-25 16:28 EST ------- Rpmlint says: pyPdf.src: E: invalid-spec-name pypdf.spec pyPdf.src: W: invalid-license modified BSD

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:10 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

------- Additional Comments From felix.schwarz@oss.schwarz.eu 2008-03-25 18:10 EST ------- Sorry, I ran rpmlint only on the spec file.

Updated version: http://www.felix-schwarz.name/files/misc/2008/pypdf/pyPdf.spec http://www.felix-schwarz.name/files/misc/2008/pypdf/pyPdf-1.10-2.fc8.src.rpm

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

27 Mar 27 Mar

10:13 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

------- Additional Comments From felix.schwarz@oss.schwarz.eu 2008-03-27 17:13 EST ------- New version: - removed unnecessary python_sitearch macro declaration

http://www.felix-schwarz.name/files/misc/2008/pypdf/1.10-3/pyPdf-1.10-3.fc8.... http://www.felix-schwarz.name/files/misc/2008/pypdf/1.10-3/pyPdf.spec

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

28 Mar 28 Mar

10:56 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

timothy.selivanow@virtualxistenz.com changed:

------- Additional Comments From timothy.selivanow@virtualxistenz.com 2008-03-28 17:56 EST ------- Everything looks good. No rpmlint output. Builds fine on Koji for dist-f9 http://koji.fedoraproject.org/koji/taskinfo?taskID=536803.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:18 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

------- Additional Comments From wolfy@nobugconsulting.ro 2008-03-28 18:18 EST ------- well done, Kairo, please proceed with http://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure#head-1ef2...

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:19 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

------- Additional Comments From wolfy@nobugconsulting.ro 2008-03-28 18:19 EST ------- sorry for the noise, wrong bz ticket

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

1 Apr 1 Apr

12:38 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

paul@city-fan.org changed:

------- Additional Comments From paul@city-fan.org 2008-04-01 06:38 EST ------- Review:

- rpmlint clean - package naming satisfies python module naming guidelines - spec file name matches package name - package meets packaging guidelines - license is BSD, matches package - license text not in separate file, but included directly in python source files, which are of course packaged and thus license texts are included in the package - spec file written in English and is legible - sources match upstream (md5sum e15eca1a3ed4d5c0d86370784e552a92) - package builds OK in mock on i386 and x86_64 for Fedora 9 - buildreqs OK - no shared libraries, static libraries, header files, pkgconfig files, or locale files to worry about - package doesn't claim to be relocatable - directory ownership OK - no duplicate files - %defattr(...) present and correct in %files section - %clean section present and correct - %install section properly cleans buildroot first - macro usage is consistent - code, not content - docs don't affect runtime - not a GUI app, no desktop file needed - filenames are all ASCII - I haven't tested that the package functions OK as it's basically a library for use with other apps - no scriptlets or subpackages - no file dependencies

Suggestions:

Use a more specific files list, e.g. %{python_sitelib}/pyPdf* this helps catch future changes that create extra files in the package, which you might want to document further in the changelog etc.

Include CHANGELOG in %doc

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4:41 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

tkuratom@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |tkuratom@redhat.com

------- Additional Comments From tkuratom@redhat.com 2008-04-01 10:41 EST ------- One other strenuous suggestion: Please query upstream to include a LICENSE file in the package. Especially with the BSD license that has several variants of which one can be problematic ("BSD with advertising"), this can be important.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

4:51 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

------- Additional Comments From paul@city-fan.org 2008-04-01 10:51 EST ------- (In reply to comment #8)

...

One other strenuous suggestion: Please query upstream to include a LICENSE file in the package. Especially with the BSD license that has several variants of which one can be problematic ("BSD with advertising"), this can be important.

The license text for this package is actually included in (some of) the source files, and is the 3-clause BSD license without the advertising clause. It may not be possible to have a single license file because not all of the files have the same copyright holders.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

11:22 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

------- Additional Comments From felix.schwarz@oss.schwarz.eu 2008-04-01 17:22 EST ------- Update the package according to comment #7. I can ask upstream if a license file can be included in the upstream tarball but I hope this package can be included in Fedora even without this.

Updated files at: http://www.felix-schwarz.name/files/misc/2008/pypdf/1.10-4/

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

2 Apr 2 Apr

12:20 a.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

paul@city-fan.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+

------- Additional Comments From paul@city-fan.org 2008-04-01 18:20 EST ------- (In reply to comment #10)

...

Update the package according to comment #7. I can ask upstream if a license file can be included in the upstream tarball but I hope this package can be included in Fedora even without this.

Please do; it's not a blocker though.

...

Updated files at: http://www.felix-schwarz.name/files/misc/2008/pypdf/1.10-4/

Approved. You can apply for cvsextras membership in the accounts system now.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

1:58 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

felix.schwarz@oss.schwarz.eu changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?

------- Additional Comments From felix.schwarz@oss.schwarz.eu 2008-04-02 07:58 EST ------- New Package CVS Request ======================= Package Name: pyPdf Short Description: PDF toolkit Owners: fschwarz Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

7:58 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-04-02 13:58 EST ------- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

13 Apr 13 Apr

7:50 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

felix.schwarz@oss.schwarz.eu changed:

------- Additional Comments From felix.schwarz@oss.schwarz.eu 2008-04-13 13:50 EST ------- pyPdf imported into CVS, builds well (and should be pushed to F-8 soon, see https://admin.fedoraproject.org/updates/F8/pending/pyPdf-1.10-4.fc8).

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

21 Apr 21 Apr

4:01 a.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

dev@nigelj.com changed:

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

12 May 12 May

11:30 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

felix.schwarz@oss.schwarz.eu changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?

------- Additional Comments From felix.schwarz@oss.schwarz.eu 2008-05-12 17:30 EST ------- Package Change Request ====================== Package Name: pyPdf New Branches: EL-4 EL-5

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Red Hat Bugzilla

13 May 13 May

7:07 p.m.

New subject: [Bug 438892] Review Request: pyPdf - PDF toolkit

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pyPdf - PDF toolkit

https://bugzilla.redhat.com/show_bug.cgi?id=438892

kevin@tummy.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+

------- Additional Comments From kevin@tummy.com 2008-05-13 13:07 EST ------- cvs done.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

6280

Age (days ago)

6329

Last active (days ago)

package-review@lists.fedoraproject.org

18 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla