[Bug 1901106] New: Review Request: rust-pam-sys - FFI rust crate

https://bugzilla.redhat.com/show_bug.cgi?id=1901106

Bug ID: 1901106
           Summary: Review Request: rust-pam-sys - FFI rust crate
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: http://www.usenix.org.uk/rpm/rust-pam-sys.spec
SRPM URL: http://www.usenix.org.uk/rpm/rust-pam-sys-0.5.6-1.fc34.src.rpm
Description: Rust FFI wrappers for the Linux Pluggable Authentication Modules
Fedora Account System Username: eneville

This is a dependency for rust-pam.

[Bug 1901106] Review Request: rust-pam-sys - FFI rust crate

https://bugzilla.redhat.com/show_bug.cgi?id=1901106

[e-mail]  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1901106] Review Request: rust-pam-sys - FFI rust crate

https://bugzilla.redhat.com/show_bug.cgi?id=1901106

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           Doc Type|---                         |If docs needed, set a value

--- Comment #1 from Robert-André Mauchin 🐧  ---
 - You should specify what you patched in a comment:

# Initial patched metadata
# Bump blah to X, PR: https://...
Patch0:         pam-sys-fix-metadata.diff

Patching libc is unnecessary:

[dependencies.libc]
-version = "0.2.39"
+version = "0.2"

0.2.39 will work with any patch number below 0.3

- You must include the license files with %license in %files devel:

%files          devel
%license LICENSE-APACHE LICENSE-MIT

- You should include CHANGELOG.md in %doc

%doc CHANGELOG.md README.md

[Bug 1901106] Review Request: rust-pam-sys - FFI rust crate

https://bugzilla.redhat.com/show_bug.cgi?id=1901106

--- Comment #2 from Robert-André Mauchin 🐧  ---
 - You need to add a Requires for pam in the devel subpackage:

%package        devel
Summary:        %{summary}
BuildArch:      noarch
Requires:       pam-devel

%description    devel %{_description}

- You should BuildRequires pam-devel like this:

%generate_buildrequires
%cargo_generate_buildrequires
echo 'pam-devel'

[Bug 1901106] Review Request: rust-pam-sys - FFI rust crate

https://bugzilla.redhat.com/show_bug.cgi?id=1901106

--- Comment #3 from [e-mail]  ---
Thanks for looking, I believe the changes are now ready in the following:

Spec URL: http://www.usenix.org.uk/rpm/rust-pam-sys.spec
SRPM URL: http://www.usenix.org.uk/rpm/rust-pam-sys-0.5.6-1.fc35.src.rpm
Description: Rust FFI wrappers for the Linux Pluggable Authentication Modules

[Bug 1901106] Review Request: rust-pam-sys - FFI rust crate

https://bugzilla.redhat.com/show_bug.cgi?id=1901106

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #4 from Robert-André Mauchin 🐧  ---
Package approved. You still need to find a sponsor as described in
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

[Bug 1901106] Review Request: rust-pam-sys - FFI rust crate

https://bugzilla.redhat.com/show_bug.cgi?id=1901106

Rémi Lauzier  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1941896
                 CC|                            |[e-mail]

--- Comment #5 from Rémi Lauzier  ---
*** Bug 1943989 has been marked as a duplicate of this bug. ***

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1941896
[Bug 1941896] Review Request: rust-rudo - rudo is a small equivalent of sudo
writen in rust

[Bug 1901106] Review Request: rust-pam-sys - FFI rust crate

https://bugzilla.redhat.com/show_bug.cgi?id=1901106

Rémi Lauzier  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1944463

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1944463
[Bug 1944463] Review Request: rust-pam-client - Application API wrapper to
Pluggable Authentication Modules (PAM)

[Bug 1901106] Review Request: rust-pam-sys - FFI rust crate

https://bugzilla.redhat.com/show_bug.cgi?id=1901106

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841 (FE-NEEDSPONSOR)     |
              Flags|fedora-review+              |fedora-review?

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor

[Bug 1901106] Review Request: rust-pam-sys - FFI rust crate

https://bugzilla.redhat.com/show_bug.cgi?id=1901106

Robert-André Mauchin 🐧  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |POST
              Flags|fedora-review?              |fedora-review+

--- Comment #6 from Robert-André Mauchin 🐧  ---
Sponsored.

[Bug 1901106] Review Request: rust-pam-sys - FFI rust crate

https://bugzilla.redhat.com/show_bug.cgi?id=1901106

--- Comment #7 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-pam-sys

[Bug 1901106] Review Request: rust-pam-sys - FFI rust crate

https://bugzilla.redhat.com/show_bug.cgi?id=1901106

Orion Poplawski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?([e-mail]
                   |                            |)
                 CC|                            |[e-mail]

--- Comment #8 from Orion Poplawski  ---
Robert-André - Are you still interested in rust packaging for Fedora?

[Bug 1901106] Review Request: rust-pam-sys - FFI rust crate

https://bugzilla.redhat.com/show_bug.cgi?id=1901106

[e-mail]  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?([e-mail] |
                   |)                           |

--- Comment #9 from [e-mail]  ---
This is here https://src.fedoraproject.org/rpms/rust-pam-sys, please let me
know if I've misunderstood.

[Bug 1901106] Review Request: rust-pam-sys - FFI rust crate

https://bugzilla.redhat.com/show_bug.cgi?id=1901106

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         Resolution|---                         |CURRENTRELEASE
             Status|POST                        |CLOSED
        Last Closed|                            |2022-08-16 20:51:56

--- Comment #10 from Fabio Valentini  ---
The only thing that's missing here is to close the bug, since the package was
imported to Fedora.