Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189013
Summary: Review Request: python-sqlalchemy - Modular and flexible ORM library for python Product: Fedora Extras Version: devel Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: normal Component: Package Review AssignedTo: bugzilla-sink@leemhuis.info ReportedBy: shahms@shahms.com QAContact: fedora-package-review@redhat.com
Spec URL: http://shahms.mesd.k12.or.us/packages/python-sqlalchemy.spec SRPM URL: http://shahms.mesd.k12.or.us/packages/python-sqlalchemy-0.1.6-1.src.rpm Description: SQLAlchemy is an Object Relational Mappper (ORM) that provides a flexible, high-level interface to SQL databases. Database and domain concepts are decoupled, allowing both sides maximum flexibility and power. SQLAlchemy provides a powerful mapping layer that can work as automatically or as manually as you choose, determining relationships based on foreign keys or letting you define the join conditions explicitly, to bridge the gap between database and domain.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-sqlalchemy - Modular and flexible ORM library for python
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189013
jpmahowald@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|bugzilla-sink@leemhuis.info |jpmahowald@gmail.com OtherBugsDependingO|163776 |163778 nThis| |
------- Additional Comments From jpmahowald@gmail.com 2006-05-16 11:14 EST ------- - rpmlint checks return:
W: python-sqlalchemy wrong-file-end-of-line-encoding /usr/share/doc/python-sqlalchemy-0.1.6/doc/build/content/tutorial.txt E: python-sqlalchemy wrong-script-end-of-line-encoding /usr/share/doc/python-sqlalchemy-0.1.6/doc/build/runhtml.py W: python-sqlalchemy wrong-file-end-of-line-encoding /usr/share/doc/python-sqlalchemy-0.1.6/doc/build/testdocs.py W: python-sqlalchemy wrong-file-end-of-line-encoding /usr/share/doc/python-sqlalchemy-0.1.6/doc/build/txt2myt.py
Easily fixed with sed or perl.
W: python-sqlalchemy doc-file-dependency /usr/share/doc/python-sqlalchemy-0.1.6/doc/build/runhtml.py /usr/bin/env
python will be installed, so this should be fine.
- package meets naming guidelines - package meets packaging guidelines - license (MIT) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream
Change source URL to download.sourceforge.net however, to automate downloads.
- package compiles on FC5 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - no need for .desktop file
doc web server script thing doesn't work. $ ./runhtml.py : No such file or directory
This is end of line problem as mentioned previously. Also, these scripts seem to convert and write html files, which fails due to permissions. You could generate this html in your %install phase, elminating the need for these scripts.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-sqlalchemy - Modular and flexible ORM library for python
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189013
------- Additional Comments From shahms@shahms.com 2006-05-16 13:44 EST ------- Thanks for looking at the packages. Considering all of the rpmlint problems were related to the scripts for building the documentation (which is already built in the source tar ball), they are removed and not installed with the actual documentation. I also updated to the newest upstream version (0.1.7). http://shahms.mesd.k12.or.us/packages/python-sqlalchemy.spec http://shahms.mesd.k12.or.us/pacakges/python-sqlalchemy-0.1.7-1.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-sqlalchemy - Modular and flexible ORM library for python
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189013
jpmahowald@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| |
------- Additional Comments From jpmahowald@gmail.com 2006-05-17 20:57 EST ------- rpmlint and I are happy now.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-sqlalchemy - Modular and flexible ORM library for python
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189013
shahms@shahms.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-sqlalchemy - Modular and flexible ORM library for python
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189013
bugzilla@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora
toshio@tiki-lounge.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From toshio@tiki-lounge.com 2007-07-24 14:25 EST ------- Package Change Request ====================== Package Name: python-sqlalchemy New Branches: EL-5 Updated Fedora Owners: shahms@shahms.com,toshio@tiki-lounge.com,ivazqueznet@gmail.com Updated Fedora CC: Updated EPEL Owners: shahms@shahms.com,toshio@tiki-lounge.com,ivazqueznet@gmail.com
Officially adding comaintainers and branching for EPEL-5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-sqlalchemy - Modular and flexible ORM library for python
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189013
wtogami@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-sqlalchemy - Modular and flexible ORM library for python
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189013
ivazqueznet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
------- Additional Comments From ivazqueznet@gmail.com 2007-07-30 13:22 EST ------- Package Change Request ====================== Package Name: python-sqlalchemy Updated EPEL Owners: shahms@shahms.com,toshio@tiki-lounge.com
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: python-sqlalchemy - Modular and flexible ORM library for python
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189013
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From tibbs@math.uh.edu 2007-07-30 13:47 EST ------- CVS done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=189013
Rahul Sundaram metherid@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |metherid@gmail.com Flag|fedora-cvs+ |fedora-cvs?
--- Comment #7 from Rahul Sundaram metherid@gmail.com 2011-07-12 05:53:31 EDT ---
Package Change Request ====================== Package Name: python-sqlalchemy New Branches: el6 Owners: sundaram pjp InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=189013
--- Comment #8 from Jon Ciesla limb@jcomserv.net 2011-07-12 08:38:21 EDT --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org