[Bug 488172] New: Package Review: ibus-table-wubi

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Package Review: ibus-table-wubi

https://bugzilla.redhat.com/show_bug.cgi?id=488172

Summary: Package Review: ibus-table-wubi
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Keywords: i18n
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail],
                    [e-mail], [e-mail],
                    [e-mail], [e-mail]
        Depends on: 488010
            Blocks: 484650
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

A split from ibus-table-chinese, which was sub-package of ibus-table.

Uploading srpm and spec.

[Bug 488172] Package Review: ibus-table-zhengma

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488172

Caius "kaio" Chance  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Package Review:             |Package Review:
                   |ibus-table-wubi             |ibus-table-zhengma

[Bug 488172] Package Review: ibus-table-zhengma

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488172

Jens Petersen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]         |[e-mail]

[Bug 488172] Package Review: ibus-table-zhengma

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488172

Bug 488172 depends on bug 488010, which changed state.

Bug 488010 Summary: Review Request: ibus-table-cangjie - Cang Jie input method for ibus-table.
https://bugzilla.redhat.com/show_bug.cgi?id=488010

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

[Bug 488172] Package Review: ibus-table-zhengma

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488172

--- Comment #1 from Caius "kaio" Chance   2009-04-01 22:47:49 EDT ---
SRPM URL:
http://cchance.fedorapeople.org/packaging/ibus-table-zhengma-1.1.0.20090402-...
Spec URL: http://cchance.fedorapeople.org/packaging/ibus-table-zhengma.spec
Description: A split from ibus-table-chinese, which was sub-package of
ibus-table.

[Bug 488172] Package Review: ibus-table-zhengma

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488172

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

--- Comment #2 from Parag AN(पराग)   2009-04-03 01:43:11 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1274694
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
5981da2341988d13ebd0c6c01bcb047f  ibus-table-zhengma-1.1.0.20090402.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ ibus-table-createdb scriptlet used.
+ file permissions are appropriate.
+ Not a GUI App.

Suggestions:
1) check header of zhengma.txt table file. Can you confirm license with
upstream if it really is GPLv3+?
2) try adding contents to Changelog file in upstream and add it as %doc

[Bug 488172] Package Review: ibus-table-zhengma

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488172

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |CLOSED
         Resolution|                            |CANTFIX
               Flag|fedora-review?              |fedora-review-

--- Comment #4 from Parag AN(पराग)   2009-04-06 23:47:40 EDT ---
Looks like patent problem here.

[Bug 488172] Package Review: ibus-table-zhengma

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=488172

--- Comment #5 from Caius "kaio" Chance   2009-04-07 01:37:22 EDT ---
Patent should be expired in DEC 09.