[Bug 549593] New: Review Request: tumbler - D-Bus service for applications to request thumbnails

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: tumbler - D-Bus service for applications to request thumbnails

https://bugzilla.redhat.com/show_bug.cgi?id=549593

Summary: Review Request: tumbler - D-Bus service for
                    applications to request thumbnails
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: http://sundaram.fedorapeople.org/packages/tumbler.spec
SRPM URL:
http://sundaram.fedorapeople.org/packages/tumbler-0.1.0-2.fc13.src.rpm
Description:

Tumbler is a D-Bus service for applications to request thumbnails for various
URI schemes and MIME types. It is an implementation of the thumbnail
management D-Bus specification described on
http://live.gnome.org/ThumbnailerSpec written in an object-oriented fashion

[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549593

--- Comment #2 from Debarshi Ray  2010-01-15 16:49:11 EST ---
I anyway needed to build this after I updated my laptop so thought I might as
well help you along.

Spec: http://rishi.fedorapeople.org/tumbler.spec
SRPM: http://rishi.fedorapeople.org/tumbler-0.1.1-1.fc12.src.rpm

[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549593

--- Comment #3 from Christoph Wickert  2010-01-25 21:12:03 EST ---
Rahul, please update your package or update the one from Debarshi according to
my comments from comment 1. Builds fine in mock now, I guess this was a rawhide
problem.

Additionally there still is a missing builddep for the jpeg plugin:

Build Configuration:
  * Debug:                                     minimum
Plugins:
  * GdkPixbuf thumbnailer plugin:              yes
  * FreeType font thumbnailer plugin:          yes
  * JPEG thumbnailer plugin with EXIF support: no
  * Freedesktop.org cache plugin:              yes

[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549593

Christoph Wickert  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(sundaram@redhat.c
                   |                            |om)

--- Comment #4 from Christoph Wickert  2010-02-24 20:12:34 EST ---
Any progress on this?

[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549593

Rahul Sundaram  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Rahul Sundaram  2010-02-25 02:52:11 EST ---

Sorry for the delay and the spec was missing a few BR's that have been added
now

http://sundaram.fedorapeople.org/packages/tumbler.spec
http://sundaram.fedorapeople.org/packages/tumbler-0.1.1-2.fc12.src.rpm

[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549593

Christoph Wickert  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?,             |fedora-review+
                   |needinfo?(sundaram@redhat.c |
                   |om)                         |

--- Comment #6 from Christoph Wickert  2010-02-27 18:43:48 EST ---
OK - MUST: named according to the Package Naming Guidelines
OK - MUST: spec file name matches the base package %{name}
OK - MUST: package meets the Packaging Guidelines
OK - MUST: license file included in %doc
OK - MUST: spec is in American English
OK - MUST: spec is legible
OK - MUST: sources match the upstream source by MD5
f3f9c549ddac430904f61d80ebf7d1ac
OK - MUST: successfully compiles and builds into binary rpms on x86_64
OK - MUST: no ExcludeArch.
OK - MUST: all build dependencies are listed in BuildRequires.
OK - MUST: handles locales properly with %find_lang
OK - MUST: calls ldconfig in %post and %postun
OK - MUST: does not bundle copies of system libraries.
OK - MUST: not designed to be relocatable
OK - MUST: owns all directories that it creates
OK - MUST: no duplicate files in the %files listing
OK - MUST: permissions on files are set properly, includes %defattr(...)
OK - MUST: package has a %clean section, which contains rm -rf $RPM_BUILD_ROOT.
OK - MUST: consistently uses macros
OK - MUST: package contains code, or permissable content
N/A - MUST: Large documentation files should go in a -doc subpackage
OK - MUST: Files included as %doc do not affect the runtime of the application
OK - MUST: Header files must be in a -devel package
N/A - MUST: Static libraries must be in a -static package
OK - MUST: If a package contains library files with a suffix, then library
files that end in .so must go in a -devel package.
OK - MUST: devel packages must require the base package using a fully versioned
dependency
OK - MUST: The package does not contain any .la libtool archives.
N/A - MUST: Packages containing GUI applications must include a %{name}.desktop
file
OK - MUST: package does not own files or directories already owned by other
packages.
OK - MUST: all filenames valid UTF-8

SHOULD Items:
OK - SHOULD: Source package includes license text(s) as a separate file.
N/A - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
OK - SHOULD: builds in mock.
OK - SHOULD: compiles and builds into binary rpms on all supported
architectures.
OK - SHOULD: functions as described.
OK - SHOULD: Scriptlets are sane.
N/A - SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
OK - SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg
OK - SHOULD: no file dependencies outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin

Other items:
OK - latest stable version
OK - SourceURL valid
OK - Compiler flags ok
OK - Debuginfo complete

Issues:
- License tag should be GPLv2+ and LGPLv2+ because the libs are LGPLv2+ and
only tumblerd is GPLv2+

- make is not verbose (V=1)

- $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/tumbler-*
tumbler.src: W: no-cleaning-of-buildroot %install
tumbler.src: W: no-buildroot-tag
tumbler.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 15, tab: line 1)
4 packages and 0 specfiles checked; 0 errors, 3 warnings.

Although the buildroot tag and the cleaning of buildroot are no longer
required, it cant hurt to have them. Same for Same for 'Requires: pkgconfig' in
the devel package.

Fix the first two, the rest is up to you.

APPROVED

[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549593

Rahul Sundaram  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #7 from Rahul Sundaram  2010-02-28 13:40:53 EST ---
New Package CVS Request
=======================
Package Name: tumbler
Short Description: D-Bus service for applications to request thumbnails
Owners: sundaram
Branches: F-12 
InitialCC:

It would help at some point if one of the Xfce maintainers apply to be a
co-maintainer for this one

[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549593

--- Comment #8 from Christoph Wickert  2010-02-28 13:59:15 EST ---
Sure, no problem.

New Package CVS Request
=======================
Package Name: tumbler
Short Description: D-Bus service for applications to request thumbnails
Owners: sundaram cwickert kevin
Branches: F-12
InitialCC:

Do we want a F-13 branch as well?

[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549593

--- Comment #9 from Rahul Sundaram  2010-02-28 14:11:02 EST ---
Yep I forgot about the early branching

New Package CVS Request
=======================
Package Name: tumbler
Short Description: D-Bus service for applications to request thumbnails
Owners: sundaram
Branches: F-12  F-13
InitialCC:

[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549593

--- Comment #10 from Rahul Sundaram  2010-02-28 14:12:11 EST ---

Sigh  Third time should be right

New Package CVS Request
=======================
Package Name: tumbler
Short Description: D-Bus service for applications to request thumbnails
Owners: sundaram cwickert kevin
Branches: F-12  F-13
InitialCC:

[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549593

--- Comment #11 from Jason Tibbitts  2010-02-28 17:31:30 EST ---
CVS done (by process-cvs-requests.py).

[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549593

Rahul Sundaram  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549593

Orion Poplawski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|fedora-cvs+                 |fedora-cvs?

--- Comment #12 from Orion Poplawski  2011-05-20 11:40:54 EDT ---
Package Change Request
======================
Package Name: tumbler
New Branches: el6
Owners: sundaram cwickert kevin
InitialCC:

[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549593

--- Comment #13 from Kevin Fenzi  2011-05-20 18:25:49 EDT ---
Git done (by process-git-requests).

[Bug 549593] Review Request: tumbler - D-Bus service for applications to request thumbnails

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=549593

--- Comment #14 from Rahul Sundaram  2011-05-20 18:31:16 EDT ---

umm.  why am I being listed as a owner for the EL6 branch.  I don't even own
the other Fedora branches anymore.