[Bug 1295138] New: Review Request: marsshooter - M.A.R.S. - A ridiculous shooter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295138

Bug ID: 1295138
           Summary: Review Request: marsshooter - M.A.R.S. - A ridiculous
                    shooter
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://fedorapeople.org/~jwrdegoede/marsshooter.spec
SRPM URL:
https://fedorapeople.org/~jwrdegoede/marsshooter-0.7.5-1.git4fb920e.fc23.src...
Description:
M.A.R.S. - a ridiculous shooter is a 2D space shooter with awesome visual
effects and attractive physics. Players can battle each other or computer
controlled enemies in exciting game modes.

In the year 3547, civilizations all over the galaxy have settled their own
planets, living in peace and harmony with its environment. But outside the
contemplative habitats, the GREAT WAR is raging. As a famous fighter on
your way to never ending honor and prosperity, you have to protect your
planet from the oncoming doom of your jealous neighbours!

Fedora Account System Username: jwrdegoede

[Bug 1295138] Review Request: marsshooter - M.A.R.S. - A ridiculous shooter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295138

Antonio Trande  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 1295138] Review Request: marsshooter - M.A.R.S. - A ridiculous shooter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295138

--- Comment #1 from Antonio Trande  ---
Fails on rawhide:

-- Detecting CXX compile features - done
CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:148
(message):
  Could NOT find OpenGL (missing: OPENGL_gl_LIBRARY OPENGL_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:388
(_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake/Modules/FindOpenGL.cmake:168
(FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:31 (find_package)
-- Configuring incomplete, errors occurred!
See also
"/builddir/build/BUILD/M.A.R.S.-4fb920e97d350a8777e06ce28c1657ad3a3fa3fb/CMakeFiles/CMakeOutput.log".
error: Bad exit status from /var/tmp/rpm-tmp.hiqXyN (%build)
    Bad exit status from /var/tmp/rpm-tmp.hiqXyN (%build)
RPM build errors:

[Bug 1295138] Review Request: marsshooter - M.A.R.S. - A ridiculous shooter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295138

--- Comment #2 from Hans de Goede  ---
My bad, sorry.

I was planning to run the pkg through mock to get the BuildRequires right, but
at the end of a long day I forgot and submitted it without proper
BuildRequires.

Here is a new version with this fixed:

Spec URL: https://fedorapeople.org/~jwrdegoede/marsshooter.spec
SRPM URL:
https://fedorapeople.org/~jwrdegoede/marsshooter-0.7.5-2.git4fb920e.fc23.src...

Regards,

Hans

[Bug 1295138] Review Request: marsshooter - M.A.R.S. - A ridiculous shooter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295138

--- Comment #3 from Antonio Trande  ---
I have just seen that this package is already in Fedora:
https://admin.fedoraproject.org/pkgdb/package/rpms/marsshooter/

[Bug 1295138] Review Request: marsshooter - M.A.R.S. - A ridiculous shooter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295138

Hans de Goede  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |DUPLICATE
        Last Closed|                            |2016-01-10 08:25:57

--- Comment #4 from Hans de Goede  ---
(In reply to Antonio Trande from comment #3)
> I have just seen that this package is already in Fedora:
> https://admin.fedoraproject.org/pkgdb/package/rpms/marsshooter/

Ah, oops, sorry about that. That one seems based on an old version though,
which contains some non free files. I'll contact the current packager and
prepare an update to my version which has all the non free resources replaced.
In the mean time lets mark this one as a duplicate of the original review-req.

*** This bug has been marked as a duplicate of bug 1177942 ***

[Bug 1295138] Review Request: marsshooter - M.A.R.S. - A ridiculous shooter

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295138

Antonio Trande  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |

--- Comment #5 from Antonio Trande  ---
(In reply to Hans de Goede from comment #4)
> (In reply to Antonio Trande from comment #3)
> > I have just seen that this package is already in Fedora:
> > https://admin.fedoraproject.org/pkgdb/package/rpms/marsshooter/
>
> Ah, oops, sorry about that. That one seems based on an old version though,
> which contains some non free files.

I'm really sorry; I myself reviewed M.A.R.S. on Fedora and I haven't seen
non-free fonts
> I'll contact the current packager and
> prepare an update to my version which has all the non free resources
> replaced. In the mean time lets mark this one as a duplicate of the original
> review-req.

Thank you very much.