https://bugzilla.redhat.com/show_bug.cgi?id=1102942
Bug ID: 1102942 Summary: Review Request: php-phpoffice-phpexcel - A pure PHP library for reading and writing spreadsheet files Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: shawn.iwinski@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/f1636de9a2caf5c8ee109a4fb0f7...
SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-phpoffice-phpexcel-1.8.0-1.201405...
Description: Project providing a set of classes for the PHP programming language, which allow you to write to and read from different spreadsheet file formats, like Excel (BIFF) .xls, Excel 2007 (OfficeOpenXML) .xlsx, CSV, Libre/OpenOffice Calc .ods, Gnumeric, PDF, HTML, ... This project is built around Microsoft's OpenXML standard and PHP.
Fedora Account System Username: siwinski
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1102941 (php-pclzip) Alias| |php-phpoffice-phpexcel
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1102941 [Bug 1102941] Review Request: php-pclzip - Compression and extraction functions for Zip formatted archives
https://bugzilla.redhat.com/show_bug.cgi?id=1102942 Bug 1102942 depends on bug 1102941, which changed state.
Bug 1102941 Summary: Review Request: php-pclzip - Compression and extraction functions for Zip formatted archives https://bugzilla.redhat.com/show_bug.cgi?id=1102941
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
Remi Collet rcollet@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rcollet@redhat.com
--- Comment #1 from Remi Collet rcollet@redhat.com --- The PHPExcel / Shared / OLE part is obviously same code than pear/ole which is available in Fedora (from pear) and also alive in packagist and github https://github.com/pear/OLE
Can you please try to see the dif between the 2 versions and ask upstream why they don't simply use upstream version with a composer depedency ?
Also, which changes in phpexcel are needed which can't be merged in ole.
This will also fix the license issue.
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| |NotReady
--- Comment #2 from Shawn Iwinski shawn.iwinski@gmail.com --- Marking this review as NotReady until I can answer the question in comment #1 -- see https://github.com/PHPOffice/PHPExcel/issues/407
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
Shawn Iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|NotReady |
--- Comment #3 from Shawn Iwinski shawn.iwinski@gmail.com --- Response from upstream regarding OLE: https://github.com/PHPOffice/PHPExcel/issues/407#issuecomment-49647361
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com
--- Comment #4 from Remi Collet fedora@famillecollet.com --- Can you please open a FPC ticket for bundling exception ? Seems really a fork of a dead project, so should be ok.
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #5 from Shawn Iwinski shawn.iwinski@gmail.com --- https://fedorahosted.org/fpc/ticket/454
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
mejiko kame55-itasenpara123@y2.dion.ne.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kame55-itasenpara123@y2.dio | |n.ne.jp Blocks| |182235 (FE-Legal)
--- Comment #6 from mejiko kame55-itasenpara123@y2.dion.ne.jp --- I think that "Excel" is trademark.
http://tsdr.uspto.gov/#caseNumber=78400429&caseType=SERIAL_NO&search...
http://tsdr.uspto.gov/#caseNumber=85467589&caseType=SERIAL_NO&search...
I suggest that rename software name.
Blocking FE-Legal.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@redhat.com Blocks|182235 (FE-Legal) |
--- Comment #7 from Tom "spot" Callaway tcallawa@redhat.com --- The use of the trademark "excel" is nominative here, since we are using it in a minimal way to describe this applications support and manipulation of the excel file format. Thus, the use is considered fair use and appropriate. Lifting FE-Legal.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #8 from Remi Collet fedora@famillecollet.com --- According to https://fedorahosted.org/fesco/ticket/1483 the bundling is no more an issue.
So check if the package need to be refreshed and add the required
bundled(pear/ole)
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #9 from Upstream Release Monitoring upstream-release-monitoring@fedoraproject.org --- siwinski's scratch build of php-phpoffice-phpexcel-1.8.1-1.fc22.src.rpm for f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11375778
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #10 from Shawn Iwinski shawn.iwinski@gmail.com --- (In reply to Remi Collet from comment #8)
According to https://fedorahosted.org/fesco/ticket/1483 the bundling is no more an issue.
So check if the package need to be refreshed and add the required
bundled(pear/ole)
I used "bundled(php-pear-OLE)" instead to follow "New names must follow the rules one would use were the library to be packaged separately" -- https://lists.fedoraproject.org/pipermail/packaging/2015-October/011051.html
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/81dd3f8cdeb0754a591811a001ee...
SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-phpoffice-phpexcel-1.8.1-1.fc22....
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |fedora@famillecollet.com
--- Comment #11 from Remi Collet fedora@famillecollet.com --- Created attachment 1081803 --> https://bugzilla.redhat.com/attachment.cgi?id=1081803&action=edit phpci.log
phpCompatInfo version 4.5.1 DB built Oct 11 2015 19:05:51 CEST static analyze results
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #12 from Remi Collet fedora@famillecollet.com --- Created attachment 1081804 --> https://bugzilla.redhat.com/attachment.cgi?id=1081804&action=edit review.txt
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+
--- Comment #13 from Remi Collet fedora@famillecollet.com --- Everything ok. No Blocker
=== APPROVED ===
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
shawn iwinski shawn.iwinski@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #14 from shawn iwinski shawn.iwinski@gmail.com --- THANKS for the review!!!
New Package SCM Request ======================= Package Name: php-phpoffice-phpexcel Short Description: A pure PHP library for reading and writing spreadsheet files Upstream URL: https://github.com/PHPOffice/PHPExcel Owners: siwinski Branches: f21 f22 f23 el6 epel7 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #15 from Jon Ciesla limburgher@gmail.com --- This SCM request method has been deprecated. Please see https://fedoraproject.org/wiki/PackageDB_admin_requests.
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #16 from Shawn Iwinski shawn.iwinski@gmail.com --- SCM request submitted via pkgdb
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-eebe3d6719
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-eebe3d6719
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-fc29c2ddd8
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-fc29c2ddd8
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-1641d69ac7
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #20 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8cfe865957
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #21 from Shawn Iwinski shawn.iwinski@gmail.com --- php-phpoffice-phpexcel-1.8.1-1.fc21 has been submitted as an update to Fedora 21. https://bodhi.fedoraproject.org/updates/FEDORA-2015-5e502f2b93
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update php-phpoffice-phpexcel' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-1641d69ac7
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.fc21 has been pushed to the Fedora 21 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update php-phpoffice-phpexcel' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-5e502f2b93
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #24 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'dnf --enablerepo=updates-testing update php-phpoffice-phpexcel' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-eebe3d6719
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #25 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update php-phpoffice-phpexcel' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-fc29c2ddd8
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #26 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with $ su -c 'yum --enablerepo=epel-testing update php-phpoffice-phpexcel' You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-8cfe865957
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #27 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2015-10-23 12:18:52
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #28 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #29 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #30 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1102942
--- Comment #31 from Fedora Update System updates@fedoraproject.org --- php-phpoffice-phpexcel-1.8.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org