Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: dbus-cxx - C++ wrapper for dbus
https://bugzilla.redhat.com/show_bug.cgi?id=500492
Summary: Review Request: dbus-cxx - C++ wrapper for dbus Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rvinyard@cs.nmsu.edu QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://miskatonic.cs.nmsu.edu/pub/dbus-cxx.spec SRPM URL: http://miskatonic.cs.nmsu.edu/pub/dbus-cxx-0.1.0-1.fc10.src.rpm
Description: dbus-cxx is yet another dbus C++ wrapper. What differentiates dbus-cxx from other C++ wrappers is that dbus-cxx relies heavily on sigc++ and explicitly exposes the wrapped dbus C API.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500492
Jochen Schmitt jochen@herr-schmitt.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jochen@herr-schmitt.de AssignedTo|nobody@fedoraproject.org |jochen@herr-schmitt.de Flag| |fedora-review?
--- Comment #1 from Jochen Schmitt jochen@herr-schmitt.de 2009-05-13 15:01:18 EDT --- Good: + Basename of the SPEC files matches with Package name + Package name fullfill the naming guidelines + Package has proper License tag + License tag exclaims GPLv3 as a valid OSS license + Source files has GPLv3 copyright note in the header + Package contains verbatin text of the license + URL tag shows on proper project home page + consistently usage of rpm macros + Package contains most recent version of the application + Could download upstream source tar ball via spectool -g + Package source tar ball matches with upstream /md5sum: 028c2acd8f551ea9d68cc6b01c668b41 ) + Package contains several subpackages + Subpackages has proper RPM group + Package has proper Buildroot defintion + Buildroot will be cleaned on the beginning of %clean and %install + Package has SMP build + Local build works fine + Build honors RPM_OPt_FLAGS + Rpmlint is silent on source rpm + Rpmlint complaints $ rpmlint dbus-cxx-tools-0.1.0-1.fc10.x86_64.rpm dbus-cxx-tools.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. This is acceeptable + Rpmlint is silent on debuginfo file + Debuginfo rpm contains sources + Local install and uninstall works fine + Package has proper ldconfig scriptlets + Packaged files has proper files properties + %files stanza contains no duplicates files + Packaged files are own by the package + Packaged files has no conflict with ohter packages + Devel package contains no *.la or *.a files + Package has proper %Changelog stanza
Bad: - %doc stanza on devel subpackage seem to be large, It will be nice to have a extra subpackage for it - Scratch build on koji fails http://koji.fedoraproject.org/koji/taskinfo?taskID=1353480
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500492
--- Comment #2 from Rick L Vinyard Jr rvinyard@cs.nmsu.edu 2009-05-14 15:26:31 EDT --- I added a doc subpackage.
As for the scratch build, it looks like strstr() has changed between F10 and F12. The man page for F10 says it returns a char* and it looks like F12 returns a const char*.
Either way I was able to change it to a const char* and it should build (it built on F11, and I'm not sure how to do a scratch build for a non-fedora package).
I pushed out a new release, so here is the new spec and srpm for 0.1.1: http://miskatonic.cs.nmsu.edu/pub/dbus-cxx.spec http://miskatonic.cs.nmsu.edu/pub/dbus-cxx-0.1.1-1.fc10.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500492
--- Comment #3 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-05-14 15:35:51 EDT --- Just a note:
(In reply to comment #2)
As for the scratch build, it looks like strstr() has changed between F10 and F12. The man page for F10 says it returns a char* and it looks like F12 returns a const char*.
This is: https://www.redhat.com/archives/fedora-devel-list/2009-January/msg02248.html (affects C++, not C)
and I'm not sure how to do a scratch build for a non-fedora package).
$ koji build --scratch <target> <srpm_you_want_to_try> will do. The successfully rebuilt packages are put on http://koji.fedoraproject.org/scratch/<your_FAS_name>/ .
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500492
Jochen Schmitt jochen@herr-schmitt.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #4 from Jochen Schmitt jochen@herr-schmitt.de 2009-05-14 15:54:28 EDT --- Because, you have publsh a new upstream release:
Good: + Could download tar ball from upstream: + Packaged tar ball matches with upstream (md5sum: 969929227ba787f76ac50cb199e2fb14) + Package has a extra subpackage for developers documentation + Koji build works fine.
Question: Are you the upstream developer? I ask it, because I can't see any patch to solve your gcc-4.4/c++ issue.
Your package is APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500492
--- Comment #5 from Rick L Vinyard Jr rvinyard@cs.nmsu.edu 2009-05-14 16:12:05 EDT --- (In reply to comment #4)
Question: Are you the upstream developer? I ask it, because I can't see any patch to solve your gcc-4.4/c++ issue.
Yes. It makes patching so much easier. :)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500492
Rick L Vinyard Jr rvinyard@cs.nmsu.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #6 from Rick L Vinyard Jr rvinyard@cs.nmsu.edu 2009-05-14 16:44:23 EDT --- New Package CVS Request ======================= Package Name: dbus-cxx Short Description: C++ wrapper for dbus Owners: rvinyard Branches: F-9 F-10 F-11 InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500492
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #7 from Kevin Fenzi kevin@tummy.com 2009-05-15 19:59:10 EDT --- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500492
Rick L Vinyard Jr rvinyard@cs.nmsu.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500492
Rick L Vinyard Jr rvinyard@cs.nmsu.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #8 from Rick L Vinyard Jr rvinyard@cs.nmsu.edu 2009-09-29 18:10:27 EDT --- CVS branch request: EL-5
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=500492
Kevin Fenzi kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
--- Comment #9 from Kevin Fenzi kevin@tummy.com 2009-09-30 19:53:02 EDT --- cvs done.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla