https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Bug ID: 1164176 Summary: Review Request: golang-github-vishvananda-netlink - Simple netlink library for go Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jchaloup@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-vishvananda-netlink/...
SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-vishvananda-netlink/...
Description: The netlink package provides a simple netlink library for go. Netlink is the interface a user-space program in linux uses to communicate with the kernel. It can be used to add and remove interfaces, set ip addresses and routes, and configure ipsec. Netlink communication requires elevated privileges, so in most cases this code needs to be run as root. Since low-level netlink messages are inscrutable at best, the library attempts to provide an api that is loosely modeled on the CLI provied by iproute2. Actions like ip link add will be accomplished via a similarly named function like AddLink(). This library began its life as a fork of the netlink functionality in docker/libcontainer but was heavily rewritten to improve testability,performance, and to add new functionality like ipsec xfrm handling.
Fedora Account System Username: jchaloup
Koji: Depends on golang-github-vishvananda-netns, which is not in Fedora yet. Review https://bugzilla.redhat.com/show_bug.cgi?id=1164170. Locally building succesfully.
$ rpmlint golang-github-vishvananda-netlink-0-0.1.git2187ba6.fc20.src.rpm golang-github-vishvananda-netlink-devel-0-0.1.git2187ba6.fc20.noarch.rpm golang-github-vishvananda-netlink.spec golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US linux -> Linux golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US ip -> pi, up, op golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US ipsec -> eclipse golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US api -> pi, ape, apt golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US provied -> provide, proved, provided golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US libcontainer -> lib container, lib-container, containerize golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US testability -> test ability, test-ability, incontestability golang-github-vishvananda-netlink.src: W: spelling-error %description -l en_US xfrm -> farm 2 packages and 1 specfiles checked; 0 errors, 8 warnings.
Upstream URL: https://github.com/vishvananda/netlink
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1164170
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1164170 [Bug 1164170] Review Request: golang-github-vishvananda-netns - Simple network namespace handling for go
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lsm5@redhat.com Assignee|nobody@fedoraproject.org |lsm5@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1165688
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1165688 [Bug 1165688] Review Request: flannel - Flannel is an etcd backed network fabric for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
--- Comment #1 from Lokesh Mandvekar lsm5@redhat.com --- Change %files as in Bug 1164170
rest looks good
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Lokesh Mandvekar lsm5@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #2 from Lokesh Mandvekar lsm5@redhat.com --- %files looks good in original spec. Package approved! specfile conforms to golang packaging guidelines.
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Jan Chaloupka jchaloup@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #3 from Jan Chaloupka jchaloup@redhat.com --- New Package SCM Request ======================= Package Name: golang-github-vishvananda-netlink Short Description: Simple netlink library for go Upstream URL: https://github.com/vishvananda/netlink Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- golang-github-vishvananda-netlink-0-0.1.git2187ba6.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-vishvananda-netlink-0-...
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- golang-github-vishvananda-netlink-0-0.1.git2187ba6.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-vishvananda-netlink-0-...
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- golang-github-vishvananda-netlink-0-0.1.git2187ba6.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-vishvananda-netlink-0-...
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- golang-github-vishvananda-netlink-0-0.1.git2187ba6.el6 has been pushed to the Fedora EPEL 6 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |golang-github-vishvananda-n | |etlink-0-0.1.git2187ba6.fc2 | |0 Resolution|--- |ERRATA Last Closed| |2014-12-02 20:02:41
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- golang-github-vishvananda-netlink-0-0.1.git2187ba6.fc20 has been pushed to the Fedora 20 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1164176 Bug 1164176 depends on bug 1164170, which changed state.
Bug 1164170 Summary: Review Request: golang-github-vishvananda-netns - Simple network namespace handling for go https://bugzilla.redhat.com/show_bug.cgi?id=1164170
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|golang-github-vishvananda-n |golang-github-vishvananda-n |etlink-0-0.1.git2187ba6.fc2 |etlink-0-0.1.git2187ba6.fc2 |0 |1
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- golang-github-vishvananda-netlink-0-0.1.git2187ba6.fc21 has been pushed to the Fedora 21 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|golang-github-vishvananda-n |golang-github-vishvananda-n |etlink-0-0.1.git2187ba6.fc2 |etlink-0-0.1.git2187ba6.el6 |1 |
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- golang-github-vishvananda-netlink-0-0.1.git2187ba6.el6 has been pushed to the Fedora EPEL 6 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- golang-github-vishvananda-netlink-0-0.2.git991a7a2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/golang-github-vishvananda-netlink-0-...
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- golang-github-vishvananda-netlink-0-0.2.git991a7a2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-vishvananda-netlink-0-...
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- golang-github-vishvananda-netlink-0-0.2.git991a7a2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-vishvananda-netlink-0-...
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- golang-github-vishvananda-netlink-0-0.2.git991a7a2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-vishvananda-netlink-0-...
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|golang-github-vishvananda-n |golang-github-vishvananda-n |etlink-0-0.1.git2187ba6.el6 |etlink-0-0.2.git991a7a2.fc2 | |1
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- golang-github-vishvananda-netlink-0-0.2.git991a7a2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|golang-github-vishvananda-n |golang-github-vishvananda-n |etlink-0-0.2.git991a7a2.fc2 |etlink-0-0.2.git991a7a2.fc2 |1 |2
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- golang-github-vishvananda-netlink-0-0.2.git991a7a2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|golang-github-vishvananda-n |golang-github-vishvananda-n |etlink-0-0.2.git991a7a2.fc2 |etlink-0-0.2.git991a7a2.fc2 |2 |0
--- Comment #18 from Fedora Update System updates@fedoraproject.org --- golang-github-vishvananda-netlink-0-0.2.git991a7a2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1164176
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|golang-github-vishvananda-n |golang-github-vishvananda-n |etlink-0-0.2.git991a7a2.fc2 |etlink-0-0.2.git991a7a2.el6 |0 |
--- Comment #19 from Fedora Update System updates@fedoraproject.org --- golang-github-vishvananda-netlink-0-0.2.git991a7a2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org