[Bug 597967] New: Review Request: emacs-ibus - IBus client for GNU Emacs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: emacs-ibus - IBus client for GNU Emacs

https://bugzilla.redhat.com/show_bug.cgi?id=597967

Summary: Review Request: emacs-ibus - IBus client for GNU Emacs
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---

Spec URL: http://ueno.fedorapeople.org/emacs-ibus/emacs-ibus.spec
SRPM URL:
http://ueno.fedorapeople.org/emacs-ibus/emacs-ibus-0.1.0-1.fc13.src.rpm
Description:
ibus.el is a IBus client for GNU Emacs. This program allows users
on-the-spot style input with IBus. The input statuses are individually
kept for each buffer, and prefix-keys such as C-x and C-c can be used
even if IBus is active. So you can input various languages fast and
comfortably by using it.

[Bug 597967] Review Request: emacs-ibus - IBus client for GNU Emacs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=597967

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

[Bug 597967] Review Request: emacs-ibus - IBus client for GNU Emacs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=597967

--- Comment #1 from Parag AN(पराग)  2010-06-01 02:15:19 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2221510
+ rpmlint output for SRPM and for RPM.
emacs-ibus.src: W: spelling-error %description -l en_US el -> e, l, eel
emacs-ibus.noarch: E: explicit-lib-dependency python-xlib
emacs-ibus.noarch: W: spelling-error %description -l en_US el -> e, l, eel
emacs-ibus-el.noarch: W: spelling-error Summary(en_US) Elisp -> Lisp, Elise,
Elisa
emacs-ibus-el.noarch: W: spelling-error %description -l en_US elisp -> lisp, e
lisp, Elise
emacs-ibus-el.noarch: W: no-documentation
==> All are ok to be ignored.

+ source files match upstream url (sha1sum)
c066f17640d51b91d39bffbc991f946a73469499  ibus-el-0.1.0.tar.gz
c066f17640d51b91d39bffbc991f946a73469499  ibus-el-0.1.0.tar.gz.srpm
( I see that when tried to download using wget, I get 2010-06-01 11:33:52 ERROR
403: Forbidden. Not sure why its happening but I can download it using browser)

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ emacs-ibus-el subpackage exists.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application
+ Other than requires on emacs missing, this package follows emacs addon
packaging guidelines.

Suggestions:
1) As per
https://fedoraproject.org/wiki/Packaging:Emacs#Package_Requires_and_BuildReq...,
emacs-ibus must have

Requires: emacs(bin) >= %{_emacs_version}

2) Good if timestamps are preserved as per
http://fedoraproject.org/wiki/PackagingGuidelines#Timestamps

APPROVED.

[Bug 597967] Review Request: emacs-ibus - IBus client for GNU Emacs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=597967

Parag AN(पराग)  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

[Bug 597967] Review Request: emacs-ibus - IBus client for GNU Emacs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=597967

--- Comment #2 from Parag AN(पराग)  2010-06-01 02:22:23 EDT ---
Also if you are planning only to build for F-13 and above you can ignore
writing buildroot and %clean sections.

See http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag and
http://fedoraproject.org/wiki/PackagingGuidelines#.25clean

[Bug 597967] Review Request: emacs-ibus - IBus client for GNU Emacs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=597967

Daiki Ueno  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #3 from Daiki Ueno  2010-06-01 04:18:49 EDT ---
Thanks for the review.

New Package CVS Request
=======================
Package Name: emacs-ibus
Short Description: IBus client for GNU Emacs
Owners: ueno
Branches: F-13 F-12
InitialCC: i18n-team

[Bug 597967] Review Request: emacs-ibus - IBus client for GNU Emacs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=597967

--- Comment #4 from Kevin Fenzi  2010-06-03 16:32:14 EDT ---
CVS done (by process-cvs-requests.py).

[Bug 597967] Review Request: emacs-ibus - IBus client for GNU Emacs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=597967

--- Comment #5 from Fedora Update System  2010-06-04 00:00:45 EDT ---
emacs-ibus-0.1.0-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/emacs-ibus-0.1.0-2.fc13

[Bug 597967] Review Request: emacs-ibus - IBus client for GNU Emacs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=597967

--- Comment #6 from Fedora Update System  2010-06-04 00:01:56 EDT ---
emacs-ibus-0.1.0-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/emacs-ibus-0.1.0-2.fc12

[Bug 597967] Review Request: emacs-ibus - IBus client for GNU Emacs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=597967

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |ON_QA

--- Comment #7 from Fedora Update System  2010-06-04 14:54:44 EDT ---
emacs-ibus-0.1.0-2.fc12 has been pushed to the Fedora 12 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update emacs-ibus'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/emacs-ibus-0.1.0-2.fc12

[Bug 597967] Review Request: emacs-ibus - IBus client for GNU Emacs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=597967

--- Comment #8 from Fedora Update System  2010-06-04 14:58:40 EDT ---
emacs-ibus-0.1.0-2.fc13 has been pushed to the Fedora 13 testing repository. 
If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update emacs-ibus'.  You can provide
feedback for this update here:
http://admin.fedoraproject.org/updates/emacs-ibus-0.1.0-2.fc13

[Bug 597967] Review Request: emacs-ibus - IBus client for GNU Emacs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=597967

--- Comment #9 from Fedora Update System  2010-06-14 13:16:42 EDT ---
emacs-ibus-0.1.0-2.fc12 has been pushed to the Fedora 12 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 597967] Review Request: emacs-ibus - IBus client for GNU Emacs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=597967

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ON_QA                       |CLOSED
   Fixed In Version|                            |emacs-ibus-0.1.0-2.fc12
         Resolution|                            |ERRATA

[Bug 597967] Review Request: emacs-ibus - IBus client for GNU Emacs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=597967

--- Comment #10 from Fedora Update System  2010-06-14 13:29:29 EDT ---
emacs-ibus-0.1.0-2.fc13 has been pushed to the Fedora 13 stable repository.  If
problems still persist, please make note of it in this bug report.

[Bug 597967] Review Request: emacs-ibus - IBus client for GNU Emacs

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=597967

Fedora Update System  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Fixed In Version|emacs-ibus-0.1.0-2.fc12     |emacs-ibus-0.1.0-2.fc13