https://bugzilla.redhat.com/show_bug.cgi?id=2035548
Bug ID: 2035548 Summary: Review Request: rust-deser-hjson - Hjson deserializer for Serde Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: dcavalca@fb.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://dcavalca.fedorapeople.org/review/rust-deser-hjson/rust-deser-hjson.s... SRPM URL: https://dcavalca.fedorapeople.org/review/rust-deser-hjson/rust-deser-hjson-1...
Description: Hjson deserializer for Serde.
Fedora Account System Username: dcavalca
https://bugzilla.redhat.com/show_bug.cgi?id=2035548
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |2035547
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2035547 [Bug 2035547] Review Request: rust-glassbench - Rust benchmark with memory
https://bugzilla.redhat.com/show_bug.cgi?id=2035548
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2035568
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2035568 [Bug 2035568] Review Request: rust-broot - New file manager
https://bugzilla.redhat.com/show_bug.cgi?id=2035548
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@gmail.com Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review?
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- Taking on this review.
===
Are you sure you need glassbench for this package?
It seems to be a benchmark-only dependency. And since we neither build nor run benchmarks in Fedora RPM builds, you should be able to drop the glassbench dev-dependency from Cargo.toml entirely.
https://bugzilla.redhat.com/show_bug.cgi?id=2035548
--- Comment #2 from Davide Cavalca dcavalca@fb.com --- You're right, it doesn't seem to be needed for this to build and the tests to pass.
Spec URL: https://dcavalca.fedorapeople.org/review/rust-deser-hjson/rust-deser-hjson.s... SRPM URL: https://dcavalca.fedorapeople.org/review/rust-deser-hjson/rust-deser-hjson-1...
Changelog: - re-run rust2rpm - drop benchmark-only dependency
https://bugzilla.redhat.com/show_bug.cgi?id=2035548
Davide Cavalca dcavalca@fb.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|2035547 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2035547 [Bug 2035547] Review Request: rust-glassbench - Rust benchmark with memory
https://bugzilla.redhat.com/show_bug.cgi?id=2035548
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Ooops, I'm sorry for the long delay here. This review seems to have slipped through multiple cracks ...
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
===
Please regenerate the packaging with rust2rpm v22 before importing it into dist-git.
https://bugzilla.redhat.com/show_bug.cgi?id=2035548
--- Comment #4 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-deser-hjson
https://bugzilla.redhat.com/show_bug.cgi?id=2035548
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-e268aea46b has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e268aea46b
https://bugzilla.redhat.com/show_bug.cgi?id=2035548
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |ERRATA Last Closed| |2022-10-26 03:08:10
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-e268aea46b has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2035548
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-118e693b09 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-118e693b09
https://bugzilla.redhat.com/show_bug.cgi?id=2035548
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-118e693b09 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-118e693b09 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-118e693b09
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2035548
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2022-118e693b09 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org