[Bug 538465] New: Review Request: libmx - A clutter toolkit for Moblin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: libmx - A clutter toolkit for Moblin

https://bugzilla.redhat.com/show_bug.cgi?id=538465

Summary: Review Request: libmx - A clutter toolkit for Moblin
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora

SPEC: http://pbrobinson.fedorapeople.org/libmx.spec
SRPM: http://pbrobinson.fedorapeople.org/libmx-0.1.1-1.fc12.src.rpm

%description
The Moblin User Experience is a GUI toolkit, using Clutter and 
is optimised for Moblin. It consists of various classes useful 
for building UIs such as Buttons, Tooltips, Scrollbars and 
others. It also supports styling through CSS stylesheets.

NOTE: the upstream name for this package is mx but there is a conflicting
python package called mx already.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1814556

[Bug 538465] Review Request: libmx - A clutter toolkit for Moblin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

Peter Robinson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |538447(MoblinFuture)

[Bug 538465] Review Request: libmx - A clutter toolkit for Moblin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

--- Comment #1 from Peter Robinson   2009-11-19 07:21:23 EDT ---
New upstream
SRPM: http://pbrobinson.fedorapeople.org/libmx-0.1.2-1.fc12.src.rpm

[Bug 538465] Review Request: libmx - A clutter toolkit for Moblin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

--- Comment #2 from Peter Robinson   2009-12-01 22:43:55 EDT ---
New upstream
SRPM: http://pbrobinson.fedorapeople.org/libmx-0.2.0-1.fc12.src.rpm

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1842627

[Bug 538465] Review Request: libmx - A clutter toolkit for Moblin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

--- Comment #3 from Peter Robinson   2009-12-11 13:04:08 EDT ---
New upstream 0.3.0 release.
SRPM: http://pbrobinson.fedorapeople.org/libmx-0.3.0-1.fc12.src.rpm
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1870119

[Bug 538465] Review Request: libmx - A clutter toolkit for Moblin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

--- Comment #4 from Bill Nottingham   2009-12-17 12:37:56 EDT ---
Given the existence of the mx/mx-devel packages, a little more description in
the -devel packages might help

[Bug 538465] Review Request: libmx - A clutter toolkit for Moblin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

Till Maas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Till Maas   2009-12-17 12:42:48 EDT ---
There is also another project called mx/libmx which seems to be older and still
be maintained: http://www.lostsidedead.com/mx/

I suggest to use moblin-mx to avoid potential future conflicts, but this might
be worth discussion on fedora-devel.

[Bug 538465] Review Request: libmx - A clutter toolkit for Moblin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

Orcan 'oget' Ogetbil  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Orcan 'oget' Ogetbil   2009-12-17 13:29:18 EDT ---
just had a quick look:
* I think that %{_datadir}/gtk-doc/html/mx needs to be tagged with %doc. 
* Also please span the description to 80 columns as much as possible. 
* Source0 seems wrong.

[Bug 538465] Review Request: libmx - A clutter toolkit for Moblin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

--- Comment #7 from Peter Robinson   2010-01-04 13:43:36 EDT ---
(In reply to comment #4)
> Given the existence of the mx/mx-devel packages, a little more description in
> the -devel packages might help

I'm going to shortly improve all the descriptions. It looks like the
gnome-shell people are going to be making use of this so I want to remove all
mention of Moblin in the description as it looks like its going to be used in
gnome-shell (this library will replace nbtk for Moblin 2.2) and gnome-shell
pulls in a chunk of nbtk.

[Bug 538465] Review Request: libmx - A clutter toolkit for Moblin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

--- Comment #8 from Peter Robinson   2010-01-04 13:46:34 EDT ---
> just had a quick look:
> I think that %{_datadir}/gtk-doc/html/mx needs to be tagged with %doc.

I have been told that gtk-doc will automatically get tagged as docs due to the
%{_datadir}/gtk-doc dir being tagged as %doc.
> Also please span the description to 80 columns as much as possible.

Will update when I update the description
> Source0 seems wrong.

In the rush I didn't update the URL. Will fix.

[Bug 538465] Review Request: libmx - A clutter toolkit for Moblin

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

--- Comment #9 from Peter Robinson   2010-01-04 18:42:08 EDT ---
Updated.
SPEC: http://pbrobinson.fedorapeople.org/libmx.spec
SRPM: http://pbrobinson.fedorapeople.org/libmx-0.3.0-2.fc12.src.rpm

[Bug 538465] Review Request: libmx - A clutter widget toolkit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

Peter Robinson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: libmx - A   |Review Request: libmx - A
                   |clutter toolkit for Moblin  |clutter widget toolkit

[Bug 538465] Review Request: libmx - A clutter widget toolkit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

Sebastian Dziallas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
               Flag|                            |fedora-review?

--- Comment #10 from Sebastian Dziallas   2010-01-05 08:27:03 EDT ---
I'm going to take a look at this one.

[Bug 538465] Review Request: libmx - A clutter widget toolkit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

Sebastian Dziallas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #11 from Sebastian Dziallas   2010-01-05 08:38:21 EDT ---
[  OK  ] specfiles match: 5b84e5e23a3ed18216bb0c4e8d8961db
[  OK  ] source files match upstream: 916694e534ae745d3a809c4634b6696f
[  OK  ] package meets naming and versioning guidelines.
[  OK  ] spec is properly named, cleanly written, and uses macros consistently.
[  OK  ] dist tag is present.
[  OK  ] build root is correct.
[  OK  ] license field matches the actual license.
[  OK  ] license is open source-compatible.
[  OK  ] license text included in package.
[  OK  ] latest version is being packaged.
[  OK  ] BuildRequires are proper.
[  OK  ] compiler flags are appropriate.
[  OK  ] %clean is present.
[  OK  ] package builds in mock:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1902982
[  OK  ] package installs properly.
[  OK  ] debuginfo package looks complete.
[  OK  ] rpmlint is silent: libmx-devel.i686: W: no-documentation
[  OK  ] final provides and requires are sane
[  NA  ] %check is present and all tests pass
[  OK  ] no shared libraries are added to the regular linker search paths.
[  NA  ] owns the directories it creates. 
[  OK  ] doesn't own any directories it shouldn't.
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[  NA  ] scriptlets match those on ScriptletSnippets page.
[  OK  ] code, not content.
[  OK  ] docs subpackage is appropriately created
[  OK  ] %docs are not necessary for the proper functioning of the package.
[  OK  ] headers go into devel package.
[  OK  ] pkgconfig files are in devel package.
[  OK  ] no libtool .la droppings.
[  NA  ] desktop files valid and installed properly.

Looks like you're good to go here. The rpmlint warning is a non-issue, since
the devel package pulls the main package in anyway. So this is APPROVED.

[Bug 538465] Review Request: libmx - A clutter widget toolkit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

Peter Robinson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-cvs?

--- Comment #12 from Peter Robinson   2010-01-05 08:53:53 EDT ---
New Package CVS Request
=======================
Package Name: libmx
Short Description: A clutter widget toolkit
Owners: pbrobinson
Branches: F-12
InitialCC:

[Bug 538465] Review Request: libmx - A clutter widget toolkit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #13 from Kevin Fenzi   2010-01-06 16:40:50 EDT ---
cvs done.

[Bug 538465] Review Request: libmx - A clutter widget toolkit

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=538465

Peter Robinson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

--- Comment #14 from Peter Robinson   2010-01-06 18:12:11 EDT ---
Built and in rawhide. Thanks for the review and feedback!