[Bug 2158464] New: Review Request: perl-Syntax-Operator-In - Infix element-of-list meta-operator
https://bugzilla.redhat.com/show_bug.cgi?id=2158464
Bug ID: 2158464 Summary: Review Request: perl-Syntax-Operator-In - Infix element-of-list meta-operator Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ppisar@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://ppisar.fedorapeople.org/perl-Syntax-Operator-In/perl-Syntax-Operator... SRPM URL: https://ppisar.fedorapeople.org/perl-Syntax-Operator-In/perl-Syntax-Operator... Description: This Perl module provides an infix meta-operator that implements an element-of-list test on either strings or numbers.
Fedora Account System Username: ppisar
https://bugzilla.redhat.com/show_bug.cgi?id=2158464
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Copr build: https://copr.fedorainfracloud.org/coprs/build/5201882 (failed)
Build log: https://download.copr.fedorainfracloud.org/results/frostyx/fedora-review-215...
Please make sure the package builds successfully at least for Fedora Rawhide.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
https://bugzilla.redhat.com/show_bug.cgi?id=2158464
--- Comment #2 from Petr Pisar ppisar@redhat.com --- Why do you think this package does not build in Rawhide? That log shows an error in HTTPS transfer:
Retry request #1 on https://ppisar.fedorapeople.org/perl-Syntax-Operator-In/perl-Syntax-Operator...: Requests error on https://ppisar.fedorapeople.org/perl-Syntax-Operator-In/perl-Syntax-Operator...: HTTPSConnectionPool(host='ppisar.fedorapeople.org', port=443): Max retries exceeded with url: /perl-Syntax-Operator-In/perl-Syntax-Operator-In-0.04-1.fc38.src.rpm (Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: certificate has expired (_ssl.c:992)')))
https://bugzilla.redhat.com/show_bug.cgi?id=2158464
--- Comment #3 from Petr Pisar ppisar@redhat.com --- (In reply to Petr Pisar from comment #2)
That log shows an error in HTTPS transfer:
https://pagure.io/fedora-infrastructure/issue/11073
https://bugzilla.redhat.com/show_bug.cgi?id=2158464
--- Comment #4 from Petr Pisar ppisar@redhat.com --- In the mean time, you get the package from ssh://fedorapeople.org:/home/fedora/ppisar/public_html/perl-Syntax-Operator-In directory.
https://bugzilla.redhat.com/show_bug.cgi?id=2158464
--- Comment #5 from Petr Pisar ppisar@redhat.com --- The certificate was fixed, the URLs are safe now.
https://bugzilla.redhat.com/show_bug.cgi?id=2158464
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |jplesnik@redhat.com CC| |jplesnik@redhat.com Flags| |needinfo?
https://bugzilla.redhat.com/show_bug.cgi?id=2158464
Jitka Plesnikova jplesnik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo? |fedora-review+
--- Comment #6 from Jitka Plesnikova jplesnik@redhat.com --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok
$ rpm -qp --requires perl-Syntax-Operator-In-0.04-1.fc38.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 ld-linux-x86-64.so.2()(64bit) 1 ld-linux-x86-64.so.2(GLIBC_2.3)(64bit) 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 perl(Carp) 1 perl-libs 2 perl(:MODULE_COMPAT_5.36.0) 1 perl(:VERSION) >= 5.14.0 1 perl(warnings) 1 perl(XSLoader) 1 perl(XS::Parse::Infix) >= 0.27 1 perl(:XS_Parse_Infix_ABI_2) 1 rtld(GNU_HASH) Binary requires are Ok.
$ rpm -qp --provides perl-Syntax-Operator-In-0.04-1.fc38.x86_64.rpm | sort | uniq -c 1 perl(Syntax::Operator::Elem) = 0.04 1 perl(Syntax::Operator::In) = 0.04 1 perl-Syntax-Operator-In = 0.04-1.fc38 1 perl-Syntax-Operator-In(x86-64) = 0.04-1.fc38 Binary provides are Ok.
Rpmlint is ok
TODO: Please consider using only one style of defining the rpm Build Root. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_using_buildroot_...
FIX: Add missing 'done' to 'for' on line 73.
Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' item.
Resolution: Approved
https://bugzilla.redhat.com/show_bug.cgi?id=2158464
--- Comment #7 from Tomas Hrcka thrcka@redhat.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Syntax-Operator-In
https://bugzilla.redhat.com/show_bug.cgi?id=2158464
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |perl-Syntax-Operator-In-0.0 | |4-2.fc38 Status|ASSIGNED |MODIFIED
--- Comment #8 from Petr Pisar ppisar@redhat.com --- Thank you for the review and the repository.
https://bugzilla.redhat.com/show_bug.cgi?id=2158464
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=2158464
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |RAWHIDE Status|ON_QA |CLOSED Last Closed| |2023-01-10 12:08:16
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com