[Bug 438445] New: Review Request: python-cjson - Fast JSON encoder/decoder for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=438445

Summary: Review Request: python-cjson - Fast JSON encoder/decoder
                    for Python
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://toshio.fedorapeople.org/packages/python-cjson.spec
SRPM URL: http://toshio.fedorapeople.org/packages/python-cjson-1.0.5-1.fc8.src.rpm
Description:
JSON stands for JavaScript Object Notation and is a text based lightweight
data exchange format which is easy for humans to read/write and for machines
to parse/generate. JSON is completely language independent and has multiple
implementations in most of the programming languages, making it ideal for
data exchange and storage.

The module is written in C and it is up to 250 times faster when compared to
the other python JSON implementations which are written directly in python.
This speed gain varies with the complexity of the data and the operation and
is the the range of 10-200 times for encoding operations and in the range of
100-250 times for decoding operations.

[Bug 438445] Review Request: python-cjson - Fast JSON encoder/decoder for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-cjson - Fast JSON encoder/decoder for Python

https://bugzilla.redhat.com/show_bug.cgi?id=438445

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

[Bug 438445] Review Request: python-cjson - Fast JSON encoder/decoder for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-cjson - Fast JSON encoder/decoder for Python

https://bugzilla.redhat.com/show_bug.cgi?id=438445

------- Additional Comments From [e-mail]  2008-03-25 05:42 EST -------
rpmlint silent on rpm & srpm

[Bug 438445] Review Request: python-cjson - Fast JSON encoder/decoder for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-cjson - Fast JSON encoder/decoder for Python

https://bugzilla.redhat.com/show_bug.cgi?id=438445

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2008-03-25 05:54 EST -------
MUST:
* package is named appropriately
* it is legal for Fedora to distribute this
* license field matches the actual license.
* license is open source-compatible.
* specfile name matches %{name}
* verify source and patches (md5sum matches upstream, know what the patches do)
4d55b66ecdf0300313af9d030d9644a3 python-cjson-1.0.5.tar.gz
* summary and description fine
* correct buildroot
* %{?dist} is used
* license text included in package and marked with %doc
* package meets FHS (http://www.pathname.com/fhs/)
* changelog format fine 
* Packager tag not used
* Vendor tag not used
* Distribution tag not used
* License used and not Copyright 
* Summary tag does not end in a period
* specfile is legible
* package successfully compiles and builds on at least x86_64
* BuildRequires are proper
* make sure lines are <= 80 characters
* specfile written in American English
* no -doc sub-package necessary
* no libraries
* no rpath
* no config files
* not a GUI app
* no -devel sub-package necessary
* macros used appropriately and consistently
* no %makeinstall
* install section must begin with rm -rf $RPM_BUILD_ROOT or %{buildroot}
* no locale data
* split Requires(pre,post) into two separate lines
* package not relocatable
* package contains code
* package owns all directories and files
* no %files duplicates
* file permissions fine
* %defattrs present ( %defattr(-, root, root, -))
* %clean present
* %doc files do not affect runtime

APPROVED

[Bug 438445] Review Request: python-cjson - Fast JSON encoder/decoder for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-cjson - Fast JSON encoder/decoder for Python

https://bugzilla.redhat.com/show_bug.cgi?id=438445

------- Additional Comments From [e-mail]  2008-03-25 05:58 EST -------
UPS, missed something

BuildRequires:  python-setuptools-devel

should be added.

[Bug 438445] Review Request: python-cjson - Fast JSON encoder/decoder for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-cjson - Fast JSON encoder/decoder for Python

https://bugzilla.redhat.com/show_bug.cgi?id=438445

------- Additional Comments From [e-mail]  2008-03-25 12:15 EST -------
(In reply to comment #3)
> UPS, missed something
>
> BuildRequires:  python-setuptools-devel
>
> should be added.

This package only uses distutils in its setup.py, not setuptools.  Why is
setuptools-devel a necessary BuildRequires?

[Bug 438445] Review Request: python-cjson - Fast JSON encoder/decoder for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-cjson - Fast JSON encoder/decoder for Python

https://bugzilla.redhat.com/show_bug.cgi?id=438445

------- Additional Comments From [e-mail]  2008-03-25 12:30 EST -------
My mistake, please ignore it.

[Bug 438445] Review Request: python-cjson - Fast JSON encoder/decoder for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-cjson - Fast JSON encoder/decoder for Python

https://bugzilla.redhat.com/show_bug.cgi?id=438445

------- Additional Comments From [e-mail]  2008-04-06 01:58 EST -------
New Package CVS Request
=======================
Package Name: python-cjson
Short Description: Fast JSON encoder/decoder for Python
Owners: toshio
Branches: F-8 EL-5 devel
InitialCC: 
Cvsextras Commits: yes

[Bug 438445] Review Request: python-cjson - Fast JSON encoder/decoder for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-cjson - Fast JSON encoder/decoder for Python

https://bugzilla.redhat.com/show_bug.cgi?id=438445

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

[Bug 438445] Review Request: python-cjson - Fast JSON encoder/decoder for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-cjson - Fast JSON encoder/decoder for Python

https://bugzilla.redhat.com/show_bug.cgi?id=438445

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-04-07 18:09 EST -------
cvs done.

[Bug 438445] Review Request: python-cjson - Fast JSON encoder/decoder for Python

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-cjson - Fast JSON encoder/decoder for Python

https://bugzilla.redhat.com/show_bug.cgi?id=438445

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

------- Additional Comments From [e-mail]  2008-04-07 20:41 EST -------
Packages committed and built.