[Bug 442854] New: Review Request: psiconv : A conversion utility for Psion files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=442854

Summary: Review Request: psiconv : A conversion utility for Psion
                    files
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://huzaifas.fedorapeople.org/spec/psiconv.spec
SRPM URL: http://huzaifas.fedorapeople.org/srpms/psiconv-0.9.8-0.fc8.src.rpm
Description: A conversion utility for Psion files.

Builds:
devel: http://koji.fedoraproject.org/koji/taskinfo?taskID=570268
f8: http://koji.fedoraproject.org/koji/taskinfo?taskID=570268

[Bug 442854] Review Request: psiconv : A conversion utility for Psion files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: psiconv : A conversion utility for Psion files

https://bugzilla.redhat.com/show_bug.cgi?id=442854

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2008-04-17 04:48 EST -------
Doing a full review.

[Bug 442854] Review Request: psiconv : A conversion utility for Psion files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: psiconv : A conversion utility for Psion files

https://bugzilla.redhat.com/show_bug.cgi?id=442854

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug 442854] Review Request: psiconv : A conversion utility for Psion files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: psiconv : A conversion utility for Psion files

https://bugzilla.redhat.com/show_bug.cgi?id=442854

------- Additional Comments From [e-mail]  2008-04-17 05:23 EST -------
Full review done:

MUST FIX:
---------
-Missing BuildRequires: ImageMagick-devel bc
-The man page for psiconv-config should be in -devel
-The doc files under /usr/share/psiconv should be moved to %doc of
 -devel, iow do this after make install:
 mv $RPM_BUILD_ROOT%{_datadir}/%{name} _doc
 And then add: " %doc _doc/*" to %files of -devel
-License should be GPLv2+ not GPLv2 as far as I can see, any particular reason
 you've used GPLv2?

[Bug 442854] Review Request: psiconv : A conversion utility for Psion files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: psiconv : A conversion utility for Psion files

https://bugzilla.redhat.com/show_bug.cgi?id=442854

------- Additional Comments From [e-mail]  2008-04-17 06:34 EST -------
(In reply to comment #2)
> Full review done:
> MUST FIX:
>
> -Missing BuildRequires: ImageMagick-devel bc

done
> -The man page for psiconv-config should be in -devel

done
> -The doc files under /usr/share/psiconv should be moved to %doc of
>  -devel, iow do this after make install:
>  mv $RPM_BUILD_ROOT%{_datadir}/%{name} _doc
>  And then add: " %doc _doc/*" to %files of -devel

done
> -License should be GPLv2+ not GPLv2 as far as I can see, any particular reason
>  you've used GPLv2?

done

SPEC: http://huzaifas.fedorapeople.org/spec/psiconv.spec
SRPM: http://huzaifas.fedorapeople.org/srpms/psiconv-0.9.8-1.fc8.src.rpm

[Bug 442854] Review Request: psiconv : A conversion utility for Psion files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: psiconv : A conversion utility for Psion files

https://bugzilla.redhat.com/show_bug.cgi?id=442854

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2008-04-17 07:25 EST -------
All good now, approved!

[Bug 442854] Review Request: psiconv : A conversion utility for Psion files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: psiconv : A conversion utility for Psion files

https://bugzilla.redhat.com/show_bug.cgi?id=442854

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-04-17 07:31 EST -------
New Package CVS Request
=======================
Package Name: psiconv
Short Description: A conversion utility for Psion files.
Owners: huzaifas
Branches:  F-8, EL-5
InitialCC: huzaifas
Cvsextras Commits: yes

[Bug 442854] Review Request: psiconv : A conversion utility for Psion files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: psiconv : A conversion utility for Psion files

https://bugzilla.redhat.com/show_bug.cgi?id=442854

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-04-17 12:56 EST -------
cvs done.

[Bug 442854] Review Request: psiconv : A conversion utility for Psion files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: psiconv : A conversion utility for Psion files

https://bugzilla.redhat.com/show_bug.cgi?id=442854

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

------- Additional Comments From [e-mail]  2008-06-01 04:34 EST -------
Closing as this is in the repo now (atleast for rawhide).