Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247406
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1 Product: Fedora Version: devel Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: mohd.izhar.firdaus@gmail.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://devel.foss.org.my/~kagesenshi/repo/private/testing/SPEC/libcompizconf... SRPM URL: http://devel.foss.org.my/~kagesenshi/repo/private/testing/libcompizconfig/li... Description: The Compiz Project brings 3D desktop visual effects that improve usability of the X Window System and provide increased productivity through plugins and themes contributed by the community giving a rich desktop experience.
This package contains the library for plugins to configure compiz settings.
----- BuildReq: compiz-bcop https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247405
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247406
lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |247408 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247406
lxtnow@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |lxtnow@gmail.com BugsThisDependsOn| |247405 OtherBugsDependingO|247408 | nThis| |
------- Additional Comments From lxtnow@gmail.com 2007-07-09 17:08 EST ------- Added block dependency
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247406
s.adam@diffingo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |s.adam@diffingo.com Flag| |fedora-review?
------- Additional Comments From s.adam@diffingo.com 2007-07-09 18:34 EST ------- - A trival rpmlint warning: W: libcompizconfig summary-not-capitalized libcompizconfig
- Rebuilding libcompizconfig-0.0.1-0.5.20070708git.fc7.src.rpm returns: error: Failed build dependencies: compiz-devel >= 0.5.1 is needed by libcompizconfig-0.0.1-0.5.20070708git.fc7.i386
I can't continue to review this until compiz >= 0.5.1 had been reviewed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247406
mohd.izhar.firdaus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |247409
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247406
mohd.izhar.firdaus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |247408 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247406
Bug 247406 depends on bug 247409, which changed state.
Bug 247409 Summary: [RFE] Compiz 0.5.1 and a rewrite of DesktopEffects to make use of compizconfig-python https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247409
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |RAWHIDE Status|NEW |CLOSED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
Bug 247406 depends on bug 247405, which changed state.
Bug 247405 Summary: Review Request: compiz-bcop - Compiz option code generator https://bugzilla.redhat.com/show_bug.cgi?id=247405
What |Old Value |New Value ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |RAWHIDE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
michel.sylvan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |michel.sylvan@gmail.com
------- Additional Comments From michel.sylvan@gmail.com 2007-10-05 10:02 EST ------- The development tree now has compiz 0.5.2. Stewart, do you still want to do the review? Otherwise, I can take it.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From s.adam@diffingo.com 2007-10-05 18:03 EST ------- If you don't mind I'll take it :)
I got a 404 error with the SRPM above, I'll use this instead: http://devel.foss.org.my/~kagesenshi/repo/private/testing/libcompizconfig/li... Let me know if I should be using another SRPM.
+ source files match upstream + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. - license field matches the actual license. "GPL" is no longer a vlid license. Please specify the version - See http://fedoraproject.org/wiki/Licensing for more info. + license is open source-compatible, GPL License text included in package. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package installs properly + debuginfo package looks complete. + rpmlint is silent. It isn't "silent", but the errors can be ignored. + no shared libraries are added to the regular linker search paths. - owns the directories it creates. It should own %{_datadir}/compizconfig and %{_libdir}/compizconfig + doesn't own any directories it shouldn't. + no duplicates in %files. + documentation is small, so no -docs subpackage is necessary. + headers, pkgconfig files are in -devel package + no .la files
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From mohd.izhar.firdaus@gmail.com 2007-10-05 21:50 EST ------- Thanks for resuming this review
I have changed the license tag and added created directories into %files
SPEC: http://izhar.fedorapeople.org/libcompizconfig/libcompizconfig.spec SRPM: http://izhar.fedorapeople.org/libcompizconfig/libcompizconfig-0.5.2-0.3.fc8....
btw .. I forgot to mention that i need a sponsor as this is my first package in Fedora repository ..
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
s.adam@diffingo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |s.adam@diffingo.com AssignedTo|s.adam@diffingo.com |nobody@fedoraproject.org
------- Additional Comments From s.adam@diffingo.com 2007-10-06 00:17 EST ------- Well the package itself is ready to be imported, but I can't to sponsor you - I've unassigned the bug from myself and hopefully someone who can sponsor you will pick it up soon.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
s.adam@diffingo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |177841 nThis| |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@ioa.s.u-tokyo.ac.jp
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-06 13:16 EST ------- For 0.5.2-0.3:
* zero-length document - Please explain why you need zero-length documents ------------------------------------------------------- E: zero-length /usr/share/doc/libcompizconfig-0.5.2/README E: zero-length /usr/share/doc/libcompizconfig-0.5.2/ChangeLog -------------------------------------------------------
* undefined non-weak symbols ------------------------------------------------------- W: undefined-non-weak-symbol /usr/lib/libcompizconfig.so.0.0.0 XStringToKeysym W: undefined-non-weak-symbol /usr/lib/libcompizconfig.so.0.0.0 XKeysymToString ------------------------------------------------------- - As this srpm provides -devel subpackage, these undefined non-weak symbols cannot be allowed because this causes linkage failure.
* Timestamp - To keep timestamps on xml and header files, I recommend ------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ------------------------------------------------------- This method usually works on recent Makefiles.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From mohd.izhar.firdaus@gmail.com 2007-10-07 03:41 EST ------- //// * undefined non-weak symbols ------------------------------------------------------- W: undefined-non-weak-symbol /usr/lib/libcompizconfig.so.0.0.0 XStringToKeysym W: undefined-non-weak-symbol /usr/lib/libcompizconfig.so.0.0.0 XKeysymToString ------------------------------------------------------- - As this srpm provides -devel subpackage, these undefined non-weak symbols cannot be allowed because this causes linkage failure.
////
may i know how to resolve this??
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-07 03:55 EST ------- (In reply to comment #8)
////
- undefined non-weak symbols
W: undefined-non-weak-symbol /usr/lib/libcompizconfig.so.0.0.0 XStringToKeysym W: undefined-non-weak-symbol /usr/lib/libcompizconfig.so.0.0.0 XKeysymToString
- As this srpm provides -devel subpackage, these undefined non-weak symbols cannot be allowed because this causes linkage failure.
////
may i know how to resolve this??
"nm -D" shows that both symbols are provides by libX11.so, so linking against libX11.so should fix this.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-07 03:55 EST ------- (In reply to comment #9)
"nm -D" shows that both symbols are provides by libX11.so, so linking against libX11.so should fix this.
s/provides/provided/
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-11 02:56 EST ------- Note: rawhide compiz is now upgrade to 0.6.0
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From mohd.izhar.firdaus@gmail.com 2007-10-11 23:52 EST ------- I have updated the package
http://izhar.fedorapeople.org/libcompizconfig/libcompizconfig-0.6.0-1.5615ca...
- added builddep libX11-devel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From bbbush.yuan@gmail.com 2007-10-12 01:47 EST ------- why compiz-bcop is needed to build this? Is compiz-bcop a devel package?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From mohd.izhar.firdaus@gmail.com 2007-10-12 01:56 EST ------- yup .. compiz-bcop is needed to build compiz plugins .. and libcompizconfig is a compiz plugin and a configuration backend
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |mtasaka@ioa.s.u-tokyo.ac.jp Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-12 02:51 EST ------- Created an attachment (id=225181) --> (https://bugzilla.redhat.com/attachment.cgi?id=225181&action=view) Patch for libX11.so linkage fix
For 0.6.0-1.5615ca
* Undefined non-weak symbols - Still these symbols exist. ----------------------------------------------------- [root@localhost ~]# rpm -q libcompizconfig libcompizconfig-0.6.0-1.5615ca.fc8 [root@localhost ~]# rpmlint libcompizconfig libcompizconfig.i386: W: undefined-non-weak-symbol /usr/lib/libcompizconfig.so.0.0.0 XStringToKeysym libcompizconfig.i386: W: undefined-non-weak-symbol /usr/lib/libcompizconfig.so.0.0.0 XKeysymToString [root@localhost ~]# ldd -r /usr/lib/libcompizconfig.so.0.0.0 >/dev/null undefined symbol: XStringToKeysym (/usr/lib/libcompizconfig.so.0.0.0) undefined symbol: XKeysymToString (/usr/lib/libcompizconfig.so.0.0.0) ----------------------------------------------------- Only installing libX11-devel will not solve this issue. You have to patch against Makefile.in so that libcompizconfig.so is linked against libX11.so.
* Source - The tarball in your srpm was not found on the URL written as source0. * Please refer to http://fedoraproject.org/wiki/Packaging/SourceURL , section "Using Revision Control" * Also, if this tarball is a "pre-release", please also check the section "Non-Numeric Version in Release" of http://fedoraproject.org/wiki/Packaging/NamingGuidelines.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From mohd.izhar.firdaus@gmail.com 2007-10-16 07:40 EST ------- done
SRPM: http://izhar.fedorapeople.org/libcompizconfig/libcompizconfig-0.6.0-0.2.2007...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-16 11:42 EST ------- For 0.6.0-0.2.20071011git:
* License - After I rechecked the whole files in tarball, I noticed that libini.so is licensed under GPLv2+. Also, "COPYING" file in libcompizconfig rpm is GPL. So:
* Change License tag to "LGPLv2+ and GPLv2+". * Add a comment in the spec file like: --------------------------------------------------------- Group: System Environment/Libraries # backends/libini.so is GPLv2+, other parts are LGPLv2+ License: LGPLv2+ and GPLv2+ --------------------------------------------------------- * Add "LICENSE.gpl" "LICENSE.lgpl" to %doc
When you have done the fixes above, I guess I can approve this package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From mohd.izhar.firdaus@gmail.com 2007-10-16 12:51 EST ------- ok .. i've added the changes from comment 17
http://izhar.fedorapeople.org/libcompizconfig/libcompizconfig-0.6.0-0.3.2007...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-16 13:02 EST ------- Okay.
------------------------------------------------------------------ This package (libcompizconfig) is APPROVED by me ------------------------------------------------------------------
Please follow the procedure according to: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Get a Fedora Account". At a point a mail should be sent to sponsor members which notifies that you need a sponsor (at the stage, please also write on this bug for confirmation that you requested for sponsorship) Then I will sponsor you.
If you want to import this package into Fedora 7, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on Fedora rebuilding system).
If you have questions, please ask me.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From mohd.izhar.firdaus@gmail.com 2007-10-16 22:20 EST ------- I have added myself into cvsextras and fedorabugs group..
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
mtasaka@ioa.s.u-tokyo.ac.jp changed:
What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|177841 | nThis| |
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-17 03:27 EST ------- Now I should be sponsoring you. Please proceed.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
mohd.izhar.firdaus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From mohd.izhar.firdaus@gmail.com 2007-10-17 04:01 EST ------- New Package CVS Request ======================= Package Name: libcompizconfig Short Description: Configuration backend for compiz Owners: izhar Branches: F-7 InitialCC: izhar Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2007-10-17 12:20 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From mohd.izhar.firdaus@gmail.com 2007-10-17 12:38 EST ------- thanks kevin
btw, i just noticed compiz-bcop is only available @ devel branch , so i guess the F-7 branch is not needed ( sorry~ ).. am i just required to ignore it? .. or are there some procedure i need to follow to cleanup that?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-10-17 12:50 EST ------- You can just ignore F-7 branch then.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: libcompizconfig - configuration backend for compiz >= 0.5.1
https://bugzilla.redhat.com/show_bug.cgi?id=247406
mohd.izhar.firdaus@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=247406
leigh scott leigh123linux@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |leigh123linux@googlemail.co | |m
--- Comment #26 from leigh scott leigh123linux@googlemail.com 2011-04-01 11:55:26 EDT --- Hi Mohd Izhar,
Is it ok for me to request a epel6 branch?
https://bugzilla.redhat.com/show_bug.cgi?id=677365
Thanks
Leigh
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=247406
leigh scott leigh123linux@googlemail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #27 from leigh scott leigh123linux@googlemail.com 2011-04-01 13:42:33 EDT --- Package Change Request ====================== Package Name: libcompizconfig New Branches: el6 Owners: leigh123linux
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=247406
--- Comment #28 from Jason Tibbitts tibbs@math.uh.edu 2011-04-03 23:50:08 EDT --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org