Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=435234
Summary: Review Request: xdx - DX-cluster tcp/ip client for amateur radio Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: bob@fedoraunity.org QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://bjensen.fedorapeople.org/pkgs/hams/SPECS/xdx.spec SRPM URL: http://bjensen.fedorapeople.org/pkgs/hams/SRPMS/xdx-2.4-2.fc8.src.rpm Description: xdx is a client to connect to a DX-cluster. Dx messages will be displayed in a list, announcements will go to a text display.
This srpm mock builds against Fedora 8 and devel on i386 and x86_64. The resulting rpms are rpmlint clean. Fedora 7 is not a target for this package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xdx - DX-cluster tcp/ip client for amateur radio
https://bugzilla.redhat.com/show_bug.cgi?id=435234
kanarip@kanarip.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |kanarip@kanarip.com Status|NEW |ASSIGNED Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xdx - DX-cluster tcp/ip client for amateur radio
https://bugzilla.redhat.com/show_bug.cgi?id=435234
kanarip@kanarip.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From kanarip@kanarip.com 2008-03-02 09:55 EST ------- RPM Lint: OK Package name: OK Spec file: OK License: OK (GPLv2+) Actual License: OK (GPLv2+ from source) %doc License: OK Spec file language: OK Spec file readable: OK Upstream source vs. used tarball: OK (md5sum match) Compile and Build: - F-7: FAILED (not targeted) - F-8: OK - rawhide: OK - EL-5: FAILED (not targeted)
Applicable Package Guidelines: - -debuginfo package: OK (~136K) Locales: OK Shared libs: N/A Relocatable: N/A Directory and file ownership: OK No duplicate files in %files: OK File Permissions: OK Macro usage: OK Code vs. Content: OK (Large) Documentation: N/A, OK %doc affecting runtime: OK Header files in -devel package: N/A Static Libraries in -static package: N/A pkgconfig Requires: OK Library files: N/A Devel requires base package: N/A .la libtool archives: N/A Duplicate ownership of files/directories: OK Remove BuildRoot: OK UTF-8 filenames: OK
In the spec file you have:
#don't include backup file in package rm -f `find $RPM_BUILD_ROOT -name *~`
which might result in a 'argument list too long' at some point, especially larger packages. Consider using:
find $RPM_BUILD_ROOT -name "*~" -exec rm -f {} ;
Quoting the -name "*~" ensures it doesn't match against a file in $CWD
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xdx - DX-cluster tcp/ip client for amateur radio
https://bugzilla.redhat.com/show_bug.cgi?id=435234
bob@fedoraunity.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From bob@fedoraunity.org 2008-03-02 10:25 EST ------- New Package CVS Request ======================= Package Name: xdx Short Description: DX-cluster tcp/ip client for amateur radio Owners: bjensen,sconklin Branches: F-7 F-8 InitialCC: sindgepb Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xdx - DX-cluster tcp/ip client for amateur radio
https://bugzilla.redhat.com/show_bug.cgi?id=435234
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-03-02 12:15 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xdx - DX-cluster tcp/ip client for amateur radio
https://bugzilla.redhat.com/show_bug.cgi?id=435234
------- Additional Comments From updates@fedoraproject.org 2008-03-02 16:57 EST ------- xdx-2.4-2.fc8 has been submitted as an update for Fedora 8
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xdx - DX-cluster tcp/ip client for amateur radio
https://bugzilla.redhat.com/show_bug.cgi?id=435234
bob@fedoraunity.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From bob@fedoraunity.org 2008-03-02 17:08 EST ------- Thank you for the review.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: xdx - DX-cluster tcp/ip client for amateur radio
https://bugzilla.redhat.com/show_bug.cgi?id=435234
------- Additional Comments From updates@fedoraproject.org 2008-03-03 13:22 EST ------- xdx-2.4-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla