[Bug 534168] New: Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: groovy - Agile dynamic language for the Java Platform

https://bugzilla.redhat.com/show_bug.cgi?id=534168

Summary: Review Request: groovy - Agile dynamic language for
                    the Java Platform
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
        Depends on: 534021,534135
   Estimated Hours: 0.0
    Classification: Fedora

SPEC: http://v3.sk/~lkundrak/SPECS/groovy.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/groovy-1.6.5-1.fc12.src.rpm

Desktop:

Groovy is an agile and dynamic language for the Java Virtual Machine,
built upon Java with features inspired by languages like Python, Ruby and
Smalltalk.  It seamlessly integrates with all existing Java objects and
libraries and compiles straight to Java bytecode so you can use it anywhere
you can use Java.

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

--- Comment #1 from Lubomir Rintel   2009-11-10 15:06:14 EDT ---
(In reply to comment #0)
> Desktop:

Description:

...

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

Lubomir Rintel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |F13FeatureIDEA

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

--- Comment #2 from Lubomir Rintel   2009-11-27 06:58:43 EDT ---
SPEC: http://v3.sk/~lkundrak/SPECS/groovy.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/groovy-1.6.5-2.src.rpm

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

Jochen Schmitt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Jochen Schmitt   2009-11-29 15:36:41 EDT ---
Some prereview question:

* Why you have 'Reguires: groovy' on your package?
* should 'Requires: ivy' be 'Requires apache-ivy'?

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

--- Comment #4 from Lubomir Rintel   2009-11-30 04:10:56 EDT ---
(In reply to comment #3)
> Some prereview question:
> Why you have 'Reguires: groovy' on your package?

Probably a mistake.
> should 'Requires: ivy' be 'Requires apache-ivy'?

apache-ivy provides ivy. At least in jpackage the package is called ivy,
therefore I find this good for cross-distro compatibility.

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

--- Comment #5 from Jochen Schmitt   2009-11-30 12:21:14 EDT ---
The project homepage of groovy offer groovy-1.6.6 as the current stable
release.

It may be nice, if you can offer a new package based on this release.

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

--- Comment #6 from Lubomir Rintel   2009-11-30 15:09:55 EDT ---
(In reply to comment #5)
> The project homepage of groovy offer groovy-1.6.6 as the current stable
> release.
>
> It may be nice, if you can offer a new package based on this release.

Sure, here you are:

SPEC: http://v3.sk/~lkundrak/SPECS/groovy.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/groovy-1.6.6-1.fc13.src.rpm

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

--- Comment #7 from Lubomir Rintel   2009-12-03 03:51:07 EDT ---
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1845439
SPEC: http://v3.sk/~lkundrak/SPECS/groovy.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/groovy-1.6.6-2.fc13.src.rpm

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

Bug 534168 depends on bug 534135, which changed state.

Bug 534135 Summary: Review Request: xstream - Java XML serialization library
https://bugzilla.redhat.com/show_bug.cgi?id=534135

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

Jochen Schmitt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

--- Comment #8 from Jochen Schmitt   2009-12-03 12:48:21 EDT ---
Good:
+ Basename of the SPEC file matches with package name
+ Name of the package fullfill naming guidelines
+ Consistently usage of rpm macros
+ URL tag shows to proper project homepage
+ License tag state ASL 2.0 as valid OSS license
+ License in the copyright notes on the top of the
  source files matches license stated by the license
  tag 
+ Could download upstream sources via spectool -g
+ Package sources matches with upstream
(md5sum: d50466fab035b9c4eaff87e8eadb119d)
+ Package contains a javadoc subpackage
+ Package has proper BuildRoot definition
+ BuildRoot will be cleaned at the beginning of %clean and %install
+ Local build works fine.
+ Rpmlint is silent on source package
+ Rpmlint is silent on binary package
+ Rpmlint is silent on javadoc subpackage
+ Scratch build on koji works fine
+ Local install and uninstall works fine
+ Start of application works without a crash
+ GUI menu works fine
+ Fies have proper permissions
+ Files stanza has no duplicated entries
+ All package files and dirs are own by the package
+ No file or dir may belong to another package
+ %doc stanza is small
+ Package has proper changelog

Bad:
- File LICENSE.txt doesn't contains a verbatin copy of
  the license text. Insteand you find a link to the
  license text provided by a website.
- Not all source files seems to have a copyright
  notice.
- It may be nice, if can the chose a shrter text
  for the GenericName tag in the desktop file

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

--- Comment #9 from Lubomir Rintel   2009-12-03 13:17:43 EDT ---
(In reply to comment #8)
> Bad:
> File LICENSE.txt doesn't contains a verbatin copy of
> the license text. Insteand you find a link to the
> license text provided by a website.

Upstream was informed, this seems to be allowed per packaging guidelines
though.
> Not all source files seems to have a copyright
> notice.

Sent a mail to upstream mailing list.
> It may be nice, if can the chose a shrter text
> for the GenericName tag in the desktop file

Will do that for next package spin. Does this block review (or any of the above
two?)

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

--- Comment #10 from Jochen Schmitt   2009-12-03 13:38:10 EDT ---
(In reply to comment #9)
> Will do that for next package spin. Does this block review (or any of the above
> two?)

It may be nice, if we can do it in the package which we want to introduced into
Fedora.

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

--- Comment #11 from Lubomir Rintel   2009-12-05 04:47:30 EDT ---
Jochen, I'm not sure what's the action point now and replying "may be nice"
didn't really help me. Could you please be more specific at what blocks this
review?

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

--- Comment #12 from Jochen Schmitt   2009-12-08 15:27:15 EDT ---
When I install groovy, I have the following menu text:

"Programming environment for the Groovy langua..."

This text is too large to display is at whole in the menu.

So it want to see, that you may find a shorter version of this text which
should fit into the menu.

Best Regards:

Jochen Schmitt

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

--- Comment #13 from Lubomir Rintel   2009-12-09 06:30:40 EDT ---
SPEC: http://v3.sk/~lkundrak/SPECS/groovy.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/groovy-1.6.7-1.fc12.src.rpm
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1864098

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

Lubomir Rintel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |540708

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

Jochen Schmitt  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #14 from Jochen Schmitt   2009-12-09 12:21:22 EDT ---
Good:
+ Package contains recent release of the application
+ Packed tar ball matches with upstream
(md5sum: f63532d75560f101bf1f40b7a3760228)
+ Local build works fine
+ Local install/uninstall works fine
+ Desktop menu entry looks fine.
+ Mock build works fine

*** APPROVED ***

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

Lubomir Rintel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

--- Comment #15 from Lubomir Rintel   2009-12-09 12:24:29 EDT ---
Thank you!

New Package CVS Request
=======================
Package Name: groovy
Short Description: Agile dynamic language for the Java Platform
Owners: lkundrak
Branches: F-11 F-12 EL-5

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

Kevin Fenzi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

--- Comment #16 from Kevin Fenzi   2009-12-09 12:54:35 EDT ---
cvs done.

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

Bug 534168 depends on bug 534021, which changed state.

Bug 534021 Summary: Review Request: apache-ivy - Java-based dependency manager
https://bugzilla.redhat.com/show_bug.cgi?id=534021

What    |Old Value                   |New Value
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

[Bug 534168] Review Request: groovy - Agile dynamic language for the Java Platform

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=534168

Lubomir Rintel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |NEXTRELEASE

--- Comment #17 from Lubomir Rintel   2009-12-09 13:34:10 EDT ---
Imported and built.