[Bug 434704] New: Review Request: ocamldsort - Dependency sorter for OCaml source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

https://bugzilla.redhat.com/show_bug.cgi?id=434704

Summary: Review Request: ocamldsort - Dependency sorter for OCaml
                    source files
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail],[e-mail]

Spec URL: http://www.annexia.org/tmp/ocaml/ocamldsort.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/ocamldsort-0.14.4-1.fc9.src.rpm
Description: Dependency sorter for OCaml source files

This package is rpmlint-clean.

[Bug 434704] Review Request: ocamldsort - Dependency sorter for OCaml source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocamldsort - Dependency sorter for OCaml source files

https://bugzilla.redhat.com/show_bug.cgi?id=434704

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

[Bug 434704] Review Request: ocamldsort - Dependency sorter for OCaml source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocamldsort - Dependency sorter for OCaml source files

https://bugzilla.redhat.com/show_bug.cgi?id=434704

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |

[Bug 434704] Review Request: ocamldsort - Dependency sorter for OCaml source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocamldsort - Dependency sorter for OCaml source files

https://bugzilla.redhat.com/show_bug.cgi?id=434704

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]    |[e-mail]
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?

------- Additional Comments From [e-mail]  2008-03-01 12:11 EST -------
build failed 
http://koji.fedoraproject.org/koji/taskinfo?taskID=482326
log said =>
configure: error: Cannot find camlp4.

[Bug 434704] Review Request: ocamldsort - Dependency sorter for OCaml source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocamldsort - Dependency sorter for OCaml source files

https://bugzilla.redhat.com/show_bug.cgi?id=434704

------- Additional Comments From [e-mail]  2008-03-01 13:54 EST -------
Ick, missing camlp4 again.

Spec URL: http://www.annexia.org/tmp/ocaml/ocamldsort.spec
SRPM URL: http://www.annexia.org/tmp/ocaml/ocamldsort-0.14.4-2.fc9.src.rpm

* Sat Mar  1 2008 Richard W.M. Jones  - 0.14.4-2
- Add missing BR ocaml-camlp4-devel and test in mock.

[Bug 434704] Review Request: ocamldsort - Dependency sorter for OCaml source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocamldsort - Dependency sorter for OCaml source files

https://bugzilla.redhat.com/show_bug.cgi?id=434704

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

------- Additional Comments From [e-mail]  2008-03-02 03:23 EST -------
Review:
+ package builds in mock (rawhide i386).
koji build =>  http://koji.fedoraproject.org/koji/taskinfo?taskID=483521
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
9651d6afb204c0b22cd69be8a847e1d4  ocamldsort-0.14.4.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets are used.
+ Not a GUI app.
APPROVED.

[Bug 434704] Review Request: ocamldsort - Dependency sorter for OCaml source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocamldsort - Dependency sorter for OCaml source files

https://bugzilla.redhat.com/show_bug.cgi?id=434704

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-cvs?

------- Additional Comments From [e-mail]  2008-03-02 05:54 EST -------
New Package CVS Request
=======================
Package Name: ocamldsort
Short Description: Dependency sorter for OCaml source files
Owners: rjones
Branches: F-8
InitialCC: rjones
Cvsextras Commits: yes

[Bug 434704] Review Request: ocamldsort - Dependency sorter for OCaml source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocamldsort - Dependency sorter for OCaml source files

https://bugzilla.redhat.com/show_bug.cgi?id=434704

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-cvs?                 |fedora-cvs+

------- Additional Comments From [e-mail]  2008-03-02 11:47 EST -------
cvs done.

[Bug 434704] Review Request: ocamldsort - Dependency sorter for OCaml source files

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: ocamldsort - Dependency sorter for OCaml source files

https://bugzilla.redhat.com/show_bug.cgi?id=434704

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|                            |RAWHIDE

------- Additional Comments From [e-mail]  2008-03-03 08:36 EST -------
Built for F-8: http://koji.fedoraproject.org/koji/taskinfo?taskID=486880
and for Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=486895