[Bug 1856589] New: Review Request: openshadinglanguage - Advanced shading language for production GI renderers
https://bugzilla.redhat.com/show_bug.cgi?id=1856589
Bug ID: 1856589 Summary: Review Request: openshadinglanguage - Advanced shading language for production GI renderers Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: luya_tfz@thefinalzone.net QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/... SRPM URL: https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/... Description: Open Shading Language (OSL) is a small but rich language for programmable shading in advanced renderers and other applications, ideal for describing materials, lights, displacement, and pattern generation.
Fedora Account System Username:luya
https://bugzilla.redhat.com/show_bug.cgi?id=1856589
Luya Tshimbalanga luya_tfz@thefinalzone.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Luya Tshimbalanga luya_tfz@thefinalzone.net --- COPR repository with successful built: https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/...
https://bugzilla.redhat.com/show_bug.cgi?id=1856589
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Flags| |fedora-review?
--- Comment #2 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- - License should be BSD:
License: BSD
- Remove rpath from these binaries:
openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/oslc ['/usr/lib64'] openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/oslinfo ['/usr/lib64'] openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/osltoy ['/usr/lib64'] openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/testrender ['/usr/lib64'] openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/testshade ['/usr/lib64'] openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/testshade_dso ['/usr/lib64']
OpenImageIO-plugin-osl.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/OpenImageIO-2.1/osl.imageio.so ['/usr/lib64']
openshadinglanguage-libs.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/liboslcomp.so.1.11.6 ['/usr/lib64'] openshadinglanguage-libs.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/liboslexec.so.1.11.6 ['/usr/lib64'] openshadinglanguage-libs.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/liboslnoise.so.1.11.6 ['/usr/lib64'] openshadinglanguage-libs.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/liboslquery.so.1.11.6 ['/usr/lib64'] openshadinglanguage-libs.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libtestshade.so.1.11.6 ['/usr/lib64']
Use:
-DCMAKE_SKIP_RPATH=TRUE \ -DCMAKE_SKIP_INSTALL_RPATH=YES
- Don't mix tabs and spaces:
openshadinglanguage.src:14: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 14)
- The description should be split to 80 characters per line:
openshadinglanguage.src: E: description-line-too-long C Open Shading Language (OSL) is a small but rich language for programmable shading in advanced renderers and other applications, ideal for describing materials, lights, displacement, and pattern generation.
- Own this directory:
[!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/OpenImageIO-2.1
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [!]: Rpath absent or only used for internal libs. Note: See rpmlint output [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la)
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-clause "New" or "Revised" License", "Public domain". 1283 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/openshadinglanguage/review- openshadinglanguage/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/OpenImageIO-2.1 [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/cmake(leatherman- devel, libssh-devel, PackageKit-Qt5-devel, libdynaplugz-devel, qaccessibilityclient-devel, cmake-filesystem, qt5-qtbase, marble- astro-devel, telepathy-qt5-devel, qjson-devel, uid_wrapper, libsavitar-devel, paraview-devel, libarcus-lulzbot-devel, marble- widget-qt5-devel, kqtquickcharts, pulseaudio-libs-devel, libarcus- devel, qjson-qt5-devel, openobex-devel), /usr/lib64/pkgconfig(ignition-transport-devel, dontpanic-devel, ignition-math-devel, uid_wrapper, pkgconf-pkg-config, libmodsecurity- devel, bemenu-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 184320 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in openshadinglanguage-MaterialX-shaders-source , openshadinglanguage- example-shaders-source , openshadinglanguage-common-headers , OpenImageIO-plugin-osl , openshadinglanguage-libs , openshadinglanguage-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: openshadinglanguage-1.11.6.0-1.fc33.x86_64.rpm openshadinglanguage-doc-1.11.6.0-1.fc33.noarch.rpm
openshadinglanguage-MaterialX-shaders-source-1.11.6.0-1.fc33.noarch.rpm openshadinglanguage-example-shaders-source-1.11.6.0-1.fc33.noarch.rpm openshadinglanguage-common-headers-1.11.6.0-1.fc33.noarch.rpm OpenImageIO-plugin-osl-1.11.6.0-1.fc33.x86_64.rpm openshadinglanguage-libs-1.11.6.0-1.fc33.x86_64.rpm openshadinglanguage-devel-1.11.6.0-1.fc33.x86_64.rpm openshadinglanguage-debuginfo-1.11.6.0-1.fc33.x86_64.rpm openshadinglanguage-debugsource-1.11.6.0-1.fc33.x86_64.rpm openshadinglanguage-1.11.6.0-1.fc33.src.rpm openshadinglanguage.x86_64: W: spelling-error Summary(en_US) renderers -> renders, surrender, render openshadinglanguage.x86_64: W: spelling-error %description -l en_US renderers -> renders, surrender, render openshadinglanguage.x86_64: E: description-line-too-long C Open Shading Language (OSL) is a small but rich language for programmable shading in advanced renderers and other applications, ideal for describing materials, lights, displacement, and pattern generation. openshadinglanguage.x86_64: W: invalid-license BSD-3.0 openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/oslc ['/usr/lib64'] openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/oslinfo ['/usr/lib64'] openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/osltoy ['/usr/lib64'] openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/testrender ['/usr/lib64'] openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/testshade ['/usr/lib64'] openshadinglanguage.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/testshade_dso ['/usr/lib64'] openshadinglanguage.x86_64: W: no-manual-page-for-binary oslc openshadinglanguage.x86_64: W: no-manual-page-for-binary oslinfo openshadinglanguage.x86_64: W: no-manual-page-for-binary osltoy openshadinglanguage.x86_64: W: no-manual-page-for-binary testrender openshadinglanguage.x86_64: W: no-manual-page-for-binary testshade openshadinglanguage.x86_64: W: no-manual-page-for-binary testshade_dso openshadinglanguage-doc.noarch: W: spelling-error %description -l en_US renderers -> renders, surrender, render openshadinglanguage-MaterialX-shaders-source.noarch: W: spelling-error Summary(en_US) shader -> shared, shade, shadier openshadinglanguage-MaterialX-shaders-source.noarch: W: spelling-error %description -l en_US renderers -> renders, surrender, render openshadinglanguage-MaterialX-shaders-source.noarch: W: spelling-error %description -l en_US shader -> shared, shade, shadier openshadinglanguage-MaterialX-shaders-source.noarch: W: no-documentation openshadinglanguage-example-shaders-source.noarch: W: spelling-error Summary(en_US) shader -> shared, shade, shadier openshadinglanguage-example-shaders-source.noarch: W: spelling-error %description -l en_US renderers -> renders, surrender, render openshadinglanguage-example-shaders-source.noarch: W: no-documentation openshadinglanguage-common-headers.noarch: W: spelling-error %description -l en_US renderers -> renders, surrender, render openshadinglanguage-common-headers.noarch: W: no-documentation OpenImageIO-plugin-osl.x86_64: W: spelling-error %description -l en_US renderers -> renders, surrender, render OpenImageIO-plugin-osl.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/OpenImageIO-2.1/osl.imageio.so ['/usr/lib64'] OpenImageIO-plugin-osl.x86_64: W: no-documentation openshadinglanguage-libs.x86_64: W: spelling-error %description -l en_US renderers -> renders, surrender, render openshadinglanguage-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/liboslcomp.so.1.11.6 exit@GLIBC_2.2.5 openshadinglanguage-libs.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/liboslcomp.so.1.11.6 ['/usr/lib64'] openshadinglanguage-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/liboslexec.so.1.11.6 exit@GLIBC_2.2.5 openshadinglanguage-libs.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/liboslexec.so.1.11.6 ['/usr/lib64'] openshadinglanguage-libs.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/liboslnoise.so.1.11.6 ['/usr/lib64'] openshadinglanguage-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/liboslquery.so.1.11.6 exit@GLIBC_2.2.5 openshadinglanguage-libs.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/liboslquery.so.1.11.6 ['/usr/lib64'] openshadinglanguage-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libtestshade.so.1.11.6 exit@GLIBC_2.2.5 openshadinglanguage-libs.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libtestshade.so.1.11.6 ['/usr/lib64'] openshadinglanguage-libs.x86_64: W: no-documentation openshadinglanguage-devel.x86_64: W: no-documentation openshadinglanguage-debuginfo.x86_64: W: invalid-license BSD-3.0 openshadinglanguage-debugsource.x86_64: W: invalid-license BSD-3.0 openshadinglanguage.src: W: spelling-error Summary(en_US) renderers -> renders, surrender, render openshadinglanguage.src: W: spelling-error %description -l en_US renderers -> renders, surrender, render openshadinglanguage.src: E: description-line-too-long C Open Shading Language (OSL) is a small but rich language for programmable shading in advanced renderers and other applications, ideal for describing materials, lights, displacement, and pattern generation. openshadinglanguage.src: W: invalid-license BSD-3.0 openshadinglanguage.src:14: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 14) 11 packages and 0 specfiles checked; 14 errors, 34 warnings.
https://bugzilla.redhat.com/show_bug.cgi?id=1856589
--- Comment #3 from Luya Tshimbalanga luya_tfz@thefinalzone.net --- Upated files SPEC: https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/... SRPM: https://download.copr.fedorainfracloud.org/results/luya/openshadinglanguage/...
https://bugzilla.redhat.com/show_bug.cgi?id=1856589
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #4 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- LGTM, package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1856589
--- Comment #5 from Luya Tshimbalanga luya_tfz@thefinalzone.net --- Thank you Robert-Andre!
https://bugzilla.redhat.com/show_bug.cgi?id=1856589
Luya Tshimbalanga luya_tfz@thefinalzone.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1858531
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1858531 [Bug 1858531] Review Request: partio- Library for reading/writing/manipulating common animation particle
https://bugzilla.redhat.com/show_bug.cgi?id=1856589
--- Comment #6 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/openshadinglanguage
https://bugzilla.redhat.com/show_bug.cgi?id=1856589 Bug 1856589 depends on bug 1858531, which changed state.
Bug 1858531 Summary: Review Request: partio - Library for reading/writing/manipulating common animation particle https://bugzilla.redhat.com/show_bug.cgi?id=1858531
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1856589
Luya Tshimbalanga luya_tfz@thefinalzone.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2020-09-06 05:43:52
--- Comment #7 from Luya Tshimbalanga luya_tfz@thefinalzone.net --- Closing as the package is available in the repository.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com