[Bug 1225406] New: Review Request: rubygem-jruby-openssl - JRuby's OpenSSL gem

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1225406

Bug ID: 1225406
           Summary: Review Request: rubygem-jruby-openssl - JRuby's
                    OpenSSL gem
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL: https://msrb.fedorapeople.org/rubygem-jruby-openssl.spec
SRPM URL:
https://msrb.fedorapeople.org/rubygem-jruby-openssl-0.9.7-1.fc23.src.rpm
Description: JRuby-OpenSSL is an add-on gem for JRuby that emulates the Ruby
OpenSSL native library. Under the hood uses the Bouncy Castle Crypto APIs.
Fedora Account System Username: msrb

[Bug 1225406] Review Request: rubygem-jruby-openssl - JRuby's OpenSSL gem

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1225406

Michal Srb  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1198676

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1198676
[Bug 1198676] jruby: missing add-on gems

[Bug 1225406] Review Request: rubygem-jruby-openssl - JRuby's OpenSSL gem

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1225406

Josef Stribny  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]

--- Comment #1 from Josef Stribny  ---
I will take it for a review.

[Bug 1225406] Review Request: rubygem-jruby-openssl - JRuby's OpenSSL gem

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1225406

--- Comment #2 from Josef Stribny  ---
* This package is intended for JRuby only and fails on CRuby, so proper
Requires: jruby should be used.

# irb
irb(main):001:0> require 'jopenssl/load'
Loading jruby-openssl in a non-JRuby interpreter
LoadError: cannot load such file -- java
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in
`require'
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:54:in
`require'
    from /usr/share/gems/gems/jruby-openssl-0.9.7/lib/jopenssl/load.rb:3:in
`<top (required)>'
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:128:in
`require'
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:128:in `rescue
in require'
    from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:39:in
`require'
    from (irb):1
    from /usr/bin/irb:11:in `<main>'

* Requires: ruby(release) is auto-generated and should be deleted.

* I would appreciate a comment above the following like specifying the
referenced library:

%global bc_version 1.50

[Bug 1225406] Review Request: rubygem-jruby-openssl - JRuby's OpenSSL gem

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1225406

--- Comment #3 from Michal Srb  ---
Updated spec+srpm:

Spec URL: https://msrb.fedorapeople.org/2/rubygem-jruby-openssl.spec
SRPM URL:
https://msrb.fedorapeople.org/2/rubygem-jruby-openssl-0.9.7-2.fc23.src.rpm

%changelog
* Wed May 27 2015 Michal Srb  - 0.9.7-2
- Explicitly require JRuby
- Drop R: ruby(release)
- Add comment for %%bc_version

[Bug 1225406] Review Request: rubygem-jruby-openssl - JRuby's OpenSSL gem

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1225406

--- Comment #4 from Josef Stribny  ---
For the question of packaging the Java extensions I opened an upstream issue:
https://github.com/rubygems/rubygems/issues/1260

[Bug 1225406] Review Request: rubygem-jruby-openssl - JRuby's OpenSSL gem

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1225406

Josef Stribny  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+

--- Comment #5 from Josef Stribny  ---
I don't believe we can do much about the way Java extensions are packaged in
upstream .gem packages at the moment, therefore I no longer see this as a
blocker for the review. Let's make JRuby functional, we can deal with this
later if necessary.

==> APPROVED.

[Bug 1225406] Review Request: rubygem-jruby-openssl - JRuby's OpenSSL gem

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1225406

Michal Srb  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #6 from Michal Srb  ---
Thanks for the review!

New Package SCM Request
=======================
Package Name: rubygem-jruby-openssl
Short Description: JRuby's OpenSSL gem
Upstream URL: https://github.com/jruby/jruby-openssl
Owners: msrb mizdebsk msimacek
Branches: f22
InitialCC: java-sig

[Bug 1225406] Review Request: rubygem-jruby-openssl - JRuby's OpenSSL gem

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1225406

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+

[Bug 1225406] Review Request: rubygem-jruby-openssl - JRuby's OpenSSL gem

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1225406

--- Comment #7 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 1225406] Review Request: rubygem-jruby-openssl - JRuby's OpenSSL gem

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1225406

John Skeoch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]         |[e-mail]

[Bug 1225406] Review Request: rubygem-jruby-openssl - JRuby's OpenSSL gem

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1225406

Vít Ondruch  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
                 CC|                            |[e-mail]
         Resolution|---                         |CURRENTRELEASE
           Assignee|[e-mail]           |[e-mail]
        Last Closed|                            |2016-01-04 04:07:01

--- Comment #9 from Vít Ondruch  ---
Closing this ticket, since the package is in Fedora for some time already.