[Bug 1982632] New: Review Request: php-icewind-smb3 - Php wrapper for smbclient and libsmbclient-php
https://bugzilla.redhat.com/show_bug.cgi?id=1982632
Bug ID: 1982632 Summary: Review Request: php-icewind-smb3 - Php wrapper for smbclient and libsmbclient-php Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ce@lcts.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-raw... SRPM URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-raw...
Description: PHP wrapper for smbclient and libsmbclient-php.
Since this package is set up to use rpmautospec, rpmlint/fedora-review will complain about missing dist tags & macros in changelog. These are spurious errors/warnings.
This package is available from the lcts/nextcloud Copr, so you can also test it using 'fedora-review --copr-build 2329592'
Fedora Account System Username: lcts
https://bugzilla.redhat.com/show_bug.cgi?id=1982632
Christopher Engelhard ce@lcts.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1981857 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1981857 [Bug 1981857] Unbundle 3rdparty PHP dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1982632
Hirotaka Wakabayashi hiwkby@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@fedoraproject.org |hiwkby@yahoo.com Status|NEW |ASSIGNED CC| |hiwkby@yahoo.com
--- Comment #1 from Hirotaka Wakabayashi hiwkby@yahoo.com --- A successful Koji scratch build. https://koji.fedoraproject.org/koji/taskinfo?taskID=75674134
https://bugzilla.redhat.com/show_bug.cgi?id=1982632
--- Comment #2 from Hirotaka Wakabayashi hiwkby@yahoo.com --- Hello Christopher, thank you for your submiting a package. Please see my review.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues: =======
- License ``` License: MIT ``` should be ``` License: MIT and AGPLv3+ ``` Because some files are not under MIT license and please clarify the license for example.php, which doesn't contain license information. Please see: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuideline...
- Package dependencies ``` Requires: php(language) >= 7.2 Requires: php-composer(icewind/streams) >= 0.7.3 ``` should be ``` Requires: php(language) Requires: php-composer(icewind/streams) ``` Because versioned dependencies are discouraged when the previous three Fedora releases would satisfy the dependency. Please see for package dependencies: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_dependen...
- Replacing an existing package This package should provide clean upgrade path if it is a compatible enough replacement to php-icewind-smb2. Please see: https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-repla...
- BuildRequires ``` BuildRequires: %{_bindir}/php ``` can be ``` BuildRequires: php-cli ```
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
PHP: [!]: Run phpci static analyze on all php files. Note: phpcompatinfo not found. Install php-bartlett-PHP-CompatInfo package to get a more comprehensive php review. See: url: undefined
Rpmlint ------- [build@471ab04d6d51 1982632-php-icewind-smb3]$ rpmlint ./results/php-icewind-smb3-3.4.1-1.fc36.src.rpm (none): W: unable to init enchant, spellchecking disabled. (none): W: unable to init enchant, spellchecking disabled. ================================================================================= rpmlint session starts ================================================================================ rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1
php-icewind-smb3.spec:138: W: macro-in-%changelog %autochangelog ================================================== 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.1 s =================================================
[build@471ab04d6d51 1982632-php-icewind-smb3]$ rpmlint ./results/php-icewind-smb3-3.4.1-1.fc36.noarch.rpm (none): W: unable to init enchant, spellchecking disabled. (none): W: unable to init enchant, spellchecking disabled. ================================================================================= rpmlint session starts ================================================================================ rpmlint: 2.1.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1
================================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s =================================================
Source checksums ---------------- https://github.com/icewind1991/SMB/archive/9dba42ab2a3990de29e18cc62b0a8270a... : CHECKSUM(SHA256) this package : e6d8ec4ea2af7ce01dda44446acf1e6217d5732ab1858533d5ba0ad430c8565b CHECKSUM(SHA256) upstream package : e6d8ec4ea2af7ce01dda44446acf1e6217d5732ab1858533d5ba0ad430c8565b
Requires -------- php-icewind-smb3 (rpmlib, GLIBC filtered): php(language) php-composer(fedora/autoloader) php-composer(icewind/streams) php-date php-json php-mbstring php-pcre php-spl
Provides -------- php-icewind-smb3: php-composer(icewind/smb3) php-icewind-smb3
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1982632 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Python, Perl, R, fonts, Ocaml, Haskell, Java, SugarActivity, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com