[Bug 876411] New: Review Request: perl-Language-Expr - Simple mini-language for use in expression
https://bugzilla.redhat.com/show_bug.cgi?id=876411
Bug ID: 876411 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: perl-Language-Expr - Simple mini-language for use in expression Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: miro@hroncok.cz Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: https://github.com/hroncok/SPECS/raw/master/perl-Language-Expr.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-Language-Expr-0.19-1.fc17.sr...
Description: Language::Expr defines a simple, Perl-like expression mini-language. It supports mathematical and string operators, arrays, hashes, variables, and functions. See Language::Expr::Manual::Syntax for description of the language syntax.
Fedora Account System Username: churchyard
https://bugzilla.redhat.com/show_bug.cgi?id=876411
Miro Hrončok miro@hroncok.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 (FE-NEEDSPONSOR) Depends On| |876406
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
Mario Blättermann mario.blaettermann@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mario.blaettermann@gmail.co | |m Blocks|177841 (FE-NEEDSPONSOR) |
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
--- Comment #1 from Miro Hrončok miro@hroncok.cz --- Spec URL: https://github.com/hroncok/SPECS/raw/master/perl-Language-Expr.spec SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-Language-Expr-0.19-3.fc17.sr...
- Removed some BRs - Removed perl autofilter
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
Miro Hrončok miro@hroncok.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |878680
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
Bug 876411 depends on bug 878680, which changed state.
Bug 878680 Summary: Review Request: perl-UUID-Tiny - Pure Perl UUID Support With Functional Interface https://bugzilla.redhat.com/show_bug.cgi?id=878680
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
Miro Hrončok miro@hroncok.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |890819
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
Miro Hrončok miro@hroncok.cz changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |890833
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
Bug 876411 depends on bug 890819, which changed state.
Bug 890819 Summary: Review Request: perl-Regexp-Grammars - Add grammatical parsing features to Perl 5.10 regexps https://bugzilla.redhat.com/show_bug.cgi?id=890819
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NOTABUG
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
Petr Šabata psabata@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |851734
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
Bug 876411 depends on bug 876406, which changed state.
Bug 876406 Summary: Review Request: perl-Data-Rmap - Recursive map, apply a block to a data structure https://bugzilla.redhat.com/show_bug.cgi?id=876406
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tchollingsworth@gmail.com Assignee|nobody@fedoraproject.org |tchollingsworth@gmail.com Flags| |fedora-review?
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
T.C. Hollingsworth tchollingsworth@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
--- Comment #2 from T.C. Hollingsworth tchollingsworth@gmail.com ---
Package Review ==============
Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed
Resolution: APPROVED
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/fedora/patches/876411-perl-Language- Expr/licensecheck.txt [x]: Package consistently uses macro is (instead of hard-coded directory names). [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [-]: Large documentation must go in a -doc subpackage. [x]: Packages must not store files under /srv, /opt or /usr/local
Perl: [x]: Package contains the mandatory BuildRequires and Reguires:. [x]: CPAN urls should be non-versioned.
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (Language-Expr-0.19.tar.gz) This is okay. [x]: SourceX is a working URL. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. [-]: Large data in /usr/share should live in a noarch subpackage if package is arched.
Rpmlint ------- Checking: perl-Language-Expr-0.19-3.fc19.src.rpm perl-Language-Expr-0.19-3.fc19.noarch.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint perl-Language-Expr 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:'
Requires -------- perl-Language-Expr-0.19-3.fc19.noarch.rpm (rpmlib, GLIBC filtered):
perl >= 1:5.010 perl(:MODULE_COMPAT_5.16.2) perl(Exporter) perl(JSON) perl(Language::Expr::Interpreter::Default) perl(Language::Expr::Parser) perl(List::MoreUtils) perl(List::Util) perl(Moo) perl(Moo::Role) perl(Regexp::Grammars) perl(UUID::Tiny) perl(boolean) perl(strict) perl(warnings)
Provides -------- perl-Language-Expr-0.19-3.fc19.noarch.rpm:
perl(Language::Expr) = 0.19 perl(Language::Expr::Compiler::Base) = 0.19 perl(Language::Expr::Compiler::JS) = 0.19 perl(Language::Expr::Compiler::PHP) = 0.19 perl(Language::Expr::Compiler::Perl) = 0.19 perl(Language::Expr::Evaluator) = 0.19 perl(Language::Expr::EvaluatorRole) = 0.19 perl(Language::Expr::Interpreter::Default) = 0.19 perl(Language::Expr::Interpreter::Dummy) = 0.19 perl(Language::Expr::Interpreter::VarEnumer) = 0.19 perl(Language::Expr::Parser) = 0.19 perl-Language-Expr = 0.19-3.fc19
MD5-sum check ------------- http://www.cpan.org/authors/id/S/SH/SHARYANTO/Language-Expr-0.19.tar.gz : CHECKSUM(SHA256) this package : cdc7411f0f5388f12b76f905a27ed5f95a77bea1ee11c216c86b3bd442f64350 CHECKSUM(SHA256) upstream package : cdc7411f0f5388f12b76f905a27ed5f95a77bea1ee11c216c86b3bd442f64350
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b876411
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
Miro Hrončok mhroncok@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #3 from Miro Hrončok mhroncok@redhat.com --- New Package SCM Request ======================= Package Name: perl-Language-Expr Short Description: Simple mini-language for use in expression Owners: churchyard Branches: f17 f18 InitialCC: perl-sig
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
--- Comment #4 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- perl-Language-Expr-0.19-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/perl-Language-Expr-0.19-3.fc18
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- perl-Language-Expr-0.19-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Language-Expr-0.19-3.fc17
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- perl-Language-Expr-0.19-3.fc17 has been pushed to the Fedora 17 testing repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2013-01-24 16:59:36
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- perl-Language-Expr-0.19-3.fc18 has been pushed to the Fedora 18 stable repository.
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=876411
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- perl-Language-Expr-0.19-3.fc17 has been pushed to the Fedora 17 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=876411 Bug 876411 depends on bug 851734, which changed state.
Bug 851734 Summary: Review Request: perl-Regexp-Grammars - Add grammatical parsing features to perl regular expressions https://bugzilla.redhat.com/show_bug.cgi?id=851734
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ON_QA Resolution|ERRATA |---
https://bugzilla.redhat.com/show_bug.cgi?id=876411 Bug 876411 depends on bug 851734, which changed state.
Bug 851734 Summary: Review Request: perl-Regexp-Grammars - Add grammatical parsing features to perl regular expressions https://bugzilla.redhat.com/show_bug.cgi?id=851734
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla