[Bug 2141067] New: Review Request: rust-lopdf - Rust library for PDF document manipulation

https://bugzilla.redhat.com/show_bug.cgi?id=2141067

Bug ID: 2141067
           Summary: Review Request: rust-lopdf - Rust library for PDF
                    document manipulation
           Product: Fedora
           Version: rawhide
          Hardware: All
                OS: Linux
            Status: NEW
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]
  Target Milestone: ---
    Classification: Fedora

Spec URL: https://kalev.fedorapeople.org/rust-lopdf.spec
SRPM URL: https://kalev.fedorapeople.org/rust-lopdf-0.27.0-1.fc38.src.rpm
Description:
Rust library for PDF document manipulation.

Fedora Account System Username: kalev

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=93950868

[Bug 2141067] Review Request: rust-lopdf - Rust library for PDF document manipulation

https://bugzilla.redhat.com/show_bug.cgi?id=2141067

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]    |[e-mail]
                 CC|                            |[e-mail]
             Status|NEW                         |ASSIGNED

--- Comment #1 from Fabio Valentini  ---
Taking this review.

Initial comments:

- Please regenerate the spec file with rust2rpm v23.
- The built packages are not installable, due to the outdated optional
dependency on nom v6.

The compat package for nom v6 was retired over half a year ago. Projects should
be using nom v7 at this point.

Assuming librsvg2 doesn't depend on the non-default "nom" parser feature,
please drop the optional dependency on "nom" and the "nom_parser" feature (i.e.
remove both when calling "rust2rpm -sp").

[Bug 2141067] Review Request: rust-lopdf - Rust library for PDF document manipulation

https://bugzilla.redhat.com/show_bug.cgi?id=2141067

--- Comment #2 from Fabio Valentini  ---
I also assume you have packaged v0.27 on purpose? The latest version is
v0.29.0.

[Bug 2141067] Review Request: rust-lopdf - Rust library for PDF document manipulation

https://bugzilla.redhat.com/show_bug.cgi?id=2141067

--- Comment #3 from Kalev Lember  ---
Ah, good catch about the nom feature. Let me fix that. I didn't notice that the
subpackage is uninstallable because librsvg doesn't need it.

I packaged 0.27 because it was the latest when I looked into it :) I think it's
easiest for me to continue with 0.27 at this point because I already have
everything lined up to work with this version. I'll get it updated after I get
an initial librsvg build done in koji.

[Bug 2141067] Review Request: rust-lopdf - Rust library for PDF document manipulation

https://bugzilla.redhat.com/show_bug.cgi?id=2141067

--- Comment #4 from Kalev Lember  ---
OK, here's the updated spec file.

* Mon Nov 14 2022 Kalev Lember  0.27.0-3
- Add a downstream patch to drop nom and nom_parser features (#2141067)

* Mon Nov 14 2022 Kalev Lember  0.27.0-2
- Re-generate packaging with rust2rpm 23

Spec URL: https://kalev.fedorapeople.org/rust-lopdf.spec
SRPM URL: https://kalev.fedorapeople.org/rust-lopdf-0.27.0-3.fc38.src.rpm

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=94177017

[Bug 2141067] Review Request: rust-lopdf - Rust library for PDF document manipulation

https://bugzilla.redhat.com/show_bug.cgi?id=2141067

Fabio Valentini  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review+
             Status|ASSIGNED                    |POST

--- Comment #5 from Fabio Valentini  ---
> I'll get it updated after I get an initial librsvg build done in koji.

Take care - update from v0.27 to 0.29 is considered "breaking" by Cargo-SemVer,
and librsvg2 might specifically depend on 0.27.x.

But the package looks good to me now, thanks.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest (possible) version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

[Bug 2141067] Review Request: rust-lopdf - Rust library for PDF document manipulation

https://bugzilla.redhat.com/show_bug.cgi?id=2141067

--- Comment #6 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/rust-lopdf

[Bug 2141067] Review Request: rust-lopdf - Rust library for PDF document manipulation

https://bugzilla.redhat.com/show_bug.cgi?id=2141067

Kalev Lember  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|POST                        |CLOSED
         Resolution|---                         |RAWHIDE
   Fixed In Version|                            |rust-lopdf-0.27.0-3.fc37
                   |                            |rust-lopdf-0.27.0-3.fc38
        Last Closed|                            |2022-11-18 19:02:47

--- Comment #7 from Kalev Lember  ---
Thanks! Package imported and built.