https://bugzilla.redhat.com/show_bug.cgi?id=2056245
Bug ID: 2056245 Summary: Review Request: maui-mauikit-texteditor - MauiKit Text Editor components Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: thunderbirdtr@fedoraproject.org QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://pagure.io/Maukit-Packages/raw/main/f/mauikit-texteditor/mauikit-text... SRPM URL: https://pagure.io/Maukit-Packages/raw/main/f/mauikit-texteditor/maui-mauikit... Description: MauiKit Text Editor components Fedora Account System Username: thunderbirdtr
https://bugzilla.redhat.com/show_bug.cgi?id=2056245
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@redhat.com Doc Type|--- |If docs needed, set a value
--- Comment #1 from Jakub Kadlčík jkadlcik@redhat.com --- Hello Onuralp, thank you for the package.
Issues:
- Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: mauikit-texteditor.spec should be maui-mauikit-texteditor.spec See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_spec_file_naming
Can you please fix the spec name / package name?
Version: 2.1.1
There is already 2.2.0, can you please update?
%description %{summary}.
There is some usable text in the project README. Could be better but it's better than using %{summary}
MauiKitTextEditor is a set of QtQuick components providing basic text editing capabilities.
%files
Can you add `%doc README.md` as well?
https://bugzilla.redhat.com/show_bug.cgi?id=2056245
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |jkadlcik@redhat.com Status|NEW |ASSIGNED Flags| |fedora-review?
Product: Fedora Version: rawhide Component: Package Review
Jakub Kadlčík jkadlcik@redhat.com has canceled Package Review package-review@lists.fedoraproject.org's request for Jakub Kadlčík jkadlcik@redhat.com's needinfo: Bug 2056245: Review Request: maui-mauikit-texteditor - MauiKit Text Editor components https://bugzilla.redhat.com/show_bug.cgi?id=2056245
--- Comment #3 from Jakub Kadlčík jkadlcik@redhat.com --- I am interested in reviewing this ticket but there is no response from the contributor.
https://bugzilla.redhat.com/show_bug.cgi?id=2056245
Jakub Kadlčík jkadlcik@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jkadlcik@redhat.c | |om) |
--- Comment #3 from Jakub Kadlčík jkadlcik@redhat.com --- I am interested in reviewing this ticket but there is no response from the contributor.
https://bugzilla.redhat.com/show_bug.cgi?id=2056245
Troy Dawson tdawson@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tdawson@redhat.com Resolution|--- |DEFERRED Status|ASSIGNED |CLOSED Last Closed| |2024-09-20 15:33:52
--- Comment #4 from Troy Dawson tdawson@redhat.com --- I am going to close this review request. It has been a few years, the code has changed, and there is a different packager that would like to package this.
Thank you Onuralp for your initial work on this package. Thank you Jakub for your initial review.
package-review@lists.fedoraproject.org