[Bug 1647311] New: Review Request: perl-Plack-Middleware-Session - Middleware for session management

https://bugzilla.redhat.com/show_bug.cgi?id=1647311

Bug ID: 1647311
           Summary: Review Request: perl-Plack-Middleware-Session -
                    Middleware for session management
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Plack-Middleware-Session/perl-...
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Plack-Middleware-Session/perl-...
Description:
This is a Plack Middleware component for session management. By default it
will use cookies to keep session state and store data in memory. This
distribution also comes with other state and store solutions.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

[Bug 1647311] Review Request: perl-Plack-Middleware-Session - Middleware for session management

https://bugzilla.redhat.com/show_bug.cgi?id=1647311

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 1647311] Review Request: perl-Plack-Middleware-Session - Middleware for session management

https://bugzilla.redhat.com/show_bug.cgi?id=1647311

Jitka Plesnikova  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are ok
FIX: Please remove duplicate BR 'perl(Cookie::Baker)'.
     'perl(Test::Pod)' is used only for release testing, so it can be
     removed.

$ rpm -qp --requires perl-Plack-Middleware-Session-0.30-1.fc30.noarch.rpm |
sort | uniq -c
      1 perl(Cookie::Baker)
      1 perl(Digest::HMAC_SHA1)
      1 perl(Digest::SHA1)
      1 perl(MIME::Base64)
      1 perl(:MODULE_COMPAT_5.28.0)
      1 perl(parent)
      1 perl(Plack::Middleware)
      1 perl(Plack::Middleware::Session)
      1 perl(Plack::Request)
      1 perl(Plack::Session::Cleanup)
      1 perl(Plack::Session::State)
      1 perl(Plack::Session::State::Cookie)
      1 perl(Plack::Session::Store)
      1 perl(Plack::Util)
      1 perl(Plack::Util::Accessor)
      1 perl(Scalar::Util)
      1 perl(Storable)
      1 perl(strict)
      1 perl(Time::HiRes)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Plack-Middleware-Session-0.30-1.fc30.noarch.rpm |
sort | uniq -c
      1 perl(Plack::Middleware::Session) = 0.30
      1 perl-Plack-Middleware-Session = 0.30-1.fc30
      1 perl(Plack::Middleware::Session::Cookie)
      1 perl(Plack::Session) = 0.30
      1 perl(Plack::Session::Cleanup) = 0.30
      1 perl(Plack::Session::State) = 0.30
      1 perl(Plack::Session::State::Cookie) = 0.30
      1 perl(Plack::Session::Store) = 0.30
      1 perl(Plack::Session::Store::Cache) = 0.30
      1 perl(Plack::Session::Store::DBI) = 0.30
      1 perl(Plack::Session::Store::File) = 0.30
      1 perl(Plack::Session::Store::Null) = 0.30
Binary provides are Ok.

$ rpmlint ./perl-Plack-Middleware-Session*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please correct 'FIX' issue.

Otherwise the package looks good.
Approved

[Bug 1647311] Review Request: perl-Plack-Middleware-Session - Middleware for session management

https://bugzilla.redhat.com/show_bug.cgi?id=1647311

--- Comment #2 from Emmanuel Seyman  ---
(In reply to Jitka Plesnikova from comment #1)
> FIX: Please remove duplicate BR 'perl(Cookie::Baker)'.

Oops. Done.
>  'perl(Test::Pod)' is used only for release testing, so it can be
>  removed.

I decided to enable release tests instead.
> Please correct 'FIX' issue.

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Plack-Middleware-Session/perl-...
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Plack-Middleware-Session/perl-...
> Otherwise the package looks good.
> Approved

Thank you, Jikta. I've requested the repo.

[Bug 1647311] Review Request: perl-Plack-Middleware-Session - Middleware for session management

https://bugzilla.redhat.com/show_bug.cgi?id=1647311

--- Comment #3 from Gwyn Ciesla  ---
(fedscm-admin):  The Pagure repository was created at
https://src.fedoraproject.org/rpms/perl-Plack-Middleware-Session

[Bug 1647311] Review Request: perl-Plack-Middleware-Session - Middleware for session management

https://bugzilla.redhat.com/show_bug.cgi?id=1647311

Emmanuel Seyman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |CURRENTRELEASE
        Last Closed|                            |2018-11-18 02:22:22

--- Comment #4 from Emmanuel Seyman  ---
This package has been pushed to stable. Closing.