Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=429414
Summary: Review Request: Scapy - Interactive packet manipulation tool and network scanner Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: dgoodwin@dangerouslyinc.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://dgoodwin.fedorapeople.org/scapy.spec SRPM URL: http://dgoodwin.fedorapeople.org/scapy-1.1.1-1.fc8.src.rpm
Description:
Scapy is a powerful interactive packet manipulation program built on top of the Python interpreter. It can be used to forge or decode packets of a wide number of protocols, send them over the wire, capture them, match requests and replies, and much more.
rpmlint output:
(dev@kramer)[~/rpmbuild] % rpmlint SRPMS/scapy-1.1.1-1.fc8.src.rpm (dev@kramer)[~/rpmbuild] % rpmlint RPMS/noarch/scapy-1.1.1-1.fc8.noarch.rpm scapy.noarch: W: file-not-utf8 /usr/share/doc/scapy-1.1.1/changelog.txt (dev@kramer)[~/rpmbuild] %
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Scapy - Interactive packet manipulation tool and network scanner
https://bugzilla.redhat.com/show_bug.cgi?id=429414
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |panemade@gmail.com Status|NEW |ASSIGNED Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Scapy - Interactive packet manipulation tool and network scanner
https://bugzilla.redhat.com/show_bug.cgi?id=429414
------- Additional Comments From panemade@gmail.com 2008-01-20 23:52 EST ------- 1)I don't think you should include changelog.txt. Remove it from installing. 2) Because of python dependency missing on rpm-build command, following error occurred in build.log. So for current scenario, good to add python as BR.
/usr/lib/rpm/pythondeps.sh: line 8: python: command not found
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Scapy - Interactive packet manipulation tool and network scanner
https://bugzilla.redhat.com/show_bug.cgi?id=429414
------- Additional Comments From dgoodwin@dangerouslyinc.com 2008-01-21 08:35 EST ------- Spec URL: http://dgoodwin.fedorapeople.org/scapy.spec SRPM URL: http://dgoodwin.fedorapeople.org/scapy-1.1.1-2.fc8.src.rpm
Added to spec file:
BuildRequires: python >= 2.3
Removed changelog.txt:
(root@kramer)[~dev/rpmbuild/RPMS/noarch] # ls /usr/share/doc/scapy-1.1.1/ AUTHORS changelog COPYING README (root@kramer)[~dev/rpmbuild/RPMS/noarch] #
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Scapy - Interactive packet manipulation tool and network scanner
https://bugzilla.redhat.com/show_bug.cgi?id=429414
------- Additional Comments From panemade@gmail.com 2008-01-21 09:27 EST ------- you need to either use macros or not. e.g. for install you used %{__install} but same is not valid for rm. also don't mix style of macros
see http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f56...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Scapy - Interactive packet manipulation tool and network scanner
https://bugzilla.redhat.com/show_bug.cgi?id=429414
------- Additional Comments From dgoodwin@dangerouslyinc.com 2008-01-21 11:47 EST ------- Spec URL: http://dgoodwin.fedorapeople.org/scapy.spec SRPM URL: http://dgoodwin.fedorapeople.org/scapy-1.1.1-3.fc8.src.rpm
Replaced usage of $RPM_BUILD_ROOT with %{buildroot}.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Scapy - Interactive packet manipulation tool and network scanner
https://bugzilla.redhat.com/show_bug.cgi?id=429414
------- Additional Comments From panemade@gmail.com 2008-01-22 00:45 EST ------- any reason for not using macro for rm command? you used %{__install} then you should also use %{__rm} which will look like then %{__rm} -rf %{buildroot}
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Scapy - Interactive packet manipulation tool and network scanner
https://bugzilla.redhat.com/show_bug.cgi?id=429414
panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From panemade@gmail.com 2008-01-22 00:52 EST ------- Review: + package builds in mock (rawhide i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 8ac720a1bea4304797c713ef1ed063f1 scapy-1.1.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate.
SHOULD: take care of above comment while importing this package in CVS.
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: Scapy - Interactive packet manipulation tool and network scanner
https://bugzilla.redhat.com/show_bug.cgi?id=429414
dgoodwin@dangerouslyinc.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From dgoodwin@dangerouslyinc.com 2008-01-22 11:35 EST ------- New Package CVS Request ======================= Package Name: scapy Short Description: Interactive packet manipulation tool and network scanner Owners: dgoodwin Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scapy - Interactive packet manipulation tool and network scanner
https://bugzilla.redhat.com/show_bug.cgi?id=429414
kevin@tummy.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: Scapy - |Review Request: scapy - |Interactive packet |Interactive packet |manipulation tool and |manipulation tool and |network scanner |network scanner Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin@tummy.com 2008-01-22 18:41 EST ------- cvs done.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: scapy - Interactive packet manipulation tool and network scanner
https://bugzilla.redhat.com/show_bug.cgi?id=429414
dgoodwin@dangerouslyinc.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From dgoodwin@dangerouslyinc.com 2008-01-23 09:11 EST ------- Imported into cvs, built successfully and pushed to F-7 and F-8.
Closing as NEXTRELEASE.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=429414
Devan Goodwin dgoodwin@rm-rf.ca changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs?
--- Comment #10 from Devan Goodwin dgoodwin@rm-rf.ca 2011-06-06 08:11:03 EDT --- Package Change Request ====================== Package Name: scapy New Branches: EL-5 EL-6 Owners: dgoodwin tjikkun
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=429414
--- Comment #11 from Jon Ciesla limb@jcomserv.net 2011-06-06 08:27:09 EDT --- Git done (by process-git-requests).
package-review@lists.fedoraproject.org