[Bug 1187873] New: Review Request: perl-Palm-PDB - Parse Palm database files

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187873

Bug ID: 1187873
           Summary: Review Request: perl-Palm-PDB - Parse Palm database
                    files
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Palm-PDB/perl-Palm-PDB.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Palm-PDB/perl-Palm-PDB-1.016-1...

Description:
The Palm::PDB module provides a framework for reading and writing database
files for use on PalmOS devices such as the PalmPilot. It can read and
write both Palm Database (.pdb) and Palm Resource (.prc) files.

Fedora Account System Username: eseyman

Rpmlint output:
perl-Palm-PDB.src: W: spelling-error %description -l en_US prc -> PRC, pr, pic
1 packages and 1 specfiles checked; 0 errors, 1 warnings.

[Bug 1187873] Review Request: perl-Palm-PDB - Parse Palm database files

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187873

David Dick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review?

[Bug 1187873] Review Request: perl-Palm-PDB - Parse Palm database files

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187873

David Dick  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #1 from David Dick  ---
License is correct.

examples can be included in %doc

include the following BRs

perl(warnings)
perl(strict)

rpmlint is fine (ignoring incorrect spelling warnings)

package builds fine locally (koji seems to be having some SSL certificate
issues at the moment)

if you are building only for F21,

"find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ;" looks like it
can be replaced with NO_PACKLIST=1 as a Makefile.PL argument.

otherwise you'll need to adjust the %license key?

Package APPROVED

[Bug 1187873] Review Request: perl-Palm-PDB - Parse Palm database files

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187873

Emmanuel Seyman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-cvs?

--- Comment #2 from Emmanuel Seyman  ---
(In reply to David Dick from comment #1)
> include the following BRs
>
> perl(warnings)
> perl(strict)

Done.
> if you are building only for F21,

Rawhide only, actually.
Fedora has the package perl-p5-Palm. A while back, the CPAN distribution was:

a) renamed to simply Palm
b) split into Palm and Palm-PDB
c) updated

So the plan is to package Palm-PDB (this bug) in rawhide and then rename
perl-p5-Palm to perl-Palm (which will require another review).
> "find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ;" looks like
> it can be replaced with NO_PACKLIST=1 as a Makefile.PL argument.

Done

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Palm-PDB/perl-Palm-PDB.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Palm-PDB/perl-Palm-PDB-1.016-2...

Thanks for the review, David.
Requesting SCM

New Package SCM Request
=======================
Package Name: perl-Palm-PDB
Short Description: Parse Palm database files
Upstream URL: http://search.cpan.org/dist/Palm-PDB//pkgname
Owners: eseyman
Branches:
InitialCC: perl-sig

[Bug 1187873] Review Request: perl-Palm-PDB - Parse Palm database files

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187873

Jon Ciesla  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-cvs?                 |fedora-cvs+

[Bug 1187873] Review Request: perl-Palm-PDB - Parse Palm database files

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187873

--- Comment #3 from Jon Ciesla  ---
Git done (by process-git-requests).

[Bug 1187873] Review Request: perl-Palm-PDB - Parse Palm database files

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187873

Emmanuel Seyman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2015-02-01 15:47:54

--- Comment #4 from Emmanuel Seyman  ---
Imported and built for rawhide.
Thanks for the git repo, Jon.