https://bugzilla.redhat.com/show_bug.cgi?id=2238116
Bug ID: 2238116 Summary: Review Request: rust-enum_dispatch - Near drop-in replacement for dynamic-dispatched method calls with up to 10x the speed Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: maxwell@gtmx.me QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/gotmax23/pydanticv2/fedor... SRPM URL: https://download.copr.fedorainfracloud.org/results/gotmax23/pydanticv2/fedor... Description: Near drop-in replacement for dynamic-dispatched method calls with up to 10x the speed. Fedora Account System Username gotmax23
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
Maxwell G maxwell@gtmx.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Depends On| |2238115
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2238115 [Bug 2238115] Review Request: rust-enum_derive - Macros for deriving additional functionality for enums
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
Maxwell G maxwell@gtmx.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2238117
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2238117 [Bug 2238117] Review Request: python-pydantic-core - Core validation logic for pydantic written in rust
https://bugzilla.redhat.com/show_bug.cgi?id=2238116 Bug 2238116 depends on bug 2238115, which changed state.
Bug 2238115 Summary: Review Request: rust-enum_derive - Macros for deriving additional functionality for enums https://bugzilla.redhat.com/show_bug.cgi?id=2238115
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
--- Comment #1 from Maxwell G maxwell@gtmx.me --- Spec URL: https://download.copr.fedorainfracloud.org/results/gotmax23/pydanticv2/fedor... SRPM URL: https://download.copr.fedorainfracloud.org/results/gotmax23/pydanticv2/fedor...
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Flags| |fedora-review+ Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com
--- Comment #2 from Fabio Valentini decathorpe@gmail.com --- Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide ! test suite is run and all unit tests pass (disabled with explanation) ! latest version of the crate is packaged (v0.3.11 vs. v0.3.12) - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer (should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
===
Upstream has released v0.3.12 two months ago, is there a reason why you've packaged v0.3.11? If not, please update to the latest version ASAP (before or after importing does not matter to me).
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
--- Comment #3 from Maxwell G maxwell@gtmx.me --- Thanks for the review!
Upstream has released v0.3.12 two months ago, is there a reason why you've packaged v0.3.11?
No, I'll fix on import.
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-enum_dispatch
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-cb5dcec7b7 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-cb5dcec7b7
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2023-09-09 19:55:35
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-cb5dcec7b7 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-64f6f69cf9 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-64f6f69cf9
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8ad34e7f1b has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8ad34e7f1b
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-a792d0a666 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-a792d0a666
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-a792d0a666 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-a792d0a666 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a792d0a666
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-64f6f69cf9 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-64f6f69cf9 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-64f6f69cf9
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8ad34e7f1b has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8ad34e7f1b *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8ad34e7f1b
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
Maxwell G maxwell@gtmx.me changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On|2238115 |
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2238115 [Bug 2238115] Review Request: rust-enum_derive - Macros for deriving additional functionality for enums
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-64f6f69cf9 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-8ad34e7f1b has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2238116
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-a792d0a666 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org