https://bugzilla.redhat.com/show_bug.cgi?id=1803303
Bug ID: 1803303 Summary: Review Request: golang-github-alecaivazis-survey - A golang library for building interactive prompts Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: joe@solidadmin.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/jdoss/github/fedora-31-x8... SRPM URL: https://download.copr.fedorainfracloud.org/results/jdoss/github/fedora-31-x8...
Description: A golang library for building interactive prompts with full support for windows and posix terminals
Fedora Account System Username: jdoss
https://bugzilla.redhat.com/show_bug.cgi?id=1803303
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zebob.m@gmail.com Assignee|nobody@fedoraproject.org |zebob.m@gmail.com Doc Type|--- |If docs needed, set a value Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin zebob.m@gmail.com --- - Why not packaging 2.0.5?
- tag is not needed here, only:
Version: 2.0.0
- summary is too long, need to be below 80 characters:
Summary: Build interactive prompts with full support for windows and posix terminals
- License ok - Builds in mock - No rpmlint errors - Tests are ok - Conforms to Packaging Guidelines
Package approved. Please package the latest version and fix the above issues.
https://bugzilla.redhat.com/show_bug.cgi?id=1803303
Richard Shaw hobbes1069@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1803302
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1803302 [Bug 1803302] Review Request: github-cli - The GitHub CLI
https://bugzilla.redhat.com/show_bug.cgi?id=1803303
--- Comment #2 from Joe Doss joe@solidadmin.com --- - Version updated. - Tag removed. - Summary trimmed down.
https://download.copr.fedorainfracloud.org/results/jdoss/github/fedora-31-x8... https://download.copr.fedorainfracloud.org/results/jdoss/github/fedora-31-x8...
https://bugzilla.redhat.com/show_bug.cgi?id=1803303
Joe Doss joe@solidadmin.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |NEW
--- Comment #3 from Joe Doss joe@solidadmin.com --- Updated version to 2.1.1
https://download.copr.fedorainfracloud.org/results/jdoss/github-cli/fedora-3... https://download.copr.fedorainfracloud.org/results/jdoss/github-cli/fedora-3...
https://bugzilla.redhat.com/show_bug.cgi?id=1803303
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |ppisar@redhat.com
--- Comment #4 from Petr Pisar ppisar@redhat.com --- Joe, the package was approved in #comment 1. You can go on with adding it into Fedora.
https://bugzilla.redhat.com/show_bug.cgi?id=1803303
--- Comment #5 from Joe Doss joe@solidadmin.com --- fedpkg request-repo golang-github-alecaivazis-survey 1803303 Could not execute request_repo: The Bugzilla bug's review was approved over 60 days ago
https://bugzilla.redhat.com/show_bug.cgi?id=1803303
--- Comment #6 from Petr Pisar ppisar@redhat.com --- Either open a new request, or reset this one the original state (NEW state, default assignee, unset fedora-review flag). Whatever suits you better.
https://bugzilla.redhat.com/show_bug.cgi?id=1803303
--- Comment #7 from Joe Doss joe@solidadmin.com --- Petr,
Can you reset the fedora-review+ flag for me? I did this and the request got rejected.
https://pagure.io/releng/fedora-scm-requests/issue/30141
https://bugzilla.redhat.com/show_bug.cgi?id=1803303
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|zebob.m@gmail.com |nobody@fedoraproject.org Flags|fedora-review+ |
--- Comment #8 from Petr Pisar ppisar@redhat.com --- I reset this review request to initial state as the package must be reviewed again because the previous review expired.
https://bugzilla.redhat.com/show_bug.cgi?id=1803303
Ben Cotton bcotton@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |bcotton@redhat.com Assignee|nobody@fedoraproject.org |bcotton@redhat.com Flags| |needinfo?(joe@solidadmin.co | |m)
--- Comment #9 from Ben Cotton bcotton@redhat.com --- Joe, if you can provide updated locations for the spec an srpm, I'll give it a re-review.
https://bugzilla.redhat.com/show_bug.cgi?id=1803303
Ben Cotton bcotton@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(joe@solidadmin.co | |m) |
--- Comment #10 from Ben Cotton bcotton@redhat.com --- Nevermind. I see them in comment 3. I'll do the review now.
https://bugzilla.redhat.com/show_bug.cgi?id=1803303
Ben Cotton bcotton@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(joe@solidadmin.co | |m)
--- Comment #11 from Ben Cotton bcotton@redhat.com --- The binary rpm does not build from source due to unmet dependencies:
No matching package to install: 'golang(github.com/Netflix/go-expect)' No matching package to install: 'golang(github.com/hinshun/vt10x)'
That doesn't look like a new change, am I missing something?
https://bugzilla.redhat.com/show_bug.cgi?id=1803303
Joe Doss joe@solidadmin.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(joe@solidadmin.co | |m) |
--- Comment #12 from Joe Doss joe@solidadmin.com --- These other dependency packages also expired and I just got the SCM request resubmitted so I can move forward on them. Once I get them in rawhide you can give this a try.
https://bugzilla.redhat.com/show_bug.cgi?id=1803309 https://pagure.io/releng/fedora-scm-requests/issue/30228
https://bugzilla.redhat.com/show_bug.cgi?id=1803312 https://pagure.io/releng/fedora-scm-requests/issue/30229
https://bugzilla.redhat.com/show_bug.cgi?id=1803303
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|bcotton@redhat.com |zebob.m@gmail.com Flags| |fedora-review+
--- Comment #13 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Flag reset.
https://bugzilla.redhat.com/show_bug.cgi?id=1803303
Joe Doss joe@solidadmin.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |NOTABUG Status|ASSIGNED |CLOSED Last Closed| |2021-09-30 20:20:26
--- Comment #14 from Joe Doss joe@solidadmin.com --- Closing on request https://bugzilla.redhat.com/show_bug.cgi?id=1803302#c16
package-review@lists.fedoraproject.org