https://bugzilla.redhat.com/show_bug.cgi?id=1666293
Bug ID: 1666293 Summary: Review Request: python-pastel - Bring colors to your terminal Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: decathorpe@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://decathorpe.fedorapeople.org/packages/python-pastel.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/python-pastel-0.1.0-1.fc29.src....
Description: Pastel is a simple library to help you colorize strings in your terminal.
It comes bundled with predefined styles:
- info: green - comment: yellow - question: black on cyan - error: white on red
Features:
- Use predefined styles or add you own. - Disable colors all together by calling with_colors(False). - Automatically disables colors if the output is not a TTY. - Used in cleo.
Fedora Account System Username: decathorpe
koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=32043345
https://bugzilla.redhat.com/show_bug.cgi?id=1666293
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1666306
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1666306 [Bug 1666306] Review Request: python-clikit - Utilities to build beautiful and testable CLIs
https://bugzilla.redhat.com/show_bug.cgi?id=1666293
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1666311
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1666311 [Bug 1666311] Review Request: python-cleo - Create beautiful and testable command-line interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1666293
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |projects.rg@smart.ms
--- Comment #1 from Raphael Groner projects.rg@smart.ms --- Are you interested in a review swap? Maybe you could look into bug #1659777.
https://bugzilla.redhat.com/show_bug.cgi?id=1666293
Elliott Sales de Andrade quantum.analyst@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |quantum.analyst@gmail.com
--- Comment #2 from Elliott Sales de Andrade quantum.analyst@gmail.com --- The link to the SRPM here is broken.
https://bugzilla.redhat.com/show_bug.cgi?id=1666293
--- Comment #3 from Elliott Sales de Andrade quantum.analyst@gmail.com --- Oops, ignore that comment; wrong bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1666293
--- Comment #4 from Raphael Groner projects.rg@smart.ms --- Can you please add your full name into FAS?
https://bugzilla.redhat.com/show_bug.cgi?id=1666293
--- Comment #5 from Raphael Groner projects.rg@smart.ms --- Review swap with bug #1469767, maybe? :-)
https://bugzilla.redhat.com/show_bug.cgi?id=1666293
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ngompa13@gmail.com Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review?
--- Comment #6 from Neal Gompa ngompa13@gmail.com --- Taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=1666293
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1668387
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1668387 [Bug 1668387] Review Request: poetry - Python dependency management and packaging made easy
https://bugzilla.redhat.com/show_bug.cgi?id=1666293
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- Review notes:
[x] Follows Fedora Packaging Guidelines [x] Follows Fedora Python Packaging Guidelines [x] Does not include Python 2 subpackage [x] Package is named per guidelines [x] Package builds and installs correctly [x] Package licensing is correct and documented correctly
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1666293
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review+ |fedora-review?
--- Comment #8 from Neal Gompa ngompa13@gmail.com ---
[x] Package licensing is correct and documented correctly
Whoops, I did this for the wrong package here. This is wrong.
The licensing is actually missing from the upstream GitHub repo and in the PyPI tarball release. Please contact upstream to fix it.
https://bugzilla.redhat.com/show_bug.cgi?id=1666293
--- Comment #9 from Fabio Valentini decathorpe@gmail.com --- Reported the missing LICENSE / COPYING file upstream: https://github.com/sdispater/pastel/issues/5
https://bugzilla.redhat.com/show_bug.cgi?id=1666293
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed| |2019-05-12 14:19:06
--- Comment #10 from Fabio Valentini decathorpe@gmail.com --- I officially give up, as the upstream developer has not reacted at all to any of of the relevant, open bug reports blocking this package for months.
https://github.com/sdispater/poetry/issues/866 https://github.com/sdispater/cachy/issues/2 https://github.com/sdispater/pastel/issues/5 https://github.com/toastdriven/pylev/issues/11
package-review@lists.fedoraproject.org