[Bug 2350125] New: Review Request: python-onnxconverter-common - Common utilities for ONNX converters
https://bugzilla.redhat.com/show_bug.cgi?id=2350125
Bug ID: 2350125 Summary: Review Request: python-onnxconverter-common - Common utilities for ONNX converters Product: Fedora Version: rawhide OS: Linux Status: NEW Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: pbrobinson@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
SPEC: https://pbrobinson.fedorapeople.org/python-onnxconverter-common.spec SRPM: https://pbrobinson.fedorapeople.org/python-onnxconverter-common-1.13.0-1.fc4...
description: The onnxconverter-common package provides common functions and utilities for use in converters from various AI frameworks to ONNX. It also enables the different converters to work together to convert a model from mixed frameworks, like a scikit-learn pipeline embedding a xgboost model.
koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=129851331
FAS: pbrobinson
Reproducible: Always
https://bugzilla.redhat.com/show_bug.cgi?id=2350125
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://github.com/microsof | |t/onnxconverter-common/
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8730440 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2350125
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2350131
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2350131 [Bug 2350131] Review Request: python-onnxmltools - ONNXMLTools enables conversion of models to ONNX
https://bugzilla.redhat.com/show_bug.cgi?id=2350125
Benson Muite benson_muite@emailplus.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@fedoraproject.org |benson_muite@emailplus.org CC| |benson_muite@emailplus.org
--- Comment #2 from Benson Muite benson_muite@emailplus.org ---
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* GNU Lesser General Public License". 33 files have unknown license. Detailed output of licensecheck in /home/fedora- packaging/reviews/python-onnx-converter/2350125-python-onnxconverter- common/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13, /usr/lib/python3.13/site-packages [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1773 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/microsoft/onnxconverter- common//archive/1.13.0.tar.gz#/onnxconverter-common-1.13.0.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: python-onnxconverter-common-1.13.0-1.fc43.noarch.rpm python-onnxconverter-common-1.13.0-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp3j6le70q')] checks: 32, packages: 2
python-onnxconverter-common.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-onnxconverter-common/README.md python-onnxconverter-common.noarch: E: spelling-error ('scikit', '%description -l en_US scikit -> sci kit, sci-kit, kitsch') python-onnxconverter-common.noarch: E: spelling-error ('xgboost', '%description -l en_US xgboost -> boost') python-onnxconverter-common.src: E: spelling-error ('scikit', '%description -l en_US scikit -> sci kit, sci-kit, kitsch') python-onnxconverter-common.src: E: spelling-error ('xgboost', '%description -l en_US xgboost -> boost') python-onnxconverter-common.spec: W: no-%check-section 2 packages and 0 specfiles checked; 4 errors, 2 warnings, 7 filtered, 4 badness; has taken 2.4 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1
python-onnxconverter-common.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/python-onnxconverter-common/README.md python-onnxconverter-common.noarch: E: spelling-error ('scikit', '%description -l en_US scikit -> sci kit, sci-kit, kitsch') python-onnxconverter-common.noarch: E: spelling-error ('xgboost', '%description -l en_US xgboost -> boost') 1 packages and 0 specfiles checked; 2 errors, 1 warnings, 3 filtered, 2 badness; has taken 0.2 s
Requires -------- python-onnxconverter-common (rpmlib, GLIBC filtered): python(abi) python3.13dist(numpy) python3.13dist(onnx) python3.13dist(packaging) python3.13dist(protobuf)
Provides -------- python-onnxconverter-common: python-onnxconverter-common python3.13dist(onnxconverter-common) python3dist(onnxconverter-common)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2350125 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: Haskell, fonts, Java, Ocaml, C/C++, Perl, PHP, R, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Comments: a) Please add a check section, at minimum %check %pyproject_check_import Though ideally %check %pyproject_check_import %pytest b) There is a notice in the software repository:
NOTICES AND INFORMATION Do Not Translate or Localize
This software incorporates material from third parties. Microsoft makes certain open source code available at https://3rdpartysource.microsoft.com, or you may send a check or money order for US $5.00, including the product name, the open source component name, platform, and version number, to:
Source Code Compliance Team Microsoft Corporation One Microsoft Way Redmond, WA 98052 USA
Notwithstanding any other terms, you may reverse engineer this software to the extent required to debug changes to any libraries licensed under the GNU Lesser General Public License.
It is however unclear what included components this refers to.
c) Consider changing Source0: %url/archive/%{version}.tar.gz#/%{pypi_name}-%{version}.tar.gz to Source0: %url/archive/v%{version}/%{pypi_name}-%{version}.tar.gz
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com