[Bug 1157213] New: Review Request: brutalchess - Impressive 3D chess game - package-review

List overview All Threads
Download

newer

[Bug 1157213] New: Review Request: brutalchess - Impressive 3D chess game

older

[Bug 475603] Review Request:...

[Bug 1155778] New: Review Request:...

Red Hat Bugzilla

26 Oct 2014 26 Oct '14

4:59 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Bug ID: 1157213 Summary: Review Request: brutalchess - Impressive 3D chess game Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: projects.rg@smart.ms QA Contact: extras-qa@fedoraproject.org CC: chrisdersch@gmail.com, extras-qa@fedoraproject.org, fedora-package-review@redhat.com, fedora@famillecollet.com, micah.roth@ucla.edu, package-review@lists.fedoraproject.org, projects.rg@smart.ms, theo148@gmail.com, timur.kristof@gmail.com Depends On: 701812 Blocks: 201449 (FE-DEADREVIEW)

Spec URL: https://raphgro.fedorapeople.org/review/brutalchess/brutalchess.spec SRPM URL: https://raphgro.fedorapeople.org/review/brutalchess/brutalchess-0.5.2-1.alph... Description: Chess game based on OpenGL Fedora Account System Username: raphgro

There are several open issues, marked with ##FIXME in spec file. All those SHOULD be fixed if there is time but are not blockers for package approval.

+++ This bug was initially created as a clone of Bug #701812 +++

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. https://bugzilla.redhat.com/show_bug.cgi?id=701812 [Bug 701812] Review Request: brutalchess - Impressive 3D chess game

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

26 Oct 26 Oct

5 p.m.

New subject: [Bug 1157213] Review Request: brutalchess - Impressive 3D chess game

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Raphael Groner projects.rg@smart.ms changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|201449 (FE-DEADREVIEW) |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:01 p.m.

New subject: [Bug 1157213] Review Request: brutalchess - Impressive 3D chess game

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Raphael Groner projects.rg@smart.ms changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |201449 (FE-DEADREVIEW)

--- Comment #1 from Raphael Groner projects.rg@smart.ms --- *** Bug 701812 has been marked as a duplicate of this bug. ***

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

27 Oct 27 Oct

1:17 a.m.

New subject: [Bug 1157213] Review Request: brutalchess - Impressive 3D chess game

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Thomas Spura tomspur@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Depends On|701812 |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=701812 [Bug 701812] Review Request: brutalchess - Impressive 3D chess game

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12 Dec 12 Dec

2:05 a.m.

New subject: [Bug 1157213] Review Request: brutalchess - Impressive 3D chess game

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Rex Dieter rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Whiteboard|NotReady AwaitingSubmitter |

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:06 a.m.

New subject: [Bug 1157213] Review Request: brutalchess - Impressive 3D chess game

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Rex Dieter rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks|201449 (FE-DEADREVIEW) |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:05 a.m.

New subject: [Bug 1157213] Review Request: brutalchess - Impressive 3D chess game

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Rex Dieter rdieter@math.unl.edu changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:05 a.m.

New subject: [Bug 1157213] Review Request: brutalchess - Impressive 3D chess game

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Rex Dieter rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |rdieter@math.unl.edu

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:26 a.m.

New subject: [Bug 1157213] Review Request: brutalchess - Impressive 3D chess game

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

--- Comment #2 from Raphael Groner projects.rg@smart.ms --- Updated broken BR without any release bump.

rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8351560

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:57 a.m.

New subject: [Bug 1157213] Review Request: brutalchess - Impressive 3D chess game

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

--- Comment #3 from Raphael Groner projects.rg@smart.ms --- Release #2.

Spec URL: https://raphgro.fedorapeople.org/review/brutalchess/brutalchess.spec SRPM URL: https://raphgro.fedorapeople.org/review/brutalchess/brutalchess-0.5.2-2.alph...

rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8352679

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:31 p.m.

New subject: [Bug 1157213] Review Request: brutalchess - Impressive 3D chess game

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

--- Comment #4 from Rex Dieter rdieter@math.unl.edu --- naming: NOT ok

1. MUST fix, pkg Summary doesn't match bugzilla Summary Summary: Impressive 3D chess game vs Summary: Chess game with full 3D graphics

I'd suggest simpler: Summary: Chess game with 3D graphics (I don't think including "full" there adds value)

licensing: ok

sources: ok, verified content to be identical to upstream + run through pruning script.

macros: NOT ok 2. MUST fix commented macros #%global buildtex 0 doesn't work as you expect, macros in comments are still evaluated (yes wierd, but that's how rpm works). Better: #global buildtex 0

scriptlets: n/a

dir/file ownership: NOT ok, 3. package MUST own %{_datadir}/%{name} dir you can either add %dir %{_datadir}/%{name}/ or replace all of: %{_datadir}/%{name}/art/ %{_datadir}/%{name}/models/ %{_datadir}/%{name}/fonts/ with just: %{_datadir}/%{name}/

Please fix items 1-3, and things are looking good.

additional comments: * I can help fix tex/font issues post-review, it's just a matter of missing BuildRequires

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

10:44 p.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Raphael Groner projects.rg@smart.ms changed:

--- Comment #5 from Raphael Groner projects.rg@smart.ms ---

...

additional comments:

I can help fix tex/font issues post-review, it's just a matter of missing

Yes, that would be so kind of you. I am totally lost within tex world, as it turns out.

The other things will be fixed soon, stay tuned for an upcoming new release.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:46 p.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

--- Comment #6 from Raphael Groner projects.rg@smart.ms --- Release #3.

Spec URL: https://raphgro.fedorapeople.org/review/brutalchess/brutalchess.spec SRPM URL: https://raphgro.fedorapeople.org/review/brutalchess/brutalchess-0.5.2-3.alph...

rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8362131

Thanks for the review!

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

11:56 p.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Rex Dieter rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+

--- Comment #7 from Rex Dieter rdieter@math.unl.edu --- Looks good, APPROVED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

13 Dec 13 Dec

5:33 a.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Raphael Groner projects.rg@smart.ms changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #8 from Raphael Groner projects.rg@smart.ms --- New Package SCM Request ======================= Package Name: brutalchess Short Description: Chess game with impressive 3D graphics Upstream URL: http://sf.net/projects/brutalchess Owners: raphgro Branches: f21 InitialCC: rdieter lupinix

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

15 Dec 15 Dec

8:37 p.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Rex Dieter rdieter@math.unl.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- Alias| |brutalchess

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:40 p.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Raphael Groner projects.rg@smart.ms changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:22 p.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:22 p.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

16 Dec 16 Dec

12:02 a.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:02 a.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

--- Comment #10 from Fedora Update System updates@fedoraproject.org --- brutalchess-0.5.2-3.alpha.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/brutalchess-0.5.2-3.alpha.fc21

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:11 a.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Christian Dersch lupinix@mailbox.org changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |lupinix@mailbox.org

--- Comment #11 from Christian Dersch lupinix@mailbox.org --- Release tag doesn't match guidelines, alpha is a pre-release and requires 0.x instead of x: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3:57 a.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Raphael Groner projects.rg@smart.ms changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |POST

--- Comment #12 from Raphael Groner projects.rg@smart.ms --- (In reply to Fedora Update System from comment #10)

...

brutalchess-0.5.2-3.alpha.fc21 has been submitted as an update for Fedora 21.

Deleted because of wrong Release tag. We are investigating to fix it and a valid package will follow soon.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:01 a.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Raphael Groner projects.rg@smart.ms changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1174301

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1174301 [Bug 1174301] RFE: Apply useful upstream patches and fixes

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5:01 a.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- brutalchess-0.5.2-0.3.alpha.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/brutalchess-0.5.2-0.3.alpha.fc21

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

18 Dec 18 Dec

2:03 p.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|POST |ON_QA

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- brutalchess-0.5.2-0.3.alpha.fc21 has been pushed to the Fedora 21 testing repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

30 Dec 30 Dec

4:42 a.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- brutalchess-0.5.2-0.5.alpha.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/brutalchess-0.5.2-0.5.alpha.fc21

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

1 Jan 1 Jan

4:58 p.m.

New subject: [Bug 1157213] Review Request: brutalchess - Chess game with impressive 3D graphics

https://bugzilla.redhat.com/show_bug.cgi?id=1157213

Fedora Update System updates@fedoraproject.org changed:

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- brutalchess-0.5.2-0.5.alpha.fc21 has been pushed to the Fedora 21 stable repository.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3469

Age (days ago)

3536

Last active (days ago)

package-review@lists.fedoraproject.org

27 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla