[Bug 694950] New: Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: torrent-search  -  A torrent searching graphical application

https://bugzilla.redhat.com/show_bug.cgi?id=694950

Summary: Review Request: torrent-search  -  A torrent searching
                    graphical application
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: medium
         Component: Package Review
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
         QAContact: [e-mail]
                CC: [e-mail], [e-mail]
   Estimated Hours: 0.0
    Classification: Fedora
      Story Points: ---

Spec URL:
http://kumarpraveen.fedorapeople.org/torrent-search/torrent-search.spec
SRPM URL:
http://kumarpraveen.fedorapeople.org/torrent-search/torrent-search-0.9.2-1.f...
Description: Torrent Search looks for torrent files on different websites, and
allows the user to filter the results, making it very easy to find the torrent
you want.

rpmlint output:
#rpmlint ../RPMS/noarch/torrent-search-0.9.2-1.fc14.noarch.rpm 
torrent-search.noarch: W: no-manual-page-for-binary torrent-search-gnomeapplet
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

Fabian Affolter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Fabian Affolter  2011-04-11 02:45:11 EDT ---
Just some quick comments on your spec file:

- You are mixing macro and variable style

https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D...
- There is stuff for zsh. Wouldn't it be a good idea to put this in a
subpackage?
- There is an empty %doc line. The html docs can go there.
- There is a missing BR for the locale files
  https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

--- Comment #2 from Praveen Kumar  2011-04-11 03:22:12 EDT ---
Thanks for suggestions, Here is updated spec and srpm urls

Spec URL:
http://kumarpraveen.fedorapeople.org/torrent-search/torrent-search.spec
SRPM URL:
http://kumarpraveen.fedorapeople.org/torrent-search/torrent-search-0.9.2-2.f...

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

--- Comment #3 from Fabian Affolter  2011-04-11 17:36:19 EDT ---
Koji build failed:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2994517

See also rpmlint output:

[fab@laptop023 SRPMS]$ rpmlint torrent-search-0.9.2-2.fc14.src.rpm 
torrent-search.src:47: W: libdir-macro-in-noarch-package (main package)
%{_libdir}/bonobo/servers/TorrentSearch_Applet.server
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

--- Comment #4 from Fabian Affolter  2011-04-11 17:48:23 EDT ---
(In reply to comment #1)
> There is stuff for zsh. Wouldn't it be a good idea to put this in a
>
> subpackage?

Put the zsh stuff in zsh subpackage of torrent-search.

- torrent-search is a gui application but rpmbuild is not picking up. The
website claims that GTK is needed for the gui.
- Consider to remove the shebangs of the files in the %prep section instead of
chmod in the %install section.

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

--- Comment #5 from Praveen Kumar  2011-04-11 23:06:41 EDT ---
(In reply to comment #4)
> (In reply to comment #1)
> > There is stuff for zsh. Wouldn't it be a good idea to put this in a
> >
> > subpackage?
>
> Put the zsh stuff in zsh subpackage of torrent-search.

Done
> torrent-search is a gui application but rpmbuild is not picking up. The
>
> website claims that GTK is needed for the gui.

Done
> Consider to remove the shebangs of the files in the %prep section instead of
>
> chmod in the %install section.

Here do you mean only python files which are in install section?

Can you please tell me if the package is noarch then what macro should i use
instead of %{_libdir} ?

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

--- Comment #6 from Fabian Affolter  2011-04-12 16:29:27 EDT ---
(In reply to comment #5)
> (In reply to comment #4)
> > Consider to remove the shebangs of the files in the %prep section instead of
> >
> > chmod in the %install section.
>
> Here do you mean only python files which are in install section?

Well, as far as I can see those python files are not called directly. So the
shebang is not needed. The other files have some wired permission.
What I tried to say was that file modification should be done in the %prep
section.

Please report the permission issue upstream.
> Can you please tell me if the package is noarch then what macro should i use
> instead of %{_libdir} ?

Something like (untested)...

%if "%{_lib}" == "lib64"
mv %{buildroot}%{_prefix}/lib/bonobo/servers/TorrentSearch_Applet.server \
   %{buildroot}%{_libdir}/bonobo/servers/TorrentSearch_Applet.server
%endif

...could to the work, but I'm not sure if that's permitted.

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

--- Comment #7 from Praveen Kumar  2011-04-13 04:57:41 EDT ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Consider to remove the shebangs of the files in the %prep section instead of
> > >
> > > chmod in the %install section.
> >
> > Here do you mean only python files which are in install section?
>
> Well, as far as I can see those python files are not called directly. So the
> shebang is not needed. The other files have some wired permission.
> What I tried to say was that file modification should be done in the %prep
> section.
>
> Please report the permission issue upstream.

Reported to upstream waiting for reply.

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

Michal Nowak  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Michal Nowak  2011-05-04 09:45:45 EDT ---
Seeing "Bonobo" and "GNOME Applet" here makes me ask: How does torrent-search
behaves in Fedora 15 with GNOME Shell?

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

--- Comment #9 from Michal Nowak  2011-05-08 12:06:09 EDT ---
torrent-search_0.9.2.3 is out, update the spec file, please.

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

--- Comment #10 from Michal Nowak  2011-05-08 12:26:11 EDT ---
Also noted I don't see icon in Menu->Internet->Torrent Search, seems like a
problem with desktop file.

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

--- Comment #11 from Praveen Kumar  2011-05-09 23:08:24 EDT ---
Thanks for reminding, I will do it with-in 2-3 days.

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

--- Comment #12 from Praveen Kumar  2011-05-15 06:10:33 EDT ---
Updated Spec and SRPM here
SPEC : http://kumarpraveen.fedorapeople.org/torrent-search/torrent-search.spec
SRPM :
http://kumarpraveen.fedorapeople.org/torrent-search/torrent-search-0.9.2.3-3...

Koji Output : http://koji.fedoraproject.org/koji/taskinfo?taskID=3071949

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

--- Comment #13 from Michael Schwendt  2011-05-16 07:48:59 EDT ---
Please read:
https://fedoraproject.org/wiki/Packaging:UnownedDirectories#Common_Mistakes

[
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Owner...
]

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

--- Comment #14 from Praveen Kumar  2011-05-16 12:52:17 EDT ---
(In reply to comment #13)
> Please read:
> https://fedoraproject.org/wiki/Packaging:UnownedDirectories#Common_Mistakes
>
> [
> https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Owner...
> ]

Thanks for suggestion.

SPEC : http://kumarpraveen.fedorapeople.org/torrent-search/torrent-search.spec
SRPM :
http://kumarpraveen.fedorapeople.org/torrent-search/torrent-search-0.9.2.3-4...

Koji Build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3074312

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

--- Comment #15 from Fabian Affolter  2012-03-05 15:59:17 EST ---
The latest release is 0.11.2.

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

--- Comment #16 from Praveen Kumar  2012-03-10 01:37:56 EST ---
Updated
SPEC : http://kumarpraveen.fedorapeople.org/torrent-search/torrent-search.spec
SRPM :
http://kumarpraveen.fedorapeople.org/torrent-search/torrent-search-0.11.2-1....

Koji Build :http://koji.fedoraproject.org/koji/taskinfo?taskID=3876783

I no longer use torrent-search so if someone want to take over it, please go
ahead.

[Bug 694950] Review Request: torrent-search - A torrent searching graphical application

[Red Hat Bugzilla]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=694950

Praveen Kumar  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?