https://bugzilla.redhat.com/show_bug.cgi?id=1016444
Bug ID: 1016444 Summary: ReviewRequest: festige - a GUI frontend to fst and dssi vst (run Windows VST audio plugins under wine) Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: brendan.jones.it@gmail.com QA Contact: extras-qa@fedoraproject.org CC: notting@redhat.com, package-review@lists.fedoraproject.org
festige is a GUI for fst and dssi-vst, allowing you to run Windows VST plugins on Linux
Optionally supports ladish sessions (bug 865699)
SRPM: http://bsjones.fedorapeople.org/reviews/festige-1.0.2-1.src.rpm SPEC: http://bsjones.fedorapeople.org/reviews/festige.spec
https://bugzilla.redhat.com/show_bug.cgi?id=1016444
Brendan Jones brendan.jones.it@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |805236 (FedoraAudio) Depends On| |1015958
--- Comment #1 from Brendan Jones brendan.jones.it@gmail.com --- fst (bug 1015958) is only a runtime requirement and need not hold up this review
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=805236 [Bug 805236] Tracker: Fedora Audio Spin https://bugzilla.redhat.com/show_bug.cgi?id=1015958 [Bug 1015958] Review Request: fst - run VST plugins under wine
https://bugzilla.redhat.com/show_bug.cgi?id=1016444
Bug 1016444 depends on bug 1015958, which changed state.
Bug 1015958 Summary: Review Request: fst - run VST plugins under wine https://bugzilla.redhat.com/show_bug.cgi?id=1015958
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1016444
Eduardo Mayorga e@mayorgalinux.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |e@mayorgalinux.com
--- Comment #2 from Eduardo Mayorga e@mayorgalinux.com --- Some quick comments: * Use %{name} macro in %prep * Add COPYING and README files as %doc * Group tag is deprecated * Just add one package per BuildRequire tag line
I'm not an official packager so this is just an informal review.
https://bugzilla.redhat.com/show_bug.cgi?id=1016444
Volker Fröhlich volker27@gmx.at changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@gmx.at
--- Comment #3 from Volker Fröhlich volker27@gmx.at --- You should BR qt4-devel. However, PyQt4-devel transitively requires qt4-devel anyway, so you can drop it. I'm not sure what the Python modules are necessary for. BR python2 is not necessary.
Use the name macro for patches, use the name and version macro in URL. The spec file and the spec file from the RPM don't match.
You should rather delete fst in the prep section.
Please add COPYING and README as %doc.
The optflags are useless there, as nothing should be compiled.
Can you find a more elegant solution than symlinks?
With fst only being available on i686, the build of this package should be excluded too.
Will it work with Python 3?
sed -i -e 's/Qt/Sequencer/' %{buildroot}%{_datadir}/applications/%{name}.desktop -- Ideally you should not edit the desktop file manually, but through the desktop utils. However, this can go to the prep section.
The README file says:
----- COMPILE: In order to use FeSTige, you first have to compile it. You'll need the devel packages of: - Python - PyQt4 - Qt4 - Wine - Gtk
That seems wrong and you should let the author know, if he's still active. Can you get your changes upstream?
https://bugzilla.redhat.com/show_bug.cgi?id=1016444
Kevin Kofler kevin@tigcc.ticalc.org changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |kevin@tigcc.ticalc.org Blocks| |928937 (qt-reviews)
--- Comment #4 from Kevin Kofler kevin@tigcc.ticalc.org --- This package can also be built for x86_64, using the i686-only fst that hopefully ends up in the x86_64 repository as a multilib. But any non-x86 architectures are indeed hosed, so it needs an ExclusiveArch.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1016444
Rex Dieter rdieter@math.unl.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rdieter@math.unl.edu Alias| |festige
https://bugzilla.redhat.com/show_bug.cgi?id=1016444
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |201449 (FE-DEADREVIEW)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1016444
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan.jones.it@gmail.com, | |projects.rg@smart.ms Flags| |needinfo?(brendan.jones.it@ | |gmail.com)
--- Comment #5 from Raphael Groner projects.rg@smart.ms --- Hi requester, are you still interested in this package? Maybe in doing a review swap?
https://bugzilla.redhat.com/show_bug.cgi?id=1016444
Raphael Groner projects.rg@smart.ms changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed| |2016-10-17 16:18:44
--- Comment #6 from Raphael Groner projects.rg@smart.ms --- I'll close here. This request looks really dead to me, no response from requester since years.
https://bugzilla.redhat.com/show_bug.cgi?id=1016444
Brendan Jones brendan.jones.it@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(brendan.jones.it@ |needinfo- |gmail.com) |
package-review@lists.fedoraproject.org