[Bug 1304097] New: Review Request: ctk - the Common Toolkit for biomedical imaging

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304097

Bug ID: 1304097
           Summary: Review Request: ctk - the Common Toolkit for
                    biomedical imaging
           Product: Fedora
           Version: rawhide
         Component: Package Review
          Severity: medium
          Priority: medium
          Assignee: [e-mail]
          Reporter: [e-mail]
        QA Contact: [e-mail]
                CC: [e-mail]

Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bizdelnick/neuro/ctk.git/plai...
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bizdelnick/neuro/fedora-rawh...
Description: The Common Toolkit is a community effort to provide support code
for medical image analysis, surgical navigation, and related projects.
Fedora Account System Username: bizdelnick

[Bug 1304097] Review Request: ctk - the Common Toolkit for biomedical imaging

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304097

Dmitry Mikhirev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1276941 (fedora-neuro)
              Alias|                            |ctk

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1276941
[Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug

[Bug 1304097] Review Request: ctk - the Common Toolkit for biomedical imaging

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304097

Dmitry Mikhirev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|1276941 (fedora-neuro)      |

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1276941
[Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug

[Bug 1304097] Review Request: ctk - the Common Toolkit for biomedical imaging

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304097

Dmitry Mikhirev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |1276941 (fedora-neuro)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1276941
[Bug 1276941] Fedora NeuroImaging and NeuroScience tracking bug

[Bug 1304097] Review Request: ctk - the Common Toolkit for biomedical imaging

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304097

Zbigniew Jędrzejewski-Szmek  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]    |[e-mail]
              Flags|                            |fedora-review+

--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Is it really worth the trouble to split the plugin-framework and dicom and
widgets subpackages? There're couple hundred kb each.

Summary is not very useful. Maybe:
Summary: Library for medical image analysis, surgical navigation, and related
purposes

Doc subpackage must be noarch!

+ license is acceptable (ASL 2)
+ license file is present, %license is used
+ package name follows guidelines
+ provides/requires look OK
+ scriptlets look OK
+ dependencies between subpackages look OK
+ latest version

rpmlint:
ctk-devel.i686: W: no-documentation
ctk-dicom.i686: W: no-documentation
ctk-plugin-framework.i686: W: no-documentation
ctk-widgets.i686: W: spelling-error Summary(en_US) biomedical -> bio medical,
bio-medical, medical
ctk-widgets.i686: W: spelling-error %description -l en_US biomedical -> bio
medical, bio-medical, medical
ctk-widgets.i686: W: shared-lib-calls-exit /usr/lib/libCTKWidgets.so.0.1.0
exit@GLIBC_2.0
ctk-widgets.i686: W: no-documentation
8 packages and 0 specfiles checked; 0 errors, 7 warnings.
All OK.

Package is APPROVED. Please fix the noarch issue and the summary.

[Bug 1304097] Review Request: ctk - the Common Toolkit for biomedical imaging

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304097

--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
The summary as specified in the bug title is also OK.

[Bug 1304097] Review Request: ctk - the Common Toolkit for biomedical imaging

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304097

--- Comment #3 from Dmitry Mikhirev  ---
Thank you for the review!
> Is it really worth the trouble to split the plugin-framework and dicom and widgets subpackages? There're couple hundred kb each.

Yes, but e. g. dicom subpackage depends on dcmtk that is sensibly bigger.

[Bug 1304097] Review Request: ctk - the Common Toolkit for biomedical imaging

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304097

--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/ctk

[Bug 1304097] Review Request: ctk - the Common Toolkit for biomedical imaging

[Red Hat Bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304097

Dmitry Mikhirev  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |CLOSED
         Resolution|---                         |RAWHIDE
        Last Closed|                            |2016-04-06 18:20:05