https://bugzilla.redhat.com/show_bug.cgi?id=2224713
Bug ID: 2224713 Summary: Review Request: golang-github-apapsch-jsonmerge-2 - Merge JSON objects Product: Fedora Version: rawhide Status: NEW Component: Package Review Assignee: nobody@fedoraproject.org Reporter: zebob.m@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-apapsch-jsonmerge... SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-apapsch-jsonmerge...
Description: Merge JSON objects.
Fedora Account System Username: eclipseo
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
Pavel Solovev daron439@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |daron439@gmail.com Flags| |needinfo?(zebob.m@gmail.com | |)
--- Comment #1 from Pavel Solovev daron439@gmail.com ---
%gobuild -o %{gobuilddir}/bin/jsonmerge %{goipath}/cmd
fails to build with the following error: package github.com/apapsch/go-jsonmerge/v2/cmd: no Go files in /builddir/build/BUILD/go-jsonmerge-2.0.0/_build/src/github.com/apapsch/go-jsonmerge/v2/cmd
Should be %gobuild -o %{gobuilddir}/bin/jsonmerge %{goipath}/cmd/jsonmerge
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
--- Comment #2 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-apapsch-jsonmerge... New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-apapsch-jsonmerge...
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(zebob.m@gmail.com |needinfo?(daron439@gmail.co |) |m)
--- Comment #3 from Robert-André Mauchin 🐧 zebob.m@gmail.com --- Thanks, I had uploaded the wrong version.
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
--- Comment #4 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 1981215 --> https://bugzilla.redhat.com/attachment.cgi?id=1981215&action=edit The .spec file difference from Copr build 6203387 to 6232531
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
Pavel Solovev daron439@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |daron439@gmail.com Status|NEW |POST Flags|needinfo?(daron439@gmail.co |fedora-review+ |m) |
--- Comment #5 from Pavel Solovev daron439@gmail.com --- Golang Package Review ==============
This package was generated using go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
- [x] The specfile is sane. - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The package builds successfully in mock. - [x] Package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] `%goipath` is set correctly. - [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names) - [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default) - [x] The package complies with the Golang and general Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add the package to release-monitoring.org - [ ] Give go-sig privileges (at least commit) on the package - [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
--- Comment #6 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-apapsch-jsonmerge-2
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
Robert-André Mauchin 🐧 zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |MODIFIED Fixed In Version| |golang-github-apapsch-jsonm | |erge-2-2.0.0-1.fc40
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-d1d8958161 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d1d8958161
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-17923dff13 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-17923dff13
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-d1d8958161 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-d1d8958161 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-d1d8958161
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-17923dff13 has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-17923dff13 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-17923dff13
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |MODIFIED
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-83d5515497 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-83d5515497
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-83d5515497 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-83d5515497 *` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-83d5515497
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
https://bugzilla.redhat.com/show_bug.cgi?id=2224713 Bug 2224713 depends on bug 2224692, which changed state.
Bug 2224692 Summary: Review Request: golang-github-ravenox-jsonmerge - Merge JSON objects to one (replaces only existent values) https://bugzilla.redhat.com/show_bug.cgi?id=2224692
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed| |2023-08-28 01:29:19
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-d1d8958161 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-17923dff13 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=2224713
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- FEDORA-2023-83d5515497 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org