[Bug 663926] New: Review Request: lsyncd - Synchronize local directories with a remote targets
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: lsyncd - Synchronize local directories with a remote targets
https://bugzilla.redhat.com/show_bug.cgi?id=663926
Summary: Review Request: lsyncd - Synchronize local directories with a remote targets Product: Fedora Version: rawhide Platform: Unspecified OS/Version: Unspecified Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: pbrobinson@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
SPEC: http://pbrobinson.fedorapeople.org/lsyncd.spec SRPM: http://pbrobinson.fedorapeople.org/lsyncd-2.0.0-1.fc14.src.rpm
Description: Lsyncd watches a local directory trees event monitor interface (inotify). It aggregates and combines events for a few seconds and then spawns one (or more) process(es) to synchronize the changes. By default this is rsync. Lsyncd is thus a light-weight live mirror solution that is comparatively easy to install not requiring new filesystems or blockdevices and does not hamper local filesystem performance.
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2672754
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=663926
Ruben Kerkhof ruben@rubenkerkhof.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ruben@rubenkerkhof.com
--- Comment #1 from Ruben Kerkhof ruben@rubenkerkhof.com 2010-12-17 11:26:53 EST --- Hi Peter,
This looks good to me, but what's missing IMHO is an example config file and an initscript.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=663926
--- Comment #2 from Peter Robinson pbrobinson@gmail.com 2010-12-17 11:45:30 EST ---
This looks good to me, but what's missing IMHO is an example config file and an initscript.
OK, no examples included upstream so I'll have a look at our current custom compiled solution and see what I can come up with.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=663926
Hans de Goede hdegoede@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |hdegoede@redhat.com AssignedTo|nobody@fedoraproject.org |hdegoede@redhat.com Flag| |fedora-review?
--- Comment #3 from Hans de Goede hdegoede@redhat.com 2011-02-10 05:22:45 EST --- I'll review this one.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=663926
--- Comment #4 from Hans de Goede hdegoede@redhat.com 2011-02-10 05:40:13 EST --- Full review done:
Good: ----- - rpmlint checks return: lsyncd.src: W: spelling-error %description -l en_US inotify -> notify, i notify, inotropic lsyncd.src: W: spelling-error %description -l en_US rsync -> sync, r sync, Syncom lsyncd.src: W: spelling-error %description -l en_US filesystems -> file systems, file-systems, ecosystems lsyncd.src: W: spelling-error %description -l en_US blockdevices -> block devices, block-devices, blockades lsyncd.src: W: spelling-error %description -l en_US filesystem -> file system, file-system, systematic <blergh, ignore> lsyncd.src:10: W: macro-in-comment %{name} lsyncd.src:10: W: macro-in-comment %{version} <idem> lsyncd.src: W: no-cleaning-of-buildroot %clean lsyncd.src: W: no-buildroot-tag lsyncd.src: W: no-%clean-section <this is ok for newer Fedora versions> lsyncd.src: W: invalid-url Source0: lsyncd-2.0.0.tar.gz <explained with comment in spec> lsyncd.x86_64: W: spelling-error %description -l en_US inotify -> notify, i notify, inotropic lsyncd.x86_64: W: spelling-error %description -l en_US rsync -> sync, r sync, Syncom lsyncd.x86_64: W: spelling-error %description -l en_US filesystems -> file systems, file-systems, ecosystems lsyncd.x86_64: W: spelling-error %description -l en_US blockdevices -> block devices, block-devices, blockades lsyncd.x86_64: W: spelling-error %description -l en_US filesystem -> file system, file-system, systematic <blergh, ignore> - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file
Needs work: ----------- - rpmlint checks return: lsyncd.x86_64: W: executable-stack /usr/bin/lsyncd Nasty, not good, no idea why it is doing this. May have something to do with lua? - spec says license is GPLv2, but the copyright headers contain "or any later version", should be GPLv2+ - googlecode now seems to have sane download urls, for example: http://lsyncd.googlecode.com/files/lsyncd-2.0.0.tar.gz - upstream has a new 2.0.2 release available
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=663926
Peter Robinson pbrobinson@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |DUPLICATE Last Closed| |2011-05-04 10:23:54
--- Comment #5 from Peter Robinson pbrobinson@gmail.com 2011-05-04 10:23:54 EDT --- It seems a dupe that was filed after this was done
*** This bug has been marked as a duplicate of bug 700757 ***
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla