[Bug 1925322] New: Review Request: golang-github-googlecloudplatform-guest-agent - Guest agent for Google Cloud Platform
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
Bug ID: 1925322 Summary: Review Request: golang-github-googlecloudplatform-guest-agent - Guest agent for Google Cloud Platform Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ericedens@google.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packa... SRPM URL: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packa... Description: Guest agent for Google Cloud Platform Fedora Account System Username: ericedens
- This package depends on golang-github-googlecloudplatform-guest-logging, which is currently being imported: https://pagure.io/releng/fedora-scm-requests/issue/32014 - Tested on Google Cloud Platform (verified SSH and startup script) - fedora-review passes:
➜ fedora-review --copr-build 1945302 INFO: Processing COPR build: 1945302 INFO: Getting .spec, .srpm, .rpm INFO: --> SRPM url: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packa... INFO: --> Spec url: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packa... INFO: --> RPM urls: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packa... https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packa... https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packa... INFO: Using review directory: /home/ericedens/git/fedora-packages/guest-agent/copr-build-1945302/review-golang-github-googlecloudplatform-guest-agent INFO: Downloading .spec, .srpm, .rpm INFO: Downloading (Source0): https://github.com/GoogleCloudPlatform/guest-agent/archive/20201217.02/guest... INFO: Running checks and generating report INFO: Installing built package(s) INFO: Reading configuration from /etc/mock/site-defaults.cfg INFO: Reading configuration from /etc/mock/fedora-rawhide-x86_64.cfg INFO: Active plugins: Generic, Shell-api
Package basesystem-11-11.fc34.noarch contains no files Package dbus-1:1.12.20-3.fc34.x86_64 contains no files Package glibc-minimal-langpack-2.32.9000-29.fc34.x86_64 contains no files INFO: ExclusiveArch dependency checking disabled, enable with EXARCH flag
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
ericedens ericedens@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dustymabe@redhat.com, | |ngompa13@gmail.com Doc Type|--- |If docs needed, set a value
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
ericedens ericedens@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Comment|0 |updated
--- Comment #0 has been edited ---
Spec URL: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packa... SRPM URL: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packa... Description: Guest agent for Google Cloud Platform Fedora Account System Username: ericedens
- This package depends on golang-github-googlecloudplatform-guest-logging, which is currently being imported: https://pagure.io/releng/fedora-scm-requests/issue/32014 - Tested on Google Cloud Platform (verified SSH and startup script) - fedora-review passes: `fedora-review --copr-build 1945302`
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |ngompa13@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1925323
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1925323 [Bug 1925323] Review Request: google-compute-engine - Top-level package for enabling Google Compute Engine features
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
--- Comment #1 from Neal Gompa ngompa13@gmail.com ---
%{_presetdir}/90-google-guest-agent.preset
We cannot ship presets in packages. This needs to requested distro-wide: https://docs.fedoraproject.org/en-US/packaging-guidelines/DefaultServices/#_...
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
--- Comment #2 from ericedens ericedens@google.com --- Interesting, thanks for the link! Added a request: https://bugzilla.redhat.com/show_bug.cgi?id=1926331
Updated: Spec URL: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packa... SRPM URL: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packa... Build: https://copr.fedorainfracloud.org/coprs/ericedens/gcp-guest-packages/build/1...
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1926331
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1926331 [Bug 1926331] systemd presets request - google-guest-agent.service google-startup-scripts.service google-shutdown-scripts.service
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
--- Comment #3 from Neal Gompa ngompa13@gmail.com ---
Provides: google-guest-agent = %{version}-%{release}
Why aren't we naming the package itself "google-guest-agent"?
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
--- Comment #4 from ericedens ericedens@google.com ---
Why aren't we naming the package itself "google-guest-agent"?
I'd like to name it "google-guest-agent"; the current name, though, comes from this: "Golang source packages MUST be named after their main import path"
https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_naming
Or am I misreading this since this package doesn't *provide* Go libraries, it just happens to use Go code.
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
--- Comment #5 from Neal Gompa ngompa13@gmail.com --- (In reply to ericedens from comment #4)
Why aren't we naming the package itself "google-guest-agent"?
I'd like to name it "google-guest-agent"; the current name, though, comes from this: "Golang source packages MUST be named after their main import path"
https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_naming
Or am I misreading this since this package doesn't *provide* Go libraries, it just happens to use Go code.
That rule applies to libraries, not applications.
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
ericedens ericedens@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |golang-github-googlecloudpl |google-guest-agent - Guest |atform-guest-agent - Guest |agent for Google Cloud |agent for Google Cloud |Platform |Platform |
--- Comment #6 from ericedens ericedens@google.com --- Great! Changed to `google-guest-agent`. `fedora-review --copr-build 1963695` passes.
SRPM url: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packa... Spec url: https://download.copr.fedorainfracloud.org/results/ericedens/gcp-guest-packa...
https://bugzilla.redhat.com/show_bug.cgi?id=1925322 Bug 1925322 depends on bug 1926331, which changed state.
Bug 1926331 Summary: systemd presets request - google-guest-agent.service google-startup-scripts.service google-shutdown-scripts.service https://bugzilla.redhat.com/show_bug.cgi?id=1926331
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
--- Comment #7 from Neal Gompa ngompa13@gmail.com --- fedora-review fails because the package cannot be built.
The error returned when trying to install the build dependencies:
* No matching package to install: 'golang(github.com/GoogleCloudPlatform/guest-logging-go/logger)'
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
--- Comment #8 from Neal Gompa ngompa13@gmail.com --- There are no builds of golang-github-googlecloudplatform-guest-logging: https://koji.fedoraproject.org/koji/packageinfo?packageID=33136
You are listed as the maintainer of this library: https://src.fedoraproject.org/rpms/golang-github-googlecloudplatform-guest-l...
Please build it for Rawhide so that it actually exists there.
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(ericedens@google. | |com)
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
ericedens ericedens@google.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ericedens@google. | |com) |
--- Comment #9 from ericedens ericedens@google.com --- Created attachment 1761850 --> https://bugzilla.redhat.com/attachment.cgi?id=1761850&action=edit fedora-review-output.txt
- submitted build for golang-github-googlecloudplatform-guest-logging; currently showing live in F35: https://src.fedoraproject.org/rpms/golang-github-googlecloudplatform-guest-l...
- Ran `fedora-review -b 1925322 -m fedora-rawhide-x86_64`. The build passed, and the results are attached.
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
--- Comment #10 from Neal Gompa ngompa13@gmail.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0", "BSD 3-clause "New" or "Revised" License", "zlib/libpng license". 24 files have unknown license. Detailed output of licensecheck in /home/ngompa/1925322-google-guest-agent/licensecheck.txt [x]: Package requires other packages for directories it uses. Note: No known owner of /etc/default [x]: Package must own all directories that it creates. Note: Directories without known owners: /etc/default [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in google-guest-agent [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: google-guest-agent-20201217.02-1.fc35.x86_64.rpm google-guest-agent-20201217.02-1.fc35.src.rpm google-guest-agent.x86_64: W: spelling-error %description -l en_US init -> unit, int, nit google-guest-agent.x86_64: W: no-manual-page-for-binary google_guest_agent google-guest-agent.x86_64: W: no-manual-page-for-binary google_metadata_script_runner google-guest-agent.src: W: spelling-error %description -l en_US init -> unit, int, nit 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Rpmlint (debuginfo) ------------------- Checking: google-guest-agent-debuginfo-20201217.02-1.fc35.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- google-guest-agent.x86_64: W: spelling-error %description -l en_US init -> unit, int, nit google-guest-agent.x86_64: W: no-manual-page-for-binary google_guest_agent google-guest-agent.x86_64: W: no-manual-page-for-binary google_metadata_script_runner 2 packages and 0 specfiles checked; 0 errors, 3 warnings.
Source checksums ---------------- https://github.com/GoogleCloudPlatform/guest-agent/archive/20201217.02/guest... : CHECKSUM(SHA256) this package : 7f1fac0a9d8ab0af202950fe6f7b6284c30b093611c7819bfc1e1a87c59390a8 CHECKSUM(SHA256) upstream package : 7f1fac0a9d8ab0af202950fe6f7b6284c30b093611c7819bfc1e1a87c59390a8
Requires -------- google-guest-agent (rpmlib, GLIBC filtered): /bin/sh config(google-guest-agent) libc.so.6()(64bit) libpthread.so.0()(64bit) systemd
Provides -------- google-guest-agent: config(google-guest-agent) google-guest-agent google-guest-agent(x86-64)
Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1925322 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: R, C/C++, Haskell, Ocaml, fonts, Python, Perl, SugarActivity, PHP, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+
--- Comment #11 from Neal Gompa ngompa13@gmail.com --- Everything looks good to me. The directory ownership thing with /etc/default doesn't make sense, since that should be owned by filesystem.
PACKAGE APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
--- Comment #12 from ericedens ericedens@google.com --- Requested a repo:
~ fedpkg request-repo google-guest-agent 1925322 https://pagure.io/releng/fedora-scm-requests/issue/32903
The directory ownership thing with /etc/default doesn't make sense
Referring to the `%install` section? For this, I was taking the guidance of [1] which said "The default file mode is 0644 or 0755. Directories should be mode 0755...".
[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
--- Comment #13 from Tomas Hrcka thrcka@redhat.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/google-guest-agent
https://bugzilla.redhat.com/show_bug.cgi?id=1925322
Mattia Verga mattia.verga@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |CURRENTRELEASE Status|POST |CLOSED Last Closed| |2022-03-05 09:54:32
--- Comment #14 from Mattia Verga mattia.verga@protonmail.com --- Package is in repositories, closing.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com