[Bug 574026] New: Review Request: aic94xx-firmware - Adaptec SAS 44300, 48300, 58300 Sequencer Firmware for AIC94xx driver
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: aic94xx-firmware - Adaptec SAS 44300, 48300, 58300 Sequencer Firmware for AIC94xx driver
https://bugzilla.redhat.com/show_bug.cgi?id=574026
Summary: Review Request: aic94xx-firmware - Adaptec SAS 44300, 48300, 58300 Sequencer Firmware for AIC94xx driver Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: tcallawa@redhat.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Target Release: ---
Spec URL: http://www.auroralinux.org/people/spot/review/new/aic94xx-firmware.spec SRPM URL: http://www.auroralinux.org/people/spot/review/new/aic94xx-firmware-30-1.fc14... Description: Adaptec SAS 44300, 48300, 58300 Sequencer Firmware for Open-Source AIC94xx Driver.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574026
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |lemenkov@gmail.com AssignedTo|nobody@fedoraproject.org |lemenkov@gmail.com Flag| |fedora-review?
--- Comment #1 from Peter Lemenkov lemenkov@gmail.com 2010-03-17 00:31:33 EDT --- REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is NOT silent, but these messages are false positive.
Sulaco ~/rpmbuild/SPECS: rpmlint ../RPMS/noarch/aic94xx-firmware-30-1.fc12.noarch.rpm aic94xx-firmware.noarch: W: spelling-error Summary(en_US) Adaptec -> Adapter, Adapted, Adaption aic94xx-firmware.noarch: W: spelling-error %description -l en_US Adaptec -> Adapter, Adapted, Adaption 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Sulaco ~/rpmbuild/SPECS:
+ The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license. + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL.
Sulaco ~/rpmbuild/SPECS: sha256sum ../SOURCES/aic94xx-seq-30-1.tar.gz* 0608a919b95e65e8fe3c0cbc15f7e559716bda39a6efca863417a65f75e15478 ../SOURCES/aic94xx-seq-30-1.tar.gz 0608a919b95e65e8fe3c0cbc15f7e559716bda39a6efca863417a65f75e15478 ../SOURCES/aic94xx-seq-30-1.tar.gz.1 Sulaco ~/rpmbuild/SPECS:
+ The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files. + The package does NOT bundle copies of system libraries. + The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages.
- At the beginning of %install, the package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
+ All filenames in rpm packages are valid UTF-8.
Please, add "rm -rf %{buildroot}" at the beginning of %install section, and I'll continue.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574026
--- Comment #2 from Tom "spot" Callaway tcallawa@redhat.com 2010-03-17 08:59:12 EDT --- Peter, it is no longer necessary to delete the buildroot at the beginning of %install, because RPM in Fedora 10 and newer does this for you. Please refer to:
https://fedoraproject.org/wiki/Packaging/Guidelines#Prepping_BuildRoot_For_....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574026
Peter Lemenkov lemenkov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #3 from Peter Lemenkov lemenkov@gmail.com 2010-03-17 09:04:23 EDT --- Thanks for pointing me out on this.
Ok, then this package is
APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574026
Tom "spot" Callaway tcallawa@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
--- Comment #4 from Tom "spot" Callaway tcallawa@redhat.com 2010-03-17 09:08:11 EDT --- New Package CVS Request ======================= Package Name: aic94xx-firmware Short Description: Adaptec SAS 44300, 48300, 58300 Sequencer Firmware for Open-Source AIC94xx Driver Owners: spot Branches: F-11 F-12 F-13 devel InitialCC:
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574026
--- Comment #5 from Kevin Fenzi kevin@tummy.com 2010-03-17 14:25:12 EDT --- CVS done (by process-cvs-requests.py).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574026
--- Comment #6 from Peter Lemenkov lemenkov@gmail.com 2010-04-04 12:24:59 EDT --- Ping! It seems that already built packages still didn't get pushed to repositories.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574026
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2010-04-06 08:59:34 EDT --- aic94xx-firmware-30-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/aic94xx-firmware-30-1.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574026
--- Comment #8 from Fedora Update System updates@fedoraproject.org 2010-04-06 08:59:39 EDT --- aic94xx-firmware-30-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/aic94xx-firmware-30-1.fc11
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574026
--- Comment #9 from Fedora Update System updates@fedoraproject.org 2010-04-06 08:59:43 EDT --- aic94xx-firmware-30-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/aic94xx-firmware-30-1.fc13
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574026
--- Comment #10 from Fedora Update System updates@fedoraproject.org 2010-04-08 21:33:50 EDT --- aic94xx-firmware-30-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574026
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Fixed In Version| |aic94xx-firmware-30-1.fc11 Resolution| |ERRATA
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574026
--- Comment #11 from Fedora Update System updates@fedoraproject.org 2010-04-08 21:44:32 EDT --- aic94xx-firmware-30-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574026
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|aic94xx-firmware-30-1.fc11 |aic94xx-firmware-30-1.fc12
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574026
--- Comment #12 from Fedora Update System updates@fedoraproject.org 2010-04-09 00:07:27 EDT --- aic94xx-firmware-30-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=574026
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|aic94xx-firmware-30-1.fc12 |aic94xx-firmware-30-1.fc13
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla