[Bug 1451075] New: Review Request: python-pankoclient Pyton API client for Openstack Panko Events Service
https://bugzilla.redhat.com/show_bug.cgi?id=1451075
Bug ID: 1451075 Summary: Review Request: python-pankoclient Pyton API client for Openstack Panko Events Service Product: Fedora Version: rawhide Component: Package Review Assignee: nobody@fedoraproject.org Reporter: pkilambi@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Description of problem:
Spec URL: https://pkilambi.fedorapeople.org/python-pankoclient/python-pankoclient.spec SRPM URL: https://pkilambi.fedorapeople.org/python-pankoclient/python-pankoclient-0.3....
Description: Python API and CLI for Openstack Panko service
Fedora Account System Username: pkilambi
https://bugzilla.redhat.com/show_bug.cgi?id=1451075
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |karlthered@gmail.com Assignee|nobody@fedoraproject.org |karlthered@gmail.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1451075
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #1 from Haïkel Guémar karlthered@gmail.com --- Since -tests subpackages requires main python subpackages, they don't need to ship LICENSE file, you may remove it during import. I fixed installation failure by updating oslo.utils in rawhide.
I hereby approve this package into Fedora Packages Collection.
Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines => needs to update oslo.utils in rawhide (I updated it to 3.22.0 from ocata)
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 56 files have unknown license. Detailed output of licensecheck in /home/haikel/1451075-python- pankoclient/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.6/site- packages, /usr/lib/python3.6 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-pankoclient , python-pankoclient-doc , python3-pankoclient , python3-pankoclient-tests [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [x]: Spec file according to URL is the same as in SRPM.
Installation errors ------------------- INFO: mock.py version 1.3.4 starting (python version = 3.5.3)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.3.4 INFO: Mock Version: 1.3.4 Finish: chroot init INFO: installing package(s): /home/haikel/1451075-python-pankoclient/results/python3-pankoclient-tests-0.3.0-1.fc27.noarch.rpm /home/haikel/1451075-python-pankoclient/results/python2-pankoclient-tests-0.3.0-1.fc27.noarch.rpm /home/haikel/1451075-python-pankoclient/results/python3-pankoclient-0.3.0-1.fc27.noarch.rpm /home/haikel/1451075-python-pankoclient/results/python2-pankoclient-0.3.0-1.fc27.noarch.rpm /home/haikel/1451075-python-pankoclient/results/python-pankoclient-doc-0.3.0-1.fc27.noarch.rpm ERROR: Command failed. See logs for output. # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 27 --disableplugin=local --setopt=deltarpm=false install /home/haikel/1451075-python-pankoclient/results/python3-pankoclient-tests-0.3.0-1.fc27.noarch.rpm /home/haikel/1451075-python-pankoclient/results/python2-pankoclient-tests-0.3.0-1.fc27.noarch.rpm /home/haikel/1451075-python-pankoclient/results/python3-pankoclient-0.3.0-1.fc27.noarch.rpm /home/haikel/1451075-python-pankoclient/results/python2-pankoclient-0.3.0-1.fc27.noarch.rpm /home/haikel/1451075-python-pankoclient/results/python-pankoclient-doc-0.3.0-1.fc27.noarch.rpm --setopt=tsflags=nocontexts
Rpmlint ------- Checking: python2-pankoclient-0.3.0-1.fc27.noarch.rpm python-pankoclient-doc-0.3.0-1.fc27.noarch.rpm python2-pankoclient-tests-0.3.0-1.fc27.noarch.rpm python3-pankoclient-0.3.0-1.fc27.noarch.rpm python3-pankoclient-tests-0.3.0-1.fc27.noarch.rpm python-pankoclient-0.3.0-1.fc27.src.rpm python-pankoclient-doc.noarch: W: spelling-error %description -l en_US panko -> pinko, panto, spank python-pankoclient-doc.noarch: W: file-not-utf8 /usr/share/doc/python-pankoclient-doc/html/objects.inv python2-pankoclient-tests.noarch: W: no-documentation python3-pankoclient-tests.noarch: W: invalid-url URL: https://github.com/openstack/python-pankoclient The read operation timed out python3-pankoclient-tests.noarch: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 5 warnings.
Requires -------- python2-pankoclient-tests (rpmlib, GLIBC filtered): python(abi) python-pankoclient
python-pankoclient-doc (rpmlib, GLIBC filtered):
python3-pankoclient-tests (rpmlib, GLIBC filtered): python(abi) python3-pankoclient
python2-pankoclient (rpmlib, GLIBC filtered): python(abi) python-keystoneauth1 python-osc-lib python-oslo-serialization python-oslo-utils python-six
python3-pankoclient (rpmlib, GLIBC filtered): python(abi) python3-keystoneauth1 python3-osc-lib python3-oslo-serialization python3-oslo-utils python3-six
Provides -------- python2-pankoclient-tests: python2-pankoclient-tests
python-pankoclient-doc: python-pankoclient-doc
python3-pankoclient-tests: python3-pankoclient-tests
python2-pankoclient: python-pankoclient python2-pankoclient python2.7dist(pankoclient) python2dist(pankoclient)
python3-pankoclient: python3-pankoclient python3.6dist(pankoclient) python3dist(pankoclient)
Source checksums ---------------- https://tarballs.openstack.org/python-pankoclient/pankoclient-0.3.0.tar.gz : CHECKSUM(SHA256) this package : 21c06c6a990022ec10ce0e9b2ed2a05472c392b28b645e74273114c116f82580 CHECKSUM(SHA256) upstream package : 21c06c6a990022ec10ce0e9b2ed2a05472c392b28b645e74273114c116f82580
Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1451075 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
https://bugzilla.redhat.com/show_bug.cgi?id=1451075
--- Comment #2 from Gwyn Ciesla limburgher@gmail.com --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pankoclient
https://bugzilla.redhat.com/show_bug.cgi?id=1451075
--- Comment #3 from Fedora Update System updates@fedoraproject.org --- python-pankoclient-0.3.0-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1f2f1e0b5f
https://bugzilla.redhat.com/show_bug.cgi?id=1451075
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1451075
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- python-pankoclient-0.3.0-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1f2f1e0b5f
https://bugzilla.redhat.com/show_bug.cgi?id=1451075
Haïkel Guémar karlthered@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed| |2017-06-02 12:07:30
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com