https://bugzilla.redhat.com/show_bug.cgi?id=2363205
Bug ID: 2363205 Summary: Review Request: hyprgraphics - Graphics library for Hyprland Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: nighti@nighti.dev QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/nightishaman/hyprland/fed... SRPM URL: https://download.copr.fedorainfracloud.org/results/nightishaman/hyprland/fed... Description: Hyprgraphics is a small C++ library with graphics / resource related utilities used across the hypr* ecosystem. Fedora Account System Username: nightishaman
Hyprgraphics is needed to update the Hyprland package.
https://bugzilla.redhat.com/show_bug.cgi?id=2363205
Fedora Review Service fedora-review-bot@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |AutomationTriaged URL| |https://github.com/hyprwm/h | |yprgraphics
--- Comment #1 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/8984918 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2363205
Pavel Solovev daron439@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |daron439@gmail.com
--- Comment #2 from Pavel Solovev daron439@gmail.com --- hyprgraphics.src: W: summary-ended-with-dot The hyprland cursor format, library and utilities. And it's from the hyprcursor package.
[!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/hyprgraphics/cairo, /usr/include/hyprgraphics, /usr/include/hyprgraphics/image, /usr/include/hyprgraphics/color
Replace %{_includedir}/hyprgraphics/cairo/CairoSurface.hpp %{_includedir}/hyprgraphics/color/Color.hpp %{_includedir}/hyprgraphics/image/Image.hpp with %{_includedir}/hyprgraphics/
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites Add %check %ctest
Missing optional support for libjxl https://github.com/hyprwm/hyprgraphics/blob/60754910946b4e2dc1377b967b7156cb...
https://bugzilla.redhat.com/show_bug.cgi?id=2363205
--- Comment #3 from Jannik Müller nighti@nighti.dev --- Spec URL: https://download.copr.fedorainfracloud.org/results/nightishaman/hyprland/fed... SRPM URL: https://download.copr.fedorainfracloud.org/results/nightishaman/hyprland/fed... Description: Hyprgraphics is a small C++ library with graphics / resource related utilities used across the hypr* ecosystem. Fedora Account System Username: nightishaman
Thanks for the review, I really appreciate it. I'm sorry for the errors. That was very embarrassing and I fixed it here. Unfortunately, big endian architectures like s390x wont allow it to compile since hyprgraphics has an endianness check, so I disabled that architecture.
https://bugzilla.redhat.com/show_bug.cgi?id=2363205
--- Comment #4 from Pavel Solovev daron439@gmail.com --- The failure is limited to jpeg - it's possible to skip that test like this:
%check %ifarch s390x rm tests/resource/images/hyprland.jpg %endif %ctest
You're using %if %{with libjxl}, but the build conditional(%bcond libjxl 1) is missing.
https://bugzilla.redhat.com/show_bug.cgi?id=2363205
--- Comment #5 from Jannik Müller nighti@nighti.dev --- Spec URL: https://download.copr.fedorainfracloud.org/results/nightishaman/hyprland/fed... SRPM URL: https://download.copr.fedorainfracloud.org/results/nightishaman/hyprland/fed... Description: Hyprgraphics is a small C++ library with graphics / resource related utilities used across the hypr* ecosystem. Fedora Account System Username: nightishaman
Fixed that.
https://bugzilla.redhat.com/show_bug.cgi?id=2363205
--- Comment #6 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Created attachment 2090025 --> https://bugzilla.redhat.com/attachment.cgi?id=2090025&action=edit The .spec file difference from Copr build 8984918 to 9052337
https://bugzilla.redhat.com/show_bug.cgi?id=2363205
--- Comment #7 from Fedora Review Service fedora-review-bot@fedoraproject.org --- Copr build: https://copr.fedorainfracloud.org/coprs/build/9052337 (succeeded)
Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-rev...
Please take a look if any issues were found.
--- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
https://bugzilla.redhat.com/show_bug.cgi?id=2363205
Pavel Solovev daron439@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |POST
--- Comment #8 from Pavel Solovev daron439@gmail.com --- Package Review ==============
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed
===== MUST items =====
C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 3-Clause License". 32 files have unknown license. Detailed output of licensecheck in /home/builduser/build/2363205-hyprgraphics/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 855 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: hyprgraphics-0.1.3-1.fc43.x86_64.rpm hyprgraphics-devel-0.1.3-1.fc43.x86_64.rpm hyprgraphics-0.1.3-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpzy3fi7m4')] checks: 32, packages: 3
hyprgraphics-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 21 filtered, 0 badness; has taken 0.2 s
Rpmlint (debuginfo) ------------------- Checking: hyprgraphics-debuginfo-0.1.3-1.fc43.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpa9qubibu')] checks: 32, packages: 1
1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s
Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3
hyprgraphics-devel.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 23 filtered, 0 badness; has taken 0.3 s
Source checksums ---------------- https://github.com/hyprwm/hyprgraphics/archive/v0.1.3/hyprgraphics-0.1.3.tar... : CHECKSUM(SHA256) this package : 0e11457135a9e7160cf147d361fae3c5dc40035a4ebd894c5d409baa896f43cf CHECKSUM(SHA256) upstream package : 0e11457135a9e7160cf147d361fae3c5dc40035a4ebd894c5d409baa896f43cf
Requires -------- hyprgraphics (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcairo.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libhyprutils.so.1()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEGTURBO_6.2)(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) libjxl.so.0.11()(64bit) libjxl.so.0.11(JXL_0)(64bit) libjxl_threads.so.0.11()(64bit) libjxl_threads.so.0.11(JXL_0)(64bit) libm.so.6()(64bit) libmagic.so.1()(64bit) libspng.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libwebp.so.7()(64bit) rtld(GNU_HASH)
hyprgraphics-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config hyprgraphics(x86-64) libhyprgraphics.so.0()(64bit)
Provides -------- hyprgraphics: hyprgraphics hyprgraphics(x86-64) libhyprgraphics.so.0()(64bit)
hyprgraphics-devel: hyprgraphics-devel hyprgraphics-devel(x86-64) pkgconfig(hyprgraphics)
Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2363205 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Java, Ocaml, fonts, SugarActivity, Perl, PHP, R, Python, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Approved.
https://bugzilla.redhat.com/show_bug.cgi?id=2363205
Jannik Müller nighti@nighti.dev changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |daron439@gmail.com
--- Comment #9 from Jannik Müller nighti@nighti.dev --- Thanks!
https://bugzilla.redhat.com/show_bug.cgi?id=2363205
Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |RELEASE_PENDING
--- Comment #10 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/hyprgraphics
https://bugzilla.redhat.com/show_bug.cgi?id=2363205
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RELEASE_PENDING |MODIFIED
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-626b5391e5 (hyprgraphics-0.1.3-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-626b5391e5
https://bugzilla.redhat.com/show_bug.cgi?id=2363205
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |ERRATA Status|MODIFIED |CLOSED Last Closed| |2025-05-15 22:59:16
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- FEDORA-2025-626b5391e5 (hyprgraphics-0.1.3-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com