[Bug 1519834] New: Review Request: BOUT++ - Computational fluid simulation library for curvi-linear geometries
https://bugzilla.redhat.com/show_bug.cgi?id=1519834
Bug ID: 1519834 Summary: Review Request: BOUT++ - Computational fluid simulation library for curvi-linear geometries Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@fedoraproject.org Reporter: david08741@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://github.com/dschwoerer/bout-spec/raw/master/bout%2B%2B.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/davidsch/bout/fedora-rawhide... Description:
BOUT++ is a framework for writing fluid and plasma simulations in curvilinear geometry. It is intended to be quite modular, with a variety of numerical methods and time-integration solvers available. BOUT++ is primarily designed and tested with reduced plasma fluid models in mind, but it can evolve any number of equations, with equations appearing in a readable form.
Fedora Account System Username: davidsch
https://bugzilla.redhat.com/show_bug.cgi?id=1519834
Robert-André Mauchin zebob.m@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com Blocks| |177841 (FE-NEEDSPONSOR)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=1519834
Iwicki Artur fedora@svgames.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@svgames.pl
--- Comment #1 from Iwicki Artur fedora@svgames.pl ---
Group: Applications/Engineering Group: Development/Libraries
The "Group:" tag should not be used. https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections
License: LGPLv3
The README in the GitHub repo says it's LGPL v3 or later, so this should be "LGPLv3+".
Source0: https://github.com/boutproject/BOUT-dev/archive/v%%7Bversion%7D.tar.gz#/%%7B...
I think you can use this prettier URL: https://github.com/boutproject/BOUT-dev/archive/v%%7Bversion%7D/%%7Bname%7D-...
%global debug_package %{nil}
The packaging guidelines require adding a comment to justify why debuginfo is disabled. https://fedoraproject.org/wiki/Packaging:Debuginfo#Useless_or_incomplete_deb...
https://bugzilla.redhat.com/show_bug.cgi?id=1519834
david08741@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |david08741@gmail.com
--- Comment #2 from david08741@gmail.com --- Thanks for the Feedback.
The debug_package is disabled, as BOUT++ currently only builds a static .a archive.
About the rpmlint warnings: rpmlint bout++.spec noarch/* x86_64/* bout++.spec:149: W: setup-not-quiet bout++-common.noarch: W: spelling-error %description -l en_US curvilinear -> rectilinear python2-bout++.noarch: W: spelling-error %description -l en_US pre -> per, ore, pee python2-bout++.noarch: W: no-documentation python3-bout++.noarch: W: spelling-error %description -l en_US pre -> per, ore, pee python3-bout++.noarch: W: no-documentation bout++-mpich-devel.x86_64: W: spelling-error %description -l en_US curvilinear -> rectilinear bout++-mpich-devel.x86_64: W: no-documentation bout++-openmpi-devel.x86_64: W: spelling-error %description -l en_US curvilinear -> rectilinear bout++-openmpi-devel.x86_64: W: no-documentation 5 packages and 1 specfiles checked; 0 errors, 10 warnings. The no-documentation warning is not justified, as the packages require bout++-common, which includes the documentation. The spelling errors are no errors (curvilinear is just not that comment then rectilinear).
I am not sure about the setup-not-quiet warning. Should it be fixed. If so, how?
Updated Spec: https://github.com/dschwoerer/bout-spec/raw/master/bout%2B%2B.spec Updated SRPM: https://copr-be.cloud.fedoraproject.org/results/davidsch/bout/fedora-rawhide...
https://bugzilla.redhat.com/show_bug.cgi?id=1519834
--- Comment #3 from david08741@gmail.com --- I fixed the setup-not-quite warning.
By now BOUT++ has also a python interface, which is packaged for python3.
A debug package is built, as support for shared objects was added.
The new rpmlint warnings are: $ rpmlint bout++.spec noarch/* x86_64/* bout++.spec:88: W: unversioned-explicit-provides bundled(libpvode) bout++.spec:139: W: unversioned-explicit-provides bundled(libpvode) bout++-common.noarch: W: spelling-error %description -l en_US curvilinear -> rectilinear bout++-doc.noarch: W: spelling-error %description -l en_US curvilinear -> rectilinear bout++-doc.noarch: W: manual-page-warning /usr/share/man/man1/bout++.1.gz 5043: normal or special character expected (got a space) bout++-doc.noarch: W: manual-page-warning /usr/share/man/man1/bout++.1.gz 5097: warning: numeric expression expected (got `o') bout++-doc.noarch: W: manual-page-warning /usr/share/man/man1/bout++.1.gz 5194: warning: numeric expression expected (got `r') bout++-doc.noarch: W: manual-page-warning /usr/share/man/man1/bout++.1.gz 5200: warning: numeric expression expected (got `r') bout++-doc.noarch: W: manual-page-warning /usr/share/man/man1/bout++.1.gz 5261: warning: numeric expression expected (got `r') [...] bout++-doc.noarch: W: manual-page-warning /usr/share/man/man1/bout++.1.gz 35289: warning: numeric expression expected (got `\e') bout++-doc.noarch: W: manual-page-warning /usr/share/man/man1/bout++.1.gz 46583: `m' is an invalid argument to \O bout++-doc.noarch: W: manual-page-warning /usr/share/man/man1/bout++.1.gz 59851: warning: numeric expression expected (got `g') bout++-doc.noarch: W: manual-page-warning /usr/share/man/man1/bout++.1.gz 59852: warning: numeric expression expected (got `g') bout++-doc.noarch: W: manual-page-warning /usr/share/man/man1/bout++.1.gz 59857: warning: numeric expression expected (got `g') bout++-doc.noarch: W: manual-page-warning /usr/share/man/man1/bout++.1.gz 59857: warning: numeric expression expected (got `g') python3-bout++.noarch: W: spelling-error %description -l en_US pre -> per, ore, pee python3-bout++.noarch: W: no-documentation bout++-mpich.x86_64: W: spelling-error %description -l en_US curvilinear -> rectilinear bout++-mpich.x86_64: W: no-documentation bout++-mpich-devel.x86_64: W: spelling-error %description -l en_US curvilinear -> rectilinear bout++-mpich-devel.x86_64: W: only-non-binary-in-usr-lib bout++-mpich-devel.x86_64: W: no-documentation bout++-openmpi.x86_64: W: spelling-error %description -l en_US curvilinear -> rectilinear bout++-openmpi.x86_64: W: no-documentation bout++-openmpi-devel.x86_64: W: spelling-error %description -l en_US curvilinear -> rectilinear bout++-openmpi-devel.x86_64: W: only-non-binary-in-usr-lib bout++-openmpi-devel.x86_64: W: no-documentation python3-bout++-mpich.x86_64: W: no-documentation python3-bout++-openmpi.x86_64: W: spelling-error Summary(en_US) mpich -> chimp python3-bout++-openmpi.x86_64: W: no-documentation 15 packages and 1 specfiles checked; 0 errors, 186 warnings.
I am uncertain about the man page warnings - I don't think it is worth fixing them, as the man page is generated by sphinx. Is it better to not shop the man page, or ship a potentially broken one? More troublesome to me seems the fact that I cannot find and open the man page after installing the rpm with dnf. If I download with dnf, and install with rpm, the man page is available. Any ideas why that might be happening?
BOUT++ comes with libpvode - I would like to ship the bundled upstream version to give the same results as the upstream code. From [1] it seems ok to bundle. BOUT++ can be build with more recent versions, but they are not packaged.
The only-non-binary-in-usr-lib is due to mpi - the specific header files are located in the mpi folders.
The rawhide build fails on copr, but is fine with koji scratch builds. I was also unable to reproduce this issue locally with mock or a container. Not sure why there are illegal instructions.
Updated Spec: https://github.com/dschwoerer/bout-spec/raw/master/bout%2B%2B.spec New Builds: https://copr.fedorainfracloud.org/coprs/davidsch/bout/build/833821/
[1] https://fedoraproject.org/wiki/Bundled_Libraries
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com